Skip to content

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Oct 25, 2015

@matthiasnoback
Copy link

Thanks for reporting :) I'm not sold yet though. I understand the reasoning behind it, but I guess that when a new major version of PHP arrives and it turns out not to be compatible, we'll fix things anyway (and don't want to prevent people from installing this package anyway).
Now we need to update all existing packages and create new releases for something that doesn't have an effect on anybody (maybe in a few years) ;)

@ruudk
Copy link
Contributor Author

ruudk commented Oct 27, 2015

Fair enough :)

@ruudk ruudk closed this Oct 27, 2015
@TomasVotruba
Copy link

Tests passes on PHP 7.0 very well. Could we at least remove redundant PHP 7.0 allowed_failures?

@matthiasnoback
Copy link

By all means, yes! That makes sense. That wouldn't even require a new
release.
On Oct 27, 2015 9:20 AM, "Tomáš Votruba" notifications@github.com wrote:

Tests passes on PHP 7.0 very well. Could we at least remove redundant PHP
7.0 allowed_failures?


Reply to this email directly or view it on GitHub
#37 (comment).

@ruudk
Copy link
Contributor Author

ruudk commented Oct 27, 2015

PR added!

@matthiasnoback
Copy link

Thanks!

@ruudk ruudk deleted the patch-1 branch October 27, 2015 09:52
@TomasVotruba
Copy link

👍 Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants