-
Notifications
You must be signed in to change notification settings - Fork 88.7k
[ICP-13654] Added specific UI metadata for Qubino dimmers #52444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
*/ | ||
metadata { | ||
definition(name: "Qubino Dimmer", namespace: "qubino", author: "SmartThings", mnmn: "SmartThings", vid:"generic-dimmer-power-energy", ocfDeviceType: "oic.d.switch", runLocally: false, executeCommandsLocally: false) { | ||
definition(name: "Qubino Dimmer", namespace: "qubino", author: "SmartThings", mnmn: "SmartThings", vid:"qubino-dimmer-power-energy", ocfDeviceType: "oic.d.switch", runLocally: false, executeCommandsLocally: false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's different about this metadata?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought @KKlimczukS 's changes made it so that despite the device's internal range being 2-100, we scaled our commands so that the user still saw 1-100?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Konrad set minimum dimming level as 2% in the device configuration, but because device starts recalculating those values when the range is different we had to remove this configuration (ICP-13654, ICP-13361). We decided to set this range by UI metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@greens We had to find another approach/workaround and constraint those min dimming values from the application (DTH and UI) side instead of setting this configuration parameter on the device - that's was the only way to make it work and avoid dimmer level jumping (on the UI slider, in a quite non deterministic way).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, well then whenever you're ready @MWierzbinskaS
…sCommunity#52444) * ICP-13654 Added specific UI metadata for qubino dimmers * Added custom metadata for qubino flush dimmer 0-10V
@SmartThingsCommunity/srpol-pe-team
@greens
Could you please take a look at the code?