Skip to content

Conversation

MWierzbinskaS
Copy link
Contributor

@SmartThingsCommunity/srpol-pe-team
@greens

Could you please take a look at the code?

*/
metadata {
definition(name: "Qubino Dimmer", namespace: "qubino", author: "SmartThings", mnmn: "SmartThings", vid:"generic-dimmer-power-energy", ocfDeviceType: "oic.d.switch", runLocally: false, executeCommandsLocally: false) {
definition(name: "Qubino Dimmer", namespace: "qubino", author: "SmartThings", mnmn: "SmartThings", vid:"qubino-dimmer-power-energy", ocfDeviceType: "oic.d.switch", runLocally: false, executeCommandsLocally: false) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's different about this metadata?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greens It changes dimming range in UI metadata from 1-100% to 2-100% (More info why we wanted to set 2% as minimum, please see this PR comments: #37228)

But as I checked, those metadata are still not merged. I will change its status as draft

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought @KKlimczukS 's changes made it so that despite the device's internal range being 2-100, we scaled our commands so that the user still saw 1-100?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Konrad set minimum dimming level as 2% in the device configuration, but because device starts recalculating those values when the range is different we had to remove this configuration (ICP-13654, ICP-13361). We decided to set this range by UI metadata.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greens We had to find another approach/workaround and constraint those min dimming values from the application (DTH and UI) side instead of setting this configuration parameter on the device - that's was the only way to make it work and avoid dimmer level jumping (on the UI slider, in a quite non deterministic way).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, well then whenever you're ready @MWierzbinskaS

@MWierzbinskaS MWierzbinskaS marked this pull request as draft December 16, 2020 15:54
@MWierzbinskaS MWierzbinskaS marked this pull request as ready for review January 25, 2021 11:12
@greens greens merged commit 3751571 into SmartThingsCommunity:master Jan 25, 2021
shinasys pushed a commit to shinasys/SmartThingsPublic that referenced this pull request Apr 29, 2021
…sCommunity#52444)

* ICP-13654 Added specific UI metadata for qubino dimmers

* Added custom metadata for qubino flush dimmer 0-10V
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants