Skip to content

[ICP-13654] Added specific UI metadata for Qubino dimmers #52444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2021
Merged

[ICP-13654] Added specific UI metadata for Qubino dimmers #52444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
579314a
ICP-13654 Added specific UI metadata for qubino dimmers
MWierzbinskaS Dec 11, 2020
6bb98de
Added custom metadata for qubino flush dimmer 0-10V
MWierzbinskaS Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions devicetypes/qubino/qubino-dimmer.src/qubino-dimmer.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
*
*/
metadata {
definition(name: "Qubino Dimmer", namespace: "qubino", author: "SmartThings", mnmn: "SmartThings", vid:"generic-dimmer-power-energy", ocfDeviceType: "oic.d.switch", runLocally: false, executeCommandsLocally: false) {
definition(name: "Qubino Dimmer", namespace: "qubino", author: "SmartThings", mnmn: "SmartThings", vid:"qubino-dimmer-power-energy", ocfDeviceType: "oic.d.switch", runLocally: false, executeCommandsLocally: false) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's different about this metadata?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greens It changes dimming range in UI metadata from 1-100% to 2-100% (More info why we wanted to set 2% as minimum, please see this PR comments: #37228)

But as I checked, those metadata are still not merged. I will change its status as draft

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought @KKlimczukS 's changes made it so that despite the device's internal range being 2-100, we scaled our commands so that the user still saw 1-100?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Konrad set minimum dimming level as 2% in the device configuration, but because device starts recalculating those values when the range is different we had to remove this configuration (ICP-13654, ICP-13361). We decided to set this range by UI metadata.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greens We had to find another approach/workaround and constraint those min dimming values from the application (DTH and UI) side instead of setting this configuration parameter on the device - that's was the only way to make it work and avoid dimmer level jumping (on the UI slider, in a quite non deterministic way).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, well then whenever you're ready @MWierzbinskaS

capability "Actuator"
capability "Configuration"
capability "Energy Meter"
Expand All @@ -33,7 +33,7 @@ metadata {

// Qubino Flush Dimmer 0-10V - ZMNHVD
// Raw Description: zw:L type:1100 mfr:0159 prod:0001 model:0053 ver:2.04 zwv:4.34 lib:03 cc:5E,86,5A,72,73,27,25,26,85,8E,59,70 ccOut:20,26 role:05 ff:9C00 ui:9C00
fingerprint mfr: "0159", prod: "0001", model: "0053", deviceJoinName: "Qubino Dimmer", mnmn: "SmartThings", vid:"generic-dimmer"
fingerprint mfr: "0159", prod: "0001", model: "0053", deviceJoinName: "Qubino Dimmer", mnmn: "SmartThings", vid:"qubino-dimmer"

//Qubino Mini Dimmer
// Raw Description: zw:Ls type:1101 mfr:0159 prod:0001 model:0055 ver:20.02 zwv:5.03 lib:03 cc:5E,6C,55,98,9F sec:86,25,26,85,59,72,5A,70,32,71,73
Expand Down