-
Notifications
You must be signed in to change notification settings - Fork 128
feat: added prompted device profile creation and device view commands #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
|
|
||
| // eslint-disable-next-line no-console | ||
| //console.log(`Creating presentation from ${JSON.stringify(presentationData, null, 2)}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is some test logging left here and above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
| presentationData = augmentPresentationValues(presentationData) | ||
| } else { | ||
| // eslint-disable-next-line no-console | ||
| //console.log('Generating presentation') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last commented console left, otherwise looks good.
Changes to make it easier to work with device profiles, device configurations, and device presentation. Significant changes are:
Prompt/Response device profile creation
Automatic device-config from above device profile creation
Default behavior is to use the first capability of the main component in the dashboard, include all capabilities in the detail view, include all capabilities with attributes in the automation conditions, and all capabilities with commands in automation actions.
Creating device profile and config with view property
The following example creates a switch that (intentionally) cannot be controlled by an automation since it defines no automation actions: