Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rule S6679 (no-self-compare): Number.isNaN() should be used to check for NaN value #3921

Closed
ilia-kebets-sonarsource opened this issue May 15, 2023 · 1 comment · Fixed by #4040
Closed

Create rule S6679 (no-self-compare): Number.isNaN() should be used to check for NaN value #3921

ilia-kebets-sonarsource opened this issue May 15, 2023 · 1 comment · Fixed by #4040
Assignees
@alex-sonar
Labels
mmf-3201 type: new rule Creating a new rule not existing before
Milestone
10.4

Comments

@ilia-kebets-sonarsource
Copy link
Contributor

ESLint rule definition https://eslint.org/docs/latest/rules/no-self-compare

Related to S2159
@ilia-kebets-sonarsource ilia-kebets-sonarsource added type: new rule Creating a new rule not existing before mmf-3201 labels May 15, 2023
@ilia-kebets-sonarsource ilia-kebets-sonarsource added this to the 10.3.0 milestone May 15, 2023
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource removed this from the 10.3.0 milestone May 26, 2023
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource removed their assignment May 26, 2023
@alex-sonar alex-sonar added this to the 10.4 milestone Jun 13, 2023
@alex-sonar
Copy link
Contributor

Overlaps with S1764

@alex-sonar alex-sonar self-assigned this Jul 25, 2023
@alex-sonar alex-sonar changed the title Create rule for ESLint's no-self-compare Create rule S6679 (no-self-compare): Number.isNaN() should be used to check for NaN value Jul 26, 2023
This was referenced Jul 26, 2023
Merged
Merged
alex-sonar pushed a commit to SonarSource/rspec that referenced this issue Jul 27, 2023
@github-actions
Create rule S6679: Number.isNaN() should be used to check for NaN…
8d4a040 
… value (#2603)

SonarSource/SonarJS#3921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-sonar alex-sonar

Labels
mmf-3201 type: new rule Creating a new rule not existing before
Projects
None yet
Milestone
10.4
4 participants
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource @victor-diez-sonarsource @alex-sonar