Skip to content

Conversation

michal-gubricky
Copy link
Contributor

What this PR does / why we need it:
This PR adds version subcommand into the csctl-openstack and refactors code

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@michal-gubricky michal-gubricky marked this pull request as ready for review July 12, 2024 13:26
@michal-gubricky michal-gubricky force-pushed the feat/add-version-subcommand branch from 7e93d62 to 2c1df50 Compare July 12, 2024 13:44
@michal-gubricky michal-gubricky added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Jul 12, 2024
@michal-gubricky
Copy link
Contributor Author

Unfortunately, I didn't have enough time to test this PR thoroughly. I only tested the get method and the version subcommand, which works correctly.

@michal-gubricky michal-gubricky force-pushed the feat/add-version-subcommand branch 2 times, most recently from 6cc28a2 to 5f9fe06 Compare July 15, 2024 11:41
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
@michal-gubricky michal-gubricky force-pushed the feat/add-version-subcommand branch from 5f9fe06 to 14aae40 Compare August 6, 2024 07:47
@chess-knight chess-knight merged commit 8898cb7 into main Aug 6, 2024
@chess-knight chess-knight deleted the feat/add-version-subcommand branch August 6, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command to print version
2 participants