Skip to content

Conversation

michal-gubricky
Copy link
Contributor

@michal-gubricky michal-gubricky commented Mar 20, 2024

What this PR does / why we need it:
Adds csctl openstack plugin logic.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes SovereignCloudStack/issues#541

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@michal-gubricky michal-gubricky self-assigned this Mar 20, 2024
@michal-gubricky michal-gubricky force-pushed the feat/add-openstack-plugin-logic branch from 2e7398e to b2d906d Compare March 22, 2024 14:33
@michal-gubricky michal-gubricky marked this pull request as ready for review March 25, 2024 07:47
@matofeder matofeder requested a review from chess-knight March 27, 2024 09:11
@michal-gubricky michal-gubricky mentioned this pull request Mar 28, 2024
@michal-gubricky michal-gubricky force-pushed the feat/add-openstack-plugin-logic branch 2 times, most recently from d6bc2bc to 4bdb561 Compare April 8, 2024 14:29
@michal-gubricky michal-gubricky force-pushed the feat/add-openstack-plugin-logic branch 3 times, most recently from 75b5e40 to 67f93d0 Compare April 10, 2024 07:48
Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jschoone jschoone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built and image and uploaded it to an S3 bucket.
Good work, thanks!

michal-gubricky and others added 10 commits April 19, 2024 09:22
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
…struct

Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
@michal-gubricky michal-gubricky force-pushed the feat/add-openstack-plugin-logic branch from 67f93d0 to 92333a2 Compare April 19, 2024 07:47
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Related to #11

Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
@michal-gubricky michal-gubricky force-pushed the feat/add-openstack-plugin-logic branch from 1537161 to 8640170 Compare April 23, 2024 06:02
michal-gubricky and others added 2 commits April 24, 2024 10:06
Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
@michal-gubricky michal-gubricky force-pushed the feat/add-openstack-plugin-logic branch from 6ed3a3c to 0c11eb1 Compare May 6, 2024 14:26
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
@michal-gubricky michal-gubricky force-pushed the feat/add-openstack-plugin-logic branch from fb861de to 87702fa Compare May 6, 2024 14:47
@michal-gubricky michal-gubricky merged commit e8dc966 into main May 7, 2024
@michal-gubricky michal-gubricky deleted the feat/add-openstack-plugin-logic branch May 7, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create csctl provider plugin for openstack
4 participants