Skip to content

Conversation

lochhh
Copy link
Contributor

@lochhh lochhh commented Aug 20, 2025

Closes #4110

This PR also pins the minimum cuda-python version to 11.8.6

Note

The new module layouts were applied in 11.8.4, but I was getting:

Could not find a version that satisfies the requirement cuda-python==11.8.4; platform_system != "Darwin" and extra == "full" (from spikeinterface[full]) (from versions: 11.8.6, 11.8.7, 12.8.0, 12.9.0, 12.9.1, 12.9.2, 13.0.0, 13.0.1)

@lochhh lochhh marked this pull request as ready for review August 20, 2025 12:51
Copy link
Member

@chrishalcrow chrishalcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - works for me!

@samuelgarcia
Copy link
Member

Hi @lochhh.
Thank you for this.
OK for me too do we need to pin a minimum cide version so ?

@h-mayorquin
Copy link
Collaborator

+1 for minimum pin.

@lochhh
Copy link
Contributor Author

lochhh commented Aug 21, 2025

Thanks all for the speedy review. Great point regarding pinning - I've pinned it to >=11.8.6 and added some notes above.

@zm711 zm711 added benchmarks Related to benchmarks module dependencies Issue/PR that is related to dependencies packaging Related to packaging/style deprecations Related to code deprecation and removed benchmarks Related to benchmarks module labels Aug 21, 2025
@alejoe91 alejoe91 merged commit 854ad12 into SpikeInterface:main Sep 1, 2025
15 checks passed
@lochhh lochhh deleted the cuda-import branch September 2, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issue/PR that is related to dependencies deprecations Related to code deprecation packaging Related to packaging/style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated cuda.cuda module import
6 participants