fix typo (#1474) #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadmuazam
pushed a commit
that referenced
this pull request
May 13, 2024
* [WIP] add ionoscloud support * [WIP] add ionoscloud support * fix: fix set dcId for servers and lan * vendor update * docs: added documentations for ionoscloud * feat: add nic and volume * fix: remove unnecessary prints from server.go file (#3) * feat: implement IP Block (#4) * feat: implement backup unit (#2) * feat: Implement K8s cluster (#5) * feat: implement Kubernetes Nodepool (#6) * fix: resolve import inconsistency (GoogleCloudPlatform#7) * fix: fix IONOS_TOKEN authentication (GoogleCloudPlatform#9) * feat: add extra checks for resources (GoogleCloudPlatform#10) * feat: implement target group (GoogleCloudPlatform#8) * fix: remove unnecessary check and test statement (GoogleCloudPlatform#13) * feat: implement network load balancer (GoogleCloudPlatform#14) * feat: implement NAT gateway (GoogleCloudPlatform#12) * feat: implement group (GoogleCloudPlatform#11) * feat: implement application load balancer (GoogleCloudPlatform#15) * feat: fix server corner cases. k8s server should not be written to plan. * Implement firewall resource, fix name typo, change nic logic (GoogleCloudPlatform#16) * implement NLB forwarding rule (GoogleCloudPlatform#17) * Implement load balancer (GoogleCloudPlatform#18) * feat: implement NAT gateway rule (GoogleCloudPlatform#19) * fix: rename generator string (GoogleCloudPlatform#20) * feat: rename variable, add condition if server valid, firewall link to other resources * feat: improve doc * feat: use variables for hardcoded strings * feat: link remaining resources * doc: update README.md * fix: add links to supported resources * fix: add links to supported resources * fix: remove 'Printf' calls from utils.go (GoogleCloudPlatform#23) * refactor: fix linter errors (GoogleCloudPlatform#24) --------- Co-authored-by: iblindu <iuliaioana.blindu@gmail.com> Co-authored-by: cristi <cristian.mihai.guran@ionos.com> Co-authored-by: cguran-ionos <cristian-mihai.guran@ionos.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.