fix: validate tool_names after whitespace filtering #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #125
I found a bug
Problem
tool_namesvalidation had a bug: whitespace-only strings were filtered out but the resulting empty array was never validated.Example:
Why This Went Unnoticed
Old tests used
spyOn(globalThis, 'fetch')which didn't show actual requests. The bug became visible when migrating to MSW in #129.Fix
Added
.refine()after.transform()to validate the filtered array:Test Results
✅ All 10 feedback tests pass
Context
Discovered while working on MSW migration (#129).