Skip to content

v11.26.0

Choose a tag to compare

@github-actions github-actions released this 10 Nov 13:34
cc765e8
  • Xrpl.Wallet.XrplSigningKey : IDisposable signs with a private key held in a byte[] and clears it on Dispose; signing afterwards throws ObjectDisposedException. It is built from the 33-byte key (new XrplSigningKey(ReadOnlySpan<byte>, masterAddress)) or from seed entropy (XrplSigningKey.FromEntropy), and its Sign overloads (dictionary and typed, with and without SignatureRole) produce the same blob and hash as XrplWallet.Sign, through the same routing. XrplWallet sends every signature through one internal SignBytes, which this type supplies with the byte key. Issue #347

  • Xrpl.Keypairs.XrplKeypairs takes keys as bytes: Sign(ReadOnlySpan<byte> message, ReadOnlySpan<byte> privateKey), DerivePublicKey(ReadOnlySpan<byte> privateKey) and DeriveKeyBytes(ReadOnlySpan<byte> entropy, string algorithm), which derives the keys of XrplWallet.FromEntropy without encoding a seed string. The key is the 33-byte XRPL form, 0xED or 0x00 followed by 32 bytes, and a secp256k1 scalar of zero or not below the curve order is refused, so a cleared buffer never signs; the buffers these methods allocate for key material, the Ed25519 expanded key included, are cleared before they return. The secp256k1 scalar still passes through a BouncyCastle BigInteger, which cannot be cleared

  • Tests: TestUSigningKey

  • Xrpl, Xrpl.AddressCodec, Xrpl.BinaryCodec and Xrpl.Keypairs are 11.26.0.0

  • LedgerRules.FixCleanup3_5_0 (default true) carries rippled 3.5.0's fixCleanup3_5_0; LedgerRules.FromNodeAsync reads it, and records whether the node lists the amendment at all, since rippled 3.5.0 treats it as enabled outside a transaction and 3.4.x does not have it. Under it:

    • PaymentFlow, direct MPT payment (before MPTokensV2): the cost is mulRatio(amount, rate) rounded up, a cost that overflows exceeds any SendMax, and a partial payment delivers mulRatio(SendMax, 1/rate) rounded down, tecPATH_PARTIAL when that is zero; an MPT sent between holders charges addTransferFee. rippled #8302. Tests: TestUMptDex.Pay_Direct_Fix350_RoundsTheCostUp, Pay_DirectPartial_Fix350_NeverChargesPastSendMax, Pay_DirectPartial_Fix350_NothingDeliveredIsPartial
    • XrplQuality.CeilOut / CeilOutStrict: an XRP input beyond 10^17 drops is clamped to the offer's input instead of throwing; an overflow past 64 bits still throws. The out-of-range case throws the internal AmountRangeException, an OverflowException. rippled #8480
    • XrplAmountMath.DivRound / DivRoundStrict: an MPT operand of any role goes through Number, with MPTokensV2 or without; MulRound is unchanged
    • LoanOrigination.Compute: a LoanSet value field outside the asset's range (above 10^17 drops of XRP, maxMPTokenAmount of an MPT, an IOU exponent above 80) is tecPRECISION_LOSS; without the amendment it is tefEXCEPTION, as the node fails on it. rippled #8527
    • VaultShares: WithdrawAssets and RedeemShares overloads take the transferRate the withdrawal pays (0 or 1,000,000,000 for none), which VaultShares.WithdrawalTransferRate(asset, account, destination, assetTransferRate, rules) works out (the asset's rate between two accounts that are neither the withdrawer nor the issuer, otherwise none). A withdrawal by amount burns shares for the amount plus the fee; one by shares delivers the payout less the fee, tecPRECISION_LOSS when that leaves nothing. VaultQuote.AssetsDelivered is what the destination receives. rippled #8267
    • Tests: TestUFixCleanup3_5_0. TestUAmountVectors replays its rippled 3.4.1 vectors with the amendment off
  • XrplAmount throws AmountRangeException (internal, derived from OverflowException) for an XRP or MPT value out of range, where it threw OverflowException itself

  • Xrpl, Xrpl.AddressCodec, Xrpl.BinaryCodec and Xrpl.Keypairs carry a readme (PackageReadmeFile): Xrpl packs the repository README.md, and each base package has its own README.md in Base/. The CONTRIBUTING.md and LICENSE links of the repository README.md are absolute, so they also work on nuget.org.