Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astrocal ephemeris ignores Ceres, Vesta, ... #2000

Closed
1 task
axd1967 opened this issue Oct 27, 2021 · 11 comments · Fixed by #2027
Closed
1 task

Astrocal ephemeris ignores Ceres, Vesta, ... #2000

axd1967 opened this issue Oct 27, 2021 · 11 comments · Fixed by #2027

Comments

@axd1967
Copy link
Contributor

axd1967 commented Oct 27, 2021

Tested with 0.21.2 fc4c6bb

When computing the ephemeris of Ceres from 2021-10-28 to 2021-11-28, the dialog (F10) remains empty for Ceres. this appears in b87b419.

image

I tried to update Ceres via asteroid import data; not sure the import succeeded: was Ceres finally updated?

Assuming this is an issue of outdated orbital data (but ... Ceres?) #1880 (comment) might have helped here.

  • selecting an object should show the validity date range of that object as a new info line (for_wishlist)
@alex-w alex-w added this to To do in Astronomical calculations (AstroCalc) via automation Oct 29, 2021
@alex-w alex-w added this to To do in Solar System via automation Oct 29, 2021
@alex-w
Copy link
Member

alex-w commented Oct 29, 2021

This is not a bug, this is a feature. If you want to see Ceres and other asteroids in wide range of dates then define orbit_good parameter in ssystem_minor.ini file for these asteroids (e.g. orbit_good = 5000).

@alex-w alex-w added this to the 0.21.3 milestone Oct 29, 2021
@alex-w alex-w closed this as completed in 23245d2 Oct 29, 2021
Solar System automation moved this from To do to Done Oct 29, 2021
Astronomical calculations (AstroCalc) automation moved this from To do to Done Oct 29, 2021
@axd1967
Copy link
Contributor Author

axd1967 commented Oct 29, 2021

This is not a bug, this is a feature. If you want to see Ceres and other asteroids in wide range of dates then define orbit_good parameter in ssystem_minor.ini file for these asteroids (e.g. orbit_good = 5000).

Be aware here we are talking of predictions for the next month. So this makes the case stronger to provide some form of warning to the user (entry in logfile, a flash message, or a new line of Information, similar to #1096).

@alex-w
Copy link
Member

alex-w commented Oct 29, 2021

Be aware here we are talking of predictions for the next month.

And?

So this makes the case stronger to provide some form of warning to the user (entry in logfile, a flash message, or a new line of Information, similar to #1096).

How exactly one, two or ten warning will help user, who do not want to define the parameter? For example log file contains the info about result of updating the orbital elements - how did it help you if you "does not see" records in the log?

@gzotti
Copy link
Member

gzotti commented Oct 29, 2021

Update the elements. This has been the accepted solution since before the first person has complained in software of the 1990s. We estimate orbit_good to avoid printing bad data. You may always propose your working better solution as PR.

@axd1967
Copy link
Contributor Author

axd1967 commented Nov 10, 2021

As far as I can see, all 0.21.2 users are affected, am I right?

Updating the elements will not solve this issue. I tried MPCAT 1..9999 (see 23245d2#r59605156) to no avail.

@gzotti
Copy link
Member

gzotti commented Nov 10, 2021

Now I see what's really happening. For asteroids with elements and epoch we compute last perihel date and compute orbit_good from that. For asteroids with a few years orbit this may lead to this behaviour that too much time has passed since that previous perihel. So. after all, we have to add epoch to the elements (was scheduled for "later"), and we could estimate a default orbit_good to be equal the orbit period (with all positional error dangers this implies), centered around epoch. For non-elliptic orbiters (comets), we still should keep that at ~1000 days.

For a temporary override of the fuse, set orbit_good to whichever value, about orbital period.

@gzotti gzotti reopened this Nov 10, 2021
Solar System automation moved this from Done to In progress Nov 10, 2021
Astronomical calculations (AstroCalc) automation moved this from Done to In progress Nov 10, 2021
@gzotti gzotti self-assigned this Nov 10, 2021
@axd1967
Copy link
Contributor Author

axd1967 commented Nov 10, 2021

I also tried to copy the elements from JPL as well as MPC but get strange results in both cases.

[1ceres]
absolute_magnitude             = 3.54
albedo                         = 0.15
coord_func                     = comet_orbit
minor_planet_number            = 1
name                           = Ceres
orbit_ArgOfPericenter          = 73.7377
orbit_AscendingNode            = 80.26762
orbit_Eccentricity             = 0.0783941
orbit_Epoch                    = 2459400.5
orbit_Inclination              = 10.5882
orbit_MeanAnomaly              = 248.40797
orbit_MeanMotion               = 0.21429254
orbit_SemiMajorAxis            = 2.7656551
orbit_visualization_period     = 1679.9465160344398
radius                         = 337
slope_parameter                = 0.15
type                           = asteroid
orbit_good                     = 5000

[1ceresM]
absolute_magnitude             = 3.54
albedo                         = 0.15
coord_func                     = comet_orbit
minor_planet_number            = 1999999
name                           = Ceres(MPC)
orbit_ArgOfPericenter          = 73.63703
orbit_AscendingNode            = 80.26858
orbit_Eccentricity             = 0.0785011
orbit_Epoch                    = 2464400.5
orbit_Inclination              = 10.58769
orbit_MeanAnomaly              = 291.37563
orbit_MeanMotion               = 0.21424745
orbit_SemiMajorAxis            = 2.7660431
orbit_visualization_period     = 1679.9465160344398
radius                         = 337
slope_parameter                = 0.15
type                           = asteroid
orbit_good                     = 5000


[1ceresJPL]
absolute_magnitude             = 3.54
albedo                         = 0.15
coord_func                     = comet_orbit
minor_planet_number            = 1999998
name                           = Ceres(JPL)
orbit_ArgOfPericenter          = 73.73826765873966
orbit_AscendingNode            = 80.26763801181816
orbit_Eccentricity             = 0.07839201989374402
orbit_Epoch                    = 2459921.250133264627
orbit_Inclination              = 10.58819557618916
orbit_MeanAnomaly              = 247.5499723080229
orbit_MeanMotion               = 0.2142925185981219
orbit_SemiMajorAxis            = 2.982460555138589
orbit_visualization_period     = 1679.946655884585
radius                         = 337
slope_parameter                = 0.15
type                           = asteroid
orbit_good                     = 5000


I think this justifies releasing a hotfix.

@axd1967
Copy link
Contributor Author

axd1967 commented Nov 10, 2021

@gzotti consider starting a hotfix branch from 0.21.2 (eg release/0.21.2/hotfixes) and later merge to master.

@gzotti
Copy link
Member

gzotti commented Nov 10, 2021

Six weeks to next release, and too little time to develop. Creating a hotfix release a week before next release for this small issue won't pay off.

@gzotti gzotti mentioned this issue Nov 11, 2021
12 tasks
Solar System automation moved this from In progress to Done Nov 12, 2021
Astronomical calculations (AstroCalc) automation moved this from In progress to Done Nov 12, 2021
@alex-w alex-w added the state: fixed The bug has been fixed label Nov 14, 2021
@github-actions
Copy link

Hello @axd1967! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: fixed The bug has been fixed label Dec 25, 2021
@github-actions
Copy link

Hello @axd1967! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants