Fix typo

[rayw000]

Fix typo

[alex-w]

Thanks!

[gzotti]

Oops, thanks!

[rayw000]

Thanks!

BTW, seems WITH_QTWEBENGINE didn't work well for me.

I built with brew installed Qt 5.15.2. Seemed that it's shipped along with QtWebEngine. Line 30 evaluated true in my case.

stellarium/plugins/OnlineQueries/src/CMakeLists.txt

Lines 28 to 37 in dd006bc

	FIND_PACKAGE(Qt5WebEngine QUIET)
	FIND_PACKAGE(Qt5WebEngineWidgets QUIET)
	IF(Qt5WebEngine_FOUND AND Qt5WebEngineWidgets_FOUND)
	ADD_DEFINITIONS(-DWITH_QTWEBENGINE)
	SET(QTWEBENGINE_LIBS Qt5::WebEngine Qt5::WebEngineWidgets)
	ELSE(Qt5WebEngine_FOUND AND Qt5WebEngineWidgets_FOUND)
	MESSAGE(WARNING "Qt5WebEngine and/or Qt5WebEngineWidgets not found. \
	If these packages exist for your platform, install and rerun. \
	Else the program will call the system web browser where required.")
	ENDIF(Qt5WebEngine_FOUND AND Qt5WebEngineWidgets_FOUND)

I've read #2006 and #2049. -DWITH_QTWEBENGINE=0 didn't work for me, neither -DWITH_QTWEBENGINE=off. There was a cmake warning saying

CMake Warning:
  Manually-specified variables were not used by the project:

    WITH_QTWEBENGINE

and issue #1982 was still.

Only fully disabling online queries plugin with option -DUSE_PLUGIN_ONLINEQUERIES=false worked for me.

I built on Monterey 12.0.1 with Apple M1 Max chip. I'm trying to find out why.

[alex-w]

Issue #1982 happened with Qt 5.15 only and probably this is bug in Qt/macOS.

[rayw000]

Oh, I thought we could walk around it by -DWITH_QTWEBENGINE=off after reading your reply #2006 (comment).

[gzotti]

I have made another round of corrections, seeing that my Odroid C1 SBC with Ubuntu 18LTS has QWebEngine, shows a webengine panel, but fails to work, emitting error messages to stderr.

Now

• We detect QWebEngine availablilty at compile time, emit a warning if not found, but compile anyhow.
• On systems where QWebEngine is present but buggy, compile with it, but manually disable the built-in QWebEngineView and open the URL in the system webbrowser.

Now finally the external system webbrowser also works on that (minimal, 5fps) platform.
The User Guide (sources) includes instructions for users.

[gzotti]

The point seems to be that at least on ARM platform, QWebEngine does not work properly before Qt6.2, and also not on X11 platforms with some GLX1.3 problem.

[github-actions]

Hello @rayw000! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot