Added option to let user configure password via email #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked this PR and it's works. |
ilyautkin
approved these changes
Jun 7, 2021
opengeek
pushed a commit
to modxcms/revolution
that referenced
this pull request
Aug 30, 2024
### What does it do? This is a re-up of #15461 originally by @sdrenth back in 2021, which has gone stale waiting for some minor changes. I've rebased it, tweaked it, tested it, so we can include it in 3.1. This adds a new option for setting the password when creating/updating a user: send the user a link to set their password. That's more secure and builds upon improvements to the password reset flow that was done in 3.0. ### Why is it needed? Showing the password on screen or manually setting a password is kinda outdated and insecure. ### How to test Create and/or edit a user, and choose "Let the user choose their own password via email" for the password method. Look for the email (make sure you have email delivery set up beforehand) and attempt to set the new password. ### Related issue(s)/PR(s) This PR replaces the stale PR #15461 Sterc#22 #13973 Sterc#31 Co-authored-by: sander <sander@sterc.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This adds the possibility to let a user specify their own MODX password, using the same flow as the current manager Forgot password flow by sending a hashed link in the email which allows users to setup their new password. I also changed the "emailsubject" option to "subject" to make it uniform with the official MODX 3 branch.
I also removed the password notification methods because they are no longer needed.
New password options:
Set up password mail:
Why is it needed?
There used to be an option to send an email to the MODX user which contains their MODX account password. This has been removed (for security purposes). This basically readds that functionality but in a saver way.
Related issue(s)/PR(s)
#22
modxcms#13973