-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Galactic release #167
Comments
I'm not seeing anything here that makes me suspect of pluginlib http://wiki.ros.org/noetic/Migration. The melodic devel branch looks identical to the noetic devel branch (https://github.com/ros/pluginlib). Does the rospack get plugins call detect it properly? I'd be more than happy to release it once we work through these issues. |
Yes:
What's strange is that when preloading jemalloc with
|
Running gdb to know where the crash happens would be useful. Might even be on movebase side if it crashes after the “complete” message |
I assume you speak about the second issue, it looks like it is from the
However I don't know if this second issue is linked or not to the first one and its workaround (preloading jemalloc) |
If started with stvl param |
What was the crash from it you had GDB up? What was the traceback? Maybe your footprint parameter wasn't read in correctly so one of the double pointers was null? |
It would be good to know where the error is in this function https://github.com/SteveMacenski/spatio_temporal_voxel_layer/blob/melodic-devel/src/spatio_temporal_voxel_layer.cpp#L477-L496 (since some of them are costmap calls, then maybe actually an error in costmap 2d. In fact, all those functions inside of this are provided by costmap 2d) |
I am not fully understanding why, but because the updateFootprint function has no return value, the for loop was running way above spatio_temporal_voxel_layer/src/spatio_temporal_voxel_layer.cpp Lines 477 to 496 in 67a6e4d
Fixed in #168 |
Weird. Is noetic otherwise working? |
Yes, provided that this line is added to .bashrc |
is that a pluginlib issue? Is there a ticket filed for that so someone knows its an issue? |
I found nothing else. How could you tell if it is pluginlib or not related ? |
You said you're having issues loading plugins, unless you're saying that this is a unique issue to STVL. I have to assume your issues are the result of pluginlib issues. |
Sorry if I was unclear, the only thing I know for sure is that when I start move_base with STVL, i get this crash:
whereas without it, I don't have this issue (and other plugins like |
What's the computer you're trying to run it on? Can you verify on another hardware machine it works or doesn't? I'm not sure what to do about that myself. |
I'd also be curious if you ran into issues loading NPVL or if its just STVL https://github.com/SteveMacenski/nonpersistent_voxel_layer |
Same result on my 3 years old asus laptop, a NUC8 and a NUC10. |
I ll try |
Ok, so probably not platform specific. It may (?) be released, but rosdistro doesn't have a Focal entry for openVDB https://github.com/ros/rosdistro/blob/master/rosdep/base.yaml#L3005 |
No issue with NPVL |
Mhm, that is interesting then. I don't have a 20.04 machine yet to try to debug this. Hopefully in the next few weeks but for the moment, there's not much I can do. |
|
No rush for a release, I ll test it on a real robot hopefully in the next days and report back if I find any other issues |
Ok, that issue is really odd though, I'd suggest filing a ticket for it on pluginlib repo since something broke during the last distribution update. As far as Ican tell, nothing should need to be changed http://wiki.ros.org/noetic/Migration |
It doesn't seem like this issue is coming from pluginlib. The spatio_temporal_voxel_layer/package.xml Lines 44 to 45 in e077795
https://packages.debian.org/sid/libopenvdb6.2 @doisyg pointed to an issue suggesting jemalloc is not being built with Commenting there, or opening another bug on launchpad might be good next steps: https://launchpad.net/ubuntu/+source/jemalloc/+bugs |
Would this not be something to file with the openvdb maintainers on GitHub since they just need to change some flags and rebuild debians? I'm not very encouraged by the likelihood of this being fixed given that ticket hasn't had motion since Feb. |
I filed the ticket above on OpenVDB to make them aware. Is there any other action here I can take? |
Thanks for filling the ticket, I reported there that the issue disappears when installing openvdb7.0 instead of openvdb6.2 before recompiling. The problem now being that openvdb7.0 is not officially available on focal |
Hi Any noetic release of STVL (install via apt) ? Best, |
Looks like it is finally going to get resolved for Ubuntu: https://bugs.launchpad.net/ubuntu/+source/openvdb/+bug/1882998 |
Freckin' awesome! I can release binaries after this is out and about. Let me know! I thought I filed a ticket on that too and was roundly denied (though honestly I haven't used launchpad before and I'm sure I didn't follow convention) |
Funny enough, I was just thinking about updating Nav2 to use OpenVDB as the default voxel grid implementation so that we can support arbitrary heighted robots, not being limited by 16 voxel heights. I'm still not entirely sure on the memory footprint, but would be worth a try. In the early days of STVL I had actually used OpenVDB's raytracing and replicated behavior like the Voxel Layer -- though wasn't any faster since this doesn't make use of signed distance fields (and still had the discrete raycasting "ghost" voxels issue that was the root of what I was trying to solve). If we can get binaries out and working + 22.04 has the fix too, then I'd be alot more confident in starting in that direction. I see no reason why Nav2 should have its own voxel_grid implementation - there's got to be a bunch of standard library options for that these days. OpenVDB is the one I know of well so I'd start with that, unless there's other reasonable alternatives. |
The focal "proposed" update package fixes the issue! I reported it and it should be pushed -updated next (I will report here when it is).
Great news! OpenVDB still seems to be the best choice, though @facontidavide is working on something even more efficient : https://github.com/facontidavide/Bonxai |
So you did just If so, I can release it ASAP this week. Reopening, since we could resolve. Then I'll announce on discourse when released. |
No, I had to enabled "proposed" updates in Ubuntu: https://wiki.ubuntu.com/Testing/EnableProposed
You will be able, once the proposed pacakage is pushed to regular updates (I guess in ~ 7 days), I ll let you know here when that's the case |
Got it, let me know! |
libopenvdb-dev 6.2.1-8ubuntu1.1 released ! (previous was 6.2.1-8ubuntu1) |
I assume that's verification that this resolves the issue with the new binaries? Now, @nickovaras / @nickvaras can you test using binaries? 😄 I'll be happy to release across the board once I have just another verification. Steps
|
The galactic release is currently held up for adding OpenVDB keys for RHEL ros/rosdistro#31488 |
Galactic: ros/rosdistro#31490 |
Noetic version seems happy with new openvdb binaries. |
Thanks! |
Anyone can confirm that the galactic binaries work? In my application, building stvl on galactic branch works fine, as soon as I switch to binaries, it stops working. I know that's not much info, I haven't had time yet to simplify/reduce the setup to reproducible steps to give you more info but before I do so, it would be useful to know if it already works for someone else; then it would most likely be a local issue. Maybe that's already useful: I get this log in a constant loop
STVL does report as being activated
The /voxel_grid topic is not published. If this is not the right place to ask this, I can create a separate issue |
Do you see any other errors, especially around It doesn't seem to me that those are related error messages unless you're not showing other error messages where there are things that crashed or weren't fully loaded. |
Builds fine under Noetic from branch melodic-devel but at execution I get:
Did somebody tried already and have a different result ?
The text was updated successfully, but these errors were encountered: