Support widths and height css properties #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy1xx8
approved these changes
Sep 4, 2021
ryan-berger
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we say the in README that we support the
heightandwidthcss properties, we actually don't. This PR contains a basic implementation where we at least apply any exactly-defined width or height on the html element (container). You can now, for example, set the size of images.It only works on block style elements. This (to the best of my knowledge) is the same in browsers.
However, it does not implement support for percentage-based height/width as it is not as easy as setting this percentage on a Container. We could use a LayoutBuilder and then use the maxWidth * percentage, but this would not work if nested I think. Remains to be seen. Also, more work may be needed for elements such as tables. See #811 for a discussion specifically on tables.