Skip to content

Support widths and height css properties #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Support widths and height css properties #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e6afa3
Corrected changelog for real release
erickok Jul 28, 2021
17efea1
Merge remote-tracking branch 'upstream/master'
erickok Aug 31, 2021
b6c045e
Support exactly-specified widths and height from css
erickok Sep 1, 2021
b878184
Revert example changes from "Support exactly-specified widths and hei…
erickok Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
## [2.1.1] - July 27, 2021:
## [2.1.1] - July 28, 2021:
* Stable release with all 2.1.1-preview.X changes

## [2.1.1-preview.0] - July 27, 2021:
* Improves hr tag support
* Fixes a leading whitespace issue
* Fixes some crashes with CSS parsing
Expand Down
6 changes: 6 additions & 0 deletions lib/src/css_parser.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,9 @@ Style declarationsToStyle(Map<String, List<css.Expression>> declarations) {
case 'font-weight':
style.fontWeight = ExpressionMapping.expressionToFontWeight(value.first);
break;
case 'height':
style.height = ExpressionMapping.expressionToPaddingLength(value.first) ?? style.height;
break;
case 'list-style-type':
if (value.first is css.LiteralTerm) {
style.listStyleType = ExpressionMapping.expressionToListStyleType(value.first as css.LiteralTerm) ?? style.listStyleType;
Expand Down Expand Up @@ -298,6 +301,9 @@ Style declarationsToStyle(Map<String, List<css.Expression>> declarations) {
case 'text-shadow':
style.textShadow = ExpressionMapping.expressionToTextShadow(value);
break;
case 'width':
style.width = ExpressionMapping.expressionToPaddingLength(value.first) ?? style.width;
break;
}
}
});
Expand Down