chore(setup): don't use templating for Terraform imports #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
| jq -r '.resource[] | to_entries[] | "\(.key) \(.value.name)"' sources.tf.json | while read -r resource_name source_name; do |
There was a problem hiding this comment.
would it be better to have a common function for this since I see this is being repeated for all the files?
There was a problem hiding this comment.
What is being repeated? We call jq exactly once, and then loop over the results.
There was a problem hiding this comment.
I think we used to have more the same code in cleanup.sh
sumo-drosiek
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import using the json file as a reference instead of templating in the bash script. This is the final part of #3761.
Also fixed a bug in cleanup, which was using the wrong Secret name.
Finally, set an attribute on the generated Secret to align more with Kubernetes defaults.