Skip to content

Conversation

@viktorasl
Copy link
Contributor

@viktorasl viktorasl commented Jan 9, 2020

  • I've started my branch from the develop branch (gitflow)
    • And I've selected develop as the "base" branch for this Pull Request I'm about to create
  • I've added an entry in the CHANGELOG.md file to explain my changes and credit myself
    (or added #trivial to the PR title if I think it doesn't warrant a mention in the CHANGELOG)
    • Add the entry in the appropriate section (Bug Fix / New Feature / Breaking Change / Internal Change)
    • Add a period and 2 spaces at the end of your short entry description
    • Add links to your GitHub profile to credit yourself and to the related PR and issue after your description

During migration my team and myself moved some files which used L10n structure to other frameworks, after moving .strings file there as well we are not be able to use the same L10n.<FileName> structure as there is only a single .strings file there.

As a solution I've introduced a new file template, but the change is simple, so to keep consistency in those kind of situations I'd like to suggest an option to force add file name enums.

  • Documentation updated
  • Not a breaking change, option not being provided defaults to old behaviour
  • Updated tests
  • Not added support for swift3

Cheers! ☮️

@SwiftGen-Eve
Copy link

SwiftGen-Eve commented Jan 9, 2020

Hey 👋 I'm Eve, the friendly bot watching over SwiftGen 🤖

Thanks a lot for your contribution!


Seems like everything is in order 👍 You did a good job here! 🤝

Generated by 🚫 Danger

@djbe djbe mentioned this pull request May 17, 2020
@djbe djbe added this to the 6.3.0 milestone May 17, 2020
@AliSoftware
Copy link
Collaborator

AliSoftware commented May 18, 2020

Before merging this PR we'll need to:

  • Merge Obsolete swift3 templates #691 (obsolete Swift 3 templates)
  • Rebase this PR on top of develop (this should also fix the CI failure currently present in this PR due to a change in our CI config recently merged)
  • Update this PR to remove the special cases that have been introduced for Swift 3 (rightfully at that time, but they won't be necessary once we drop Swift 3 after Obsolete swift3 templates #691)

@djbe djbe modified the milestones: 6.3.0, 6.2.0 May 19, 2020
# Conflicts:
#	Tests/TemplatesTests/StringsTests.swift
@AliSoftware
Copy link
Collaborator

Thanks again @viktorasl for the PR! Merging now.

Our next step is to create another PR to apply that same change to other templates (an not just for strings template) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants