Skip to content

Replace TODO comments with IMPROVEMENT comments so they don't show up in the VS task list #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Replace TODO comments with IMPROVEMENT comments so they don't show up in the VS task list #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions TraditionalBridge/RoutineDispatcher.dbl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ namespace Harmony.TraditionalBridge
begin
elementValue = passedValue[i]

;;TODO might be able to skip the lookup if the typename hasnt changed
;;IMPROVEMENT? might be able to skip the lookup if the typename hasnt changed
if(!isBriefEncoding) then
begin
if(IS_OBJ(elementValue)) then
Expand Down Expand Up @@ -376,7 +376,7 @@ namespace Harmony.TraditionalBridge

endmethod

;;TODO: This needs to take an expected type parameter of some kind so we can do basic conversions int -> decimal vs int -> int
;;IMPROVEMENT? This needs to take an expected type parameter of some kind so we can do basic conversions int -> decimal vs int -> int

public method UnwrapObjectCollection, @ArrayList
collection, JSON_ELEMENT
Expand Down Expand Up @@ -1203,7 +1203,7 @@ namespace Harmony.TraditionalBridge
end
else if(name == "rpc.chain") then
begin
;;TODO: flush everything out and stop chain to ourselves
;;IMPROVEMENT? flush everything out and stop chain to ourselves
serializer.ReportError("rpc.chain not yet implemented", -32603, requestId)
end
else
Expand Down Expand Up @@ -1235,7 +1235,7 @@ namespace Harmony.TraditionalBridge
catch(ex, @Exception)
begin
serializer.OutputScopeAbort()
;;TODO maybe this should be a specific type, we might need to do additional processing for certain exception types here
;;IMPROVEMENT? maybe this should be a specific type, we might need to do additional processing for certain exception types here
serializer.ReportError(ex.ToString(), -32000, requestId)
end
endtry
Expand Down
44 changes: 22 additions & 22 deletions TraditionalBridge/Serializer.dbl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,10 +290,10 @@ namespace Json
private buffer, @string
private alphaBuf, a65535
private alphaPosition, i4
;;TODO: make a real stack out of a dynamic array or something like that
;;IMPROVEMENT? make a real stack out of a dynamic array or something like that
protected serializerStack, @ArrayList
;;TODO: buffer writes into an a65535 instead of calling write directly
;;TODO: validation
;;IMPROVEMENT? buffer writes into an a65535 instead of calling write directly
;;IMPROVEMENT? validation
private expectingName, boolean, true
private first, boolean, true

Expand Down Expand Up @@ -439,7 +439,7 @@ namespace Json

.region "Serialization methods"

;TODO: Consider renaming this to ObjectOpen
;IMPROVEMENT? Consider renaming this to ObjectOpen

;;; <summary>
;;; Begins the definition of a new JSON object by adding a { character to the buffer.
Expand Down Expand Up @@ -476,7 +476,7 @@ namespace Json
mreturn SerializerStatus.Ok
endmethod

;TODO: Consider renaming this to ObjectClose
;IMPROVEMENT? Consider renaming this to ObjectClose

;;; <summary>
;;; Ends the definition of the current JSON object by adding a } character to the buffer.
Expand Down Expand Up @@ -665,7 +665,7 @@ namespace Json
input = '"'
first = false

;;TODO this string "value" might need to be encoded, it probably shouldnt have binary data in it
;;IMPROVEMENT? this string "value" might need to be encoded, it probably shouldnt have binary data in it
if(expectingName) then
begin
input += value + '":'
Expand Down Expand Up @@ -879,7 +879,7 @@ namespace Json
else
encodeElement = false

;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand Down Expand Up @@ -914,7 +914,7 @@ namespace Json
required in value, d
optional in type, FieldDataType
proc
;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand All @@ -934,7 +934,7 @@ namespace Json
required in precision, int
required in hasBinaryData, boolean
proc
;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand All @@ -956,7 +956,7 @@ namespace Json
optional in precision, int
optional in hasBinaryData, boolean
proc
;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand All @@ -975,7 +975,7 @@ namespace Json
item, @object
doElement, @DataObjectBase
proc
;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand Down Expand Up @@ -1013,7 +1013,7 @@ namespace Json
record
doElement, @DataObjectBase
proc
;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand All @@ -1038,7 +1038,7 @@ namespace Json
item, @object
doElement, @DataObjectBase
proc
;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand Down Expand Up @@ -1111,7 +1111,7 @@ namespace Json
item, @object
doElement, @DataObjectBase
proc
;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand Down Expand Up @@ -1140,7 +1140,7 @@ namespace Json
record
item, @string
proc
;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand All @@ -1164,7 +1164,7 @@ namespace Json
record
item, int
proc
;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand All @@ -1188,7 +1188,7 @@ namespace Json
record
item, @a
proc
;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand All @@ -1212,7 +1212,7 @@ namespace Json
record
item, @id
proc
;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand Down Expand Up @@ -1242,7 +1242,7 @@ namespace Json
i, int
structureCount, int
proc
;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand Down Expand Up @@ -1298,7 +1298,7 @@ namespace Json

proc
MaybeLog(4, "serializing argument handle data, structureSize was " + %string(structureSize) + " element count was " + %string(elementCount) + " handle length was " + %string(^size(^m(value))))
;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand Down Expand Up @@ -1344,7 +1344,7 @@ namespace Json
proc
MaybeLog(4, "serializing argument handle data, elementSize was " + %string(elementSize) + " element count was " + %string(elementCount) + " handle length was " + %string(^size(^m(value))))

;;TODO inline these operations into a single buffer op
;;IMPROVEMENT? inline these operations into a single buffer op
MapOpen()
Pair("Position", argPos)
String("Value")
Expand Down Expand Up @@ -1554,7 +1554,7 @@ namespace Json
incr ii
if(inputSet[ii])
begin
;;TODO input set
;;IMPROVEMENT? input set
end
end
MaybeLog(5, "ReportResult: array(" + %string(result.Length) + ") messageId" + %string(requestId))
Expand Down