Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tup-87 social media share links #193

Merged
merged 14 commits into from
Oct 4, 2023
Merged

feat: tup-87 social media share links #193

merged 14 commits into from
Oct 4, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 26, 2023 •
edited
Loading

Overview

Support social media share links on Texascale via snippet.

Related

Changes

  • added share links on article templates

Testing

Note
Deployed to staging. See any article, such as /2022/…/forecasting-future-climate/.

  1. Create page.
  2. Set Template to "Article".
  3. Verify social media share links appear.
  4. Verify social media share links function.
  5. Set Template to "Article (Free-Form)".
  6. Add Columns and Text to mirror staging /2022/…/forecasting-future-climate/.
  7. Verify social media share links appear.
  8. Verify social media share links function.

UI

no hover hover Facebook hover LinkedIn hover E-mail
local - no hover local - hover fb local - hover ln local - hover em
Archived
no hover hover Facebook hover LinkedIn
no hover hover fb hover ln
Unconfirmed Design
tup-87 texscale
tup-87.texscale.mov
Proof of Concept
poc texascale socail media

@wesleyboar wesleyboar marked this pull request as draft September 26, 2023 20:39
@wesleyboar wesleyboar mentioned this pull request Sep 26, 2023
Closed
@wesleyboar wesleyboar mentioned this pull request Sep 27, 2023
Merged
@wesleyboar wesleyboar mentioned this pull request Sep 29, 2023
Closed
@wesleyboar wesleyboar mentioned this pull request Oct 3, 2023
Merged
@wesleyboar wesleyboar marked this pull request as ready for review October 4, 2023 03:20
wesleyboar
wesleyboar commented Oct 4, 2023
View reviewed changes
Copy link
Member Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by both designers.

@wesleyboar wesleyboar merged commit dccffe5 into main Oct 4, 2023
@wesleyboar wesleyboar deleted the feat/tup-87-social-media-share-links branch October 4, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar