Skip to content

feat: social media quick share links (inactive)#711

Merged
wesleyboar merged 9 commits intomainfrom
feat/tup-87-social-media-share-links
Sep 18, 2023
Merged

feat: social media quick share links (inactive)#711
wesleyboar merged 9 commits intomainfrom
feat/tup-87-social-media-share-links

Conversation

@wesleyboar
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar commented Sep 8, 2023

Overview

Add quick links to share a News article on social media.

Related

Changes

  • added share links to news article
  • added re-usable template for share links
  • added setting TACC_SOCIAL_SHARE_PLATFORMS to list platforms

Testing

Setup

  1. Install blog.
  2. Create an article.
  3. Open the article your created.

Default Setting

  1. Verify social media share links show as icons.
  2. Live-edit the markup: In each share link URL, replace http://localhost:8000 with https://www.tacc.utexas.edu.
  3. Click each, and verify it lets user share via the appropriate platform.

Custom Setting

  1. Add/Edit taccsite_cms/settings_local.py file.
  2. Add TACC_SOCIAL_SHARE_PLATFORMS = [] (or … = None).
  3. Refresh page.
  4. Verify social media share links are not present.
    There is a comment in the markup where they would appear.

UI

Default Setting

v1 by dev 2023-09-11 at 11.20 AM tested in situ on https://www.tacc.utexas.edu
share links with layout v1 tacc news real with social media icons - top of page

The new UI is icons under sub-heading, to the far-right of categories, above author.

Custom Setting

Screenshot 2023-09-11 at 4 16 22 PM

Notes

  1. design review (private)
  2. design approved (private)
  3. design will revisit (private) during TUP-584

@wesleyboar wesleyboar changed the title feat: social media quick share links — ⚠️ UNTESTED feat: social media quick share links Sep 11, 2023
@wesleyboar wesleyboar marked this pull request as ready for review September 11, 2023 16:23
@wesleyboar wesleyboar added the priority ▲ High priority label Sep 11, 2023
Copy link
Copy Markdown
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disable share links for now. They work, so I also merge them. But they should be in a different location. I will move them after this.1

Footnotes

  1. Moving the share links coincides with larger UI change that is easier to do together. Also, CMD wants the changes done together.

@wesleyboar wesleyboar merged commit 48bfc8d into main Sep 18, 2023
@wesleyboar wesleyboar deleted the feat/tup-87-social-media-share-links branch September 18, 2023 20:21
@wesleyboar wesleyboar changed the title feat: social media quick share links feat: social media quick share links (inactive) Sep 27, 2023
wesleyboar added a commit to TACC/Core-CMS-Resources that referenced this pull request Sep 27, 2023
Based off Django CMS Blog .logos--social styles from TACC/Core-CMS#711.

Added margin to match sidebar content. Added colors (which may change).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority ▲ High priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants