Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12081] Add user-friendliness documentation #12261

Merged
merged 6 commits into from
Mar 27, 2023
Merged

[#12081] Add user-friendliness documentation #12261

merged 6 commits into from
Mar 27, 2023

Conversation

zhaojj2209
Copy link
Contributor

Part of #12081

Documentation added:

  • How-to guide for accessibility testing
  • Best practices for accessibility
  • Best practices for mobile-friendliness

@zhaojj2209 zhaojj2209 added the s.ToReview The PR is waiting for review(s) label Mar 27, 2023
@zhaojj2209 zhaojj2209 changed the title Add user-friendliness documentation [#12081] Add user-friendliness documentation Mar 27, 2023
@TEAMMATES TEAMMATES deleted a comment from github-actions bot Mar 27, 2023
weiquu
weiquu requested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small things, other than that looks good!

docs/best-practices/accessibility.md Outdated Show resolved Hide resolved
docs/best-practices/accessibility.md Outdated Show resolved Hide resolved
docs/axe-testing.md Outdated Show resolved Hide resolved
jasonqiu212
jasonqiu212 reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/best-practices/accessibility.md Outdated Show resolved Hide resolved
weiquu
weiquu approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samuelfangjw samuelfangjw added this to the V8.26.0 milestone Mar 27, 2023
@zhaojj2209 zhaojj2209 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Mar 27, 2023
@zhaojj2209 zhaojj2209 merged commit ffc67a0 into TEAMMATES:master Mar 27, 2023
@zhaojj2209 zhaojj2209 added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 left review comments

@samuelfangjw samuelfangjw samuelfangjw approved these changes

@weiquu weiquu weiquu approved these changes

Assignees

@jasonqiu212 jasonqiu212

@weiquu weiquu

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.26.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zhaojj2209 @jasonqiu212 @weiquu @samuelfangjw