-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12466] Clarify masquerade mode in docs #12470
Conversation
Changed the documentation for masquerade mode that the user should be the entire email address and not just the leading portion. ( New to this project so not 100% if it can be something that is not an email. )
Hi @JacksonsProfileViewer, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some changes. Might have some changes again (following the issue). Let's see.
docs/development.md
Outdated
1. When logged in as administrator, ***masquerade mode*** can also be used to impersonate instructors and students by adding `user=username` to the URL | ||
e.g `http://localhost:8080/web/student/home?user=johnKent`. | ||
e.g `http://localhost:8080/web/student/home?user=johnKent@example.com` where the user to impersonate has a `username` of `johnKent@example.com`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change it to:
e.g http://localhost:8080/web/student/home?user=johnKent@example.com
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub doesn't allow me to suggest. Basically, remove everything from ...where the user to...
. Let's shift this detail to the point above instead (refer to next comment). Thanks!
Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final change. Other than that LGTM! Thank you for your contribution!
1. When logged in as administrator, ***masquerade mode*** can also be used to impersonate instructors and students by adding `user=username` to the URL | ||
e.g `http://localhost:8080/web/student/home?user=johnKent`. | ||
1. When logged in as administrator, ***masquerade mode*** can also be used to impersonate instructors and students by adding `user=email` to the URL. Developers who want to use masquerade mode have to ensure that the username is the email address used to verify the user, e.g user@email.com, when signing up mock instructors. | ||
e.g `http://localhost:8080/web/student/home?user=johnKent@example.com` where the user to impersonate has a `username` of `johnKent@example.com`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g `http://localhost:8080/web/student/home?user=johnKent@example.com` where the user to impersonate has a `username` of `johnKent@example.com`. | |
e.g `http://localhost:8080/web/student/home?user=johnKent@example.com` where the user to impersonate has a username of `johnKent@example.com`. |
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
1 similar comment
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
Hi @JacksonsProfileViewer, do take a look at the requested changes |
Closing due to inactivity. |
Fixes #12466
Outline of Solution
Changed the documentation for masquerade mode. Made it clear that the user should be the entire email address and not just the leading portion. ( New to this project so not 100% if it can't be something that is not an email. )