Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12466] Clarify masquerade mode in docs #12470

Closed
wants to merge 2 commits into from
Closed

[#12466] Clarify masquerade mode in docs #12470

wants to merge 2 commits into from

Conversation

JacksonsProfileViewer
Copy link

@JacksonsProfileViewer JacksonsProfileViewer commented Jun 8, 2023

Fixes #12466

Outline of Solution

Changed the documentation for masquerade mode. Made it clear that the user should be the entire email address and not just the leading portion. ( New to this project so not 100% if it can't be something that is not an email. )

Changed the documentation for masquerade mode that the user should be the entire email address and not just the leading portion.
( New to this project so not 100% if it can be something that is not an email. )
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Hi @JacksonsProfileViewer, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@domlimm domlimm added the s.ToReview The PR is waiting for review(s) label Jun 8, 2023
@domlimm domlimm self-requested a review June 8, 2023 14:50
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some changes. Might have some changes again (following the issue). Let's see.

Comment on lines 130 to 131
1. When logged in as administrator, ***masquerade mode*** can also be used to impersonate instructors and students by adding `user=username` to the URL
e.g `http://localhost:8080/web/student/home?user=johnKent`.
e.g `http://localhost:8080/web/student/home?user=johnKent@example.com` where the user to impersonate has a `username` of `johnKent@example.com`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change it to:
e.g http://localhost:8080/web/student/home?user=johnKent@example.com.

Copy link
Contributor

@domlimm domlimm Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub doesn't allow me to suggest. Basically, remove everything from ...where the user to.... Let's shift this detail to the point above instead (refer to next comment). Thanks!

docs/development.md Outdated Show resolved Hide resolved
Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final change. Other than that LGTM! Thank you for your contribution!

1. When logged in as administrator, ***masquerade mode*** can also be used to impersonate instructors and students by adding `user=username` to the URL
e.g `http://localhost:8080/web/student/home?user=johnKent`.
1. When logged in as administrator, ***masquerade mode*** can also be used to impersonate instructors and students by adding `user=email` to the URL. Developers who want to use masquerade mode have to ensure that the username is the email address used to verify the user, e.g user@email.com, when signing up mock instructors.
e.g `http://localhost:8080/web/student/home?user=johnKent@example.com` where the user to impersonate has a `username` of `johnKent@example.com`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
e.g `http://localhost:8080/web/student/home?user=johnKent@example.com` where the user to impersonate has a `username` of `johnKent@example.com`.
e.g `http://localhost:8080/web/student/home?user=johnKent@example.com` where the user to impersonate has a username of `johnKent@example.com`.

@domlimm domlimm added s.Ongoing The PR is being worked on by the author(s) and removed s.ToReview The PR is waiting for review(s) labels Jun 14, 2023
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

1 similar comment
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@weiquu
Copy link
Contributor

weiquu commented Jun 28, 2023

Hi @JacksonsProfileViewer, do take a look at the requested changes

@weiquu
Copy link
Contributor

weiquu commented Jul 3, 2023

Closing due to inactivity.

@weiquu weiquu closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.Ongoing The PR is being worked on by the author(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify masquerade mode in docs
5 participants