Skip to content
This repository was archived by the owner on Apr 16, 2025. It is now read-only.

Commit 3bcad79

Browse files
committed
refactor!: spelling mistake identifer -> identifier
BREAKING CHANGES: This won't work with the current version of the resource. You will need v2.3.0 and above.
1 parent 53a5187 commit 3bcad79

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

js/src/controls.2.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ function initPlayerMarkerControls(Map, PlayerMarkers){
162162

163163
var name = marker.title;
164164
var child = L.DomUtil.create("li", "clusteredPlayerMarker");
165-
child.setAttribute("data-identifier", marker.player.identifer);
165+
child.setAttribute("data-identifier", marker.player.identifier);
166166
child.appendChild(document.createTextNode(name));
167167

168168
html.appendChild(child);

js/src/socket.1.js

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -284,10 +284,10 @@ function getPlayerInfoHtml(plr) {
284284
continue; // We're already displaying this info
285285
}
286286

287-
if (!(key === "identifer")) {
287+
if (!(key === "identifier")) {
288288
html += '<div class="row info-body-row"><strong>' + key + ':</strong>&nbsp;' + plr[key] + '</div>';
289-
} else if (config.showIdentifiers && key == "identifer") {
290-
html += '<div class="row info-body-row"><strong>Identifer:</strong>&nbsp;' + plr[key] + '</div>';
289+
} else if (config.showIdentifiers && key == "identifier") {
290+
html += '<div class="row info-body-row"><strong>identifier:</strong>&nbsp;' + plr[key] + '</div>';
291291
} else {
292292
continue;
293293
}
@@ -304,9 +304,9 @@ function getFilterProps(plr){
304304
continue; // We're already displaying this info
305305
}
306306

307-
if (!(key === "identifer")) {
307+
if (!(key === "identifier")) {
308308
props.push(key);
309-
} else if (config.showIdentifiers && key == "identifer") {
309+
} else if (config.showIdentifiers && key == "identifier") {
310310
props.push(key);
311311
} else {
312312
continue;
@@ -330,10 +330,10 @@ function doPlayerUpdate(players) {
330330

331331
players.forEach(function (plr) {
332332
if (plr == null || plr.name == undefined || plr.name == "") return;
333-
if (plr.identifer == undefined || plr.identifer == "") return;
333+
if (plr.identifier == undefined || plr.identifier == "") return;
334334

335-
if (!(plr.identifer in localCache)) {
336-
localCache[plr.identifer] = { marker: null, lastHtml: null };
335+
if (!(plr.identifier in localCache)) {
336+
localCache[plr.identifier] = { marker: null, lastHtml: null };
337337
}
338338

339339
// Filtering stuff
@@ -359,46 +359,46 @@ function doPlayerUpdate(players) {
359359
}
360360
}
361361

362-
if ($("#playerSelect option[value='" + plr.identifer + "']").length <= 0) {
362+
if ($("#playerSelect option[value='" + plr.identifier + "']").length <= 0) {
363363
// Ooo look, we have players. Let's add them to the "tracker" drop-down
364364
$("#playerSelect").append($("<option>", {
365-
value: plr.identifer, // Should be unique
365+
value: plr.identifier, // Should be unique
366366
text: plr.name // Their name.. Might not be unique?
367367
}));
368368
}
369369

370-
if (_trackPlayer != null && _trackPlayer == plr.identifer) {
370+
if (_trackPlayer != null && _trackPlayer == plr.identifier) {
371371
// If we're tracking a player, make sure we center them
372372
Map.panTo(convertToMap(plr.pos.x, plr.pos.y));
373373
}
374374

375-
if (localCache[plr.identifer].marker != null || localCache[plr.identifer].marker != undefined) {
375+
if (localCache[plr.identifier].marker != null || localCache[plr.identifier].marker != undefined) {
376376
// If we have a custom icon (we should) use it!!
377377
if (plr.icon) {
378378
var t = MarkerTypes[plr.icon];
379379

380380
//console._log("Got icon of :" + plr.icon);
381381

382-
MarkerStore[localCache[plr.identifer].marker].setIcon(L.icon(t));
382+
MarkerStore[localCache[plr.identifier].marker].setIcon(L.icon(t));
383383
}
384384

385385
// Update the player's location on the map :)
386-
MarkerStore[localCache[plr.identifer].marker].setLatLng(convertToMapLeaflet(plr.pos.x, plr.pos.y));
386+
MarkerStore[localCache[plr.identifier].marker].setLatLng(convertToMapLeaflet(plr.pos.x, plr.pos.y));
387387

388388
//update popup with the information we have been sent
389389
var html = getPlayerInfoHtml(plr);
390390

391391
var infoContent = '<div class="info-window"><div class="info-header-box"><div class="info-header">' + plr.name + '</div></div><div class="clear"></div><div id=info-body>' + html + "</div></div>";
392392

393-
var m = localCache[plr.identifer].marker;
393+
var m = localCache[plr.identifier].marker;
394394
var marker = MarkerStore[m];
395395
var popup = PopupStore[m];
396396

397397
marker.setOpacity(opacity);
398398

399-
if (infoContent != localCache[plr.identifer].lastHtml){
399+
if (infoContent != localCache[plr.identifier].lastHtml){
400400
popup.setContent(infoContent);
401-
localCache[plr.identifer].lastHtml = infoContent;
401+
localCache[plr.identifier].lastHtml = infoContent;
402402
}
403403

404404
if(popup.isOpen()){
@@ -409,12 +409,12 @@ function doPlayerUpdate(players) {
409409

410410

411411
} else {
412-
localCache[plr.identifer].lastHtml = infoContent;
412+
localCache[plr.identifier].lastHtml = infoContent;
413413
var html = getPlayerInfoHtml(plr);
414414
var infoContent = '<div class="info-window"><div class="info-header-box"><div class="info-icon"></div><div class="info-header">' + plr.name + '</div></div><div class="clear"></div><div id=info-body>' + html + "</div></div>";
415415

416416
var obj = new MarkerObject(plr.name, new Coordinates(plr.pos.x, plr.pos.y, plr.pos.z), MarkerTypes[6], "", {isPlayer: true, player: plr});
417-
var m = localCache[plr.identifer].marker = createMarker(false, false, obj, plr.name) - 1;
417+
var m = localCache[plr.identifier].marker = createMarker(false, false, obj, plr.name) - 1;
418418

419419
MarkerStore[m].unbindPopup(); // We want to handle the popups ourselfs.
420420
MarkerStore[m].setOpacity(opacity);

0 commit comments

Comments
 (0)