[TASK] add missing codes to thrown exceptions

dkd-kaehm · dkd-kaehm · commit ea5bb914c5bb · 2025-10-16T09:26:40.000+02:00
Adds missing codes to thrown exceptions.
diff --git a/Classes/ConnectionManager.php b/Classes/ConnectionManager.php
@@ -99,12 +99,18 @@ public function getSolrConnectionForEndpoints(
         if (!isset(self::$connections[$connectionHash])) {
             $readEndpoint = new Endpoint($readEndpointConfiguration);
             if (!$this->isValidEndpoint($readEndpoint)) {
-                throw new InvalidConnectionException('Invalid read endpoint');
+                throw new InvalidConnectionException(
+                    'Invalid read endpoint',
+                    1451844097,
+                );
             }
 
             $writeEndpoint = new Endpoint($writeEndpointConfiguration);
             if (!$this->isValidEndpoint($writeEndpoint)) {
-                throw new InvalidConnectionException('Invalid write endpoint');
+                throw new InvalidConnectionException(
+                    'Invalid write endpoint',
+                    1049743991,
+                );
             }
 
             self::$connections[$connectionHash] = GeneralUtility::makeInstance(
diff --git a/Classes/ContentObject/Classification.php b/Classes/ContentObject/Classification.php
@@ -51,7 +51,10 @@ class Classification extends AbstractContentObject
     public function render($conf = [])
     {
         if (!is_array($conf['classes.'])) {
-            throw new InvalidArgumentException('No class configuration configured for SOLR_CLASSIFICATION object. Given configuration: ' . serialize($conf));
+            throw new InvalidArgumentException(
+                'No class configuration configured for SOLR_CLASSIFICATION object. Given configuration: ' . serialize($conf),
+                8365879715,
+            );
         }
 
         $configuredMappedClasses = $conf['classes.'];
@@ -83,7 +86,10 @@ protected function buildClassificationsFromConfiguration(array $configuredMapped
         $classifications = [];
         foreach ($configuredMappedClasses as $class) {
             if ((empty($class['patterns']) && empty($class['matchPatterns'])) || empty($class['class'])) {
-                throw new InvalidArgumentException('A class configuration in SOLR_CLASSIFCATION needs to have a pattern and a class configured. Given configuration: ' . serialize($class));
+                throw new InvalidArgumentException(
+                    'A class configuration in SOLR_CLASSIFCATION needs to have a pattern and a class configured. Given configuration: ' . serialize($class),
+                    8715165614,
+                );
             }
 
             // @todo deprecate patterns configuration
diff --git a/Classes/Domain/Search/Query/ParameterBuilder/Operator.php b/Classes/Domain/Search/Query/ParameterBuilder/Operator.php
@@ -42,7 +42,10 @@ public function __construct(
     public function setOperator(string $operator): void
     {
         if (!in_array($operator, [self::OPERATOR_AND, self::OPERATOR_OR])) {
-            throw new InvalidArgumentException('Invalid operator');
+            throw new InvalidArgumentException(
+                'Invalid operator',
+                8402616466,
+            );
         }
 
         $this->operator = $operator;
diff --git a/Classes/Domain/Search/ResultSet/Facets/AbstractFacetPackage.php b/Classes/Domain/Search/ResultSet/Facets/AbstractFacetPackage.php
@@ -33,7 +33,10 @@ public function getParser(): FacetParserInterface
     {
         $parser = GeneralUtility::makeInstance($this->getParserClassName());
         if (!$parser instanceof FacetParserInterface) {
-            throw new InvalidFacetPackageException('Invalid parser for package ' . __CLASS__);
+            throw new InvalidFacetPackageException(
+                'Invalid parser for package ' . __CLASS__,
+                8634008284,
+            );
         }
 
         return $parser;
@@ -51,7 +54,10 @@ public function getUrlDecoder(): FacetUrlDecoderInterface
     {
         $urlDecoder = GeneralUtility::makeInstance($this->getUrlDecoderClassName());
         if (!$urlDecoder instanceof FacetUrlDecoderInterface) {
-            throw new InvalidUrlDecoderException('Invalid url-decoder for package ' . __CLASS__);
+            throw new InvalidUrlDecoderException(
+                'Invalid url-decoder for package ' . __CLASS__,
+                9144462614,
+            );
         }
 
         return $urlDecoder;
@@ -69,7 +75,10 @@ public function getQueryBuilder(): FacetQueryBuilderInterface
     {
         $facetQueryBuilder = GeneralUtility::makeInstance($this->getQueryBuilderClassName());
         if (!$facetQueryBuilder instanceof FacetQueryBuilderInterface) {
-            throw new InvalidQueryBuilderException('Invalid query-builder for package ' . __CLASS__);
+            throw new InvalidQueryBuilderException(
+                'Invalid query-builder for package ' . __CLASS__,
+                5405805432,
+            );
         }
 
         return $facetQueryBuilder;
diff --git a/Classes/Domain/Search/ResultSet/Facets/FacetRegistry.php b/Classes/Domain/Search/ResultSet/Facets/FacetRegistry.php
@@ -86,7 +86,10 @@ public function getPackage(string $type): AbstractFacetPackage
     {
         $instance = $this->getInstance($type);
         if (!$instance instanceof AbstractFacetPackage) {
-            throw new InvalidFacetPackageException('Invalid class registered for ' . htmlspecialchars($type));
+            throw new InvalidFacetPackageException(
+                'Invalid class registered for ' . htmlspecialchars($type),
+                2019898766,
+            );
         }
         return $instance;
     }
diff --git a/Classes/Domain/Search/ResultSet/Facets/RequirementsService.php b/Classes/Domain/Search/ResultSet/Facets/RequirementsService.php
@@ -81,7 +81,10 @@ protected function getSelectedItemValues(AbstractFacet $facet, string $facetName
     {
         $facetToCheckRequirements = $facet->getResultSet()->getFacets()->getByName($facetNameToCheckRequirementsOn)->getByPosition(0);
         if (!$facetToCheckRequirements instanceof AbstractFacet) {
-            throw new InvalidArgumentException('Requirement for unexisting facet configured');
+            throw new InvalidArgumentException(
+                'Requirement for non-existing facet configured',
+                4953268822,
+            );
         }
 
         if (!$facetToCheckRequirements->getIsUsed()) {
diff --git a/Classes/Domain/Search/ResultSet/ResultSetReconstitutionProcessor.php b/Classes/Domain/Search/ResultSet/ResultSetReconstitutionProcessor.php
@@ -135,7 +135,10 @@ private function parseSpellCheckingResponseIntoObjects(SearchResultSet $resultSe
             }
 
             if ($misspelledTerm === '') {
-                throw new UnexpectedValueException('No misspelled term before suggestion');
+                throw new UnexpectedValueException(
+                    'No misspelled term before suggestion',
+                    4271427727,
+                );
             }
 
             if (!is_object($suggestionData) && !is_array($suggestionData->suggestion)) {
diff --git a/Classes/Domain/Search/ResultSet/SearchResultSetService.php b/Classes/Domain/Search/ResultSet/SearchResultSetService.php
@@ -299,7 +299,10 @@ public function getDocumentById(string $documentId): SearchResult
         $resultDocument = $parsedData->response->docs[0] ?? null;
 
         if (!$resultDocument instanceof Document) {
-            throw new UnexpectedValueException('Response did not contain a valid Document object');
+            throw new UnexpectedValueException(
+                'Response did not contain a valid Document object',
+                1113053393,
+            );
         }
 
         return $this->searchResultBuilder->fromApacheSolrDocument($resultDocument);
diff --git a/Classes/Domain/Search/ResultSet/Sorting/Sorting.php b/Classes/Domain/Search/ResultSet/Sorting/Sorting.php
@@ -53,7 +53,10 @@ public function __construct(
         bool $isResetOption = false,
     ) {
         if (!self::getIsValidDirection($direction)) {
-            throw new InvalidArgumentException('Invalid sorting direction');
+            throw new InvalidArgumentException(
+                'Invalid sorting direction',
+                8919514853,
+            );
         }
         $this->name = $name;
         $this->direction = $direction;
diff --git a/Classes/Domain/Variants/IdBuilder.php b/Classes/Domain/Variants/IdBuilder.php
@@ -57,7 +57,10 @@ public function buildFromTypeAndUid(string $type, int $uid, array $itemRecord, S
     protected function getSystemHash(): string
     {
         if (!isset($GLOBALS['TYPO3_CONF_VARS']['SYS']['sitename'])) {
-            throw new InvalidArgumentException('No sitename set in TYPO3_CONF_VARS|SYS|sitename');
+            throw new InvalidArgumentException(
+                'No sitename set in TYPO3_CONF_VARS|SYS|sitename',
+                8666989008,
+            );
         }
 
         $siteName = $GLOBALS['TYPO3_CONF_VARS']['SYS']['sitename'];
diff --git a/Classes/IndexQueue/Indexer.php b/Classes/IndexQueue/Indexer.php
@@ -670,7 +670,10 @@ protected function getDefaultLanguageUid(Item $item, array $rootPageRecord, arra
             $defaultLanguageUid = $siteLanguages[min(array_keys($siteLanguages))];
         } elseif (($rootPageRecord['l18n_cfg'] & 1) == 1 && count($siteLanguages) == 1) {
             $message = 'Root page ' . (int)$item->getRootPageUid() . ' is set to hide default translation, but no other language is configured!';
-            throw new RuntimeException($message);
+            throw new RuntimeException(
+                $message,
+                2554826832,
+            );
         }
 
         return $defaultLanguageUid;
diff --git a/Classes/System/Environment/CliEnvironment.php b/Classes/System/Environment/CliEnvironment.php
@@ -52,7 +52,10 @@ public function initialize(
         }
 
         if (defined('TYPO3_PATH_WEB')) {
-            throw new WebRootAllReadyDefinedException('TYPO3_PATH_WEB is already defined');
+            throw new WebRootAllReadyDefinedException(
+                'TYPO3_PATH_WEB is already defined',
+                7904456080,
+            );
         }
 
         if ($scriptFileName === '') {
diff --git a/Classes/System/Solr/ParsingUtil.php b/Classes/System/Solr/ParsingUtil.php
@@ -39,7 +39,10 @@ public static function getMapArrayFromFlatArray(array $options): array
                 $valueFromKeyNode = $value;
             } else {
                 if ($valueFromKeyNode == -1) {
-                    throw new UnexpectedValueException('No optionValue before count value');
+                    throw new UnexpectedValueException(
+                        'No optionValue before count value',
+                        5795798675,
+                    );
                 }
                 //we have a countNode
                 $keyValueMap[$valueFromKeyNode] = $value;
diff --git a/Classes/System/Solr/Service/SolrAdminService.php b/Classes/System/Solr/Service/SolrAdminService.php
@@ -172,7 +172,10 @@ public function getSolrconfigName(): ?string
             $response = $this->_sendRawGet($solrconfigXmlUrl);
             $solrconfigXml = simplexml_load_string($response->getRawResponse());
             if ($solrconfigXml === false) {
-                throw new InvalidArgumentException('No valid xml response from schema file: ' . $solrconfigXmlUrl);
+                throw new InvalidArgumentException(
+                    'No valid xml response from schema file: ' . $solrconfigXmlUrl,
+                    6337336918,
+                );
             }
             $this->solrconfigName = (string)$solrconfigXml->attributes()->name;
         }
@@ -291,7 +294,10 @@ public function deleteStopWord(string $stopWordToDelete): ResponseAdapter
     {
         $this->initializeStopWordsUrl();
         if (empty($stopWordToDelete)) {
-            throw new InvalidArgumentException('Must provide stop word.');
+            throw new InvalidArgumentException(
+                'Must provide stop word.',
+                5002188179,
+            );
         }
 
         return $this->_sendRawDelete($this->_stopWordsUrl . '/' . rawurlencode(rawurlencode($stopWordToDelete)));
diff --git a/Classes/ViewHelpers/Uri/Facet/AbstractValueViewHelper.php b/Classes/ViewHelpers/Uri/Facet/AbstractValueViewHelper.php
@@ -51,7 +51,10 @@ protected static function getValueFromArguments(array $arguments = []): string
         } elseif (isset($arguments['facetItemValue'])) {
             $facetValue = $arguments['facetItemValue'];
         } else {
-            throw new InvalidArgumentException('No facetItem was passed, please pass either facetItem or facetItemValue');
+            throw new InvalidArgumentException(
+                'No facetItem was passed, please pass either facetItem or facetItemValue',
+                9637361100,
+            );
         }
 
         return $facetValue;
@@ -69,7 +72,10 @@ protected static function getNameFromArguments(array $arguments = []): string
         } elseif (isset($arguments['facetName'])) {
             $facetName = $arguments['facetName'];
         } else {
-            throw new InvalidArgumentException('No facet was passed, please pass either facet or facetName', 1680615971);
+            throw new InvalidArgumentException(
+                'No facet was passed, please pass either facet or facetName',
+                1680615971,
+            );
         }
 
         return $facetName;
@@ -87,7 +93,10 @@ protected static function getResultSetFromArguments(array $arguments = []): Sear
         } elseif (isset($arguments['facetName'])) {
             $resultSet = $arguments['resultSet'];
         } else {
-            throw new InvalidArgumentException('No facet was passed, please pass either facet or resultSet');
+            throw new InvalidArgumentException(
+                'No facet was passed, please pass either facet or resultSet',
+                6037735115,
+            );
         }
 
         return $resultSet;
diff --git a/Tests/Integration/IndexQueue/RecordMonitorTest.php b/Tests/Integration/IndexQueue/RecordMonitorTest.php
@@ -148,7 +148,10 @@ protected function assertEventQueueContainsItemAmount(int $amount): void
     #[Test]
     public function canUpdateRootPageRecordWithoutSQLErrorFromMountPages(): void
     {
-        throw new SkippedWithMessageException('Skipping canUpdateRootPageRecordWithoutSQLErrorFromMountPages');
+        throw new SkippedWithMessageException(
+            'Skipping canUpdateRootPageRecordWithoutSQLErrorFromMountPages',
+            9115338385,
+        );
 
         // we expect that the index queue is empty before we start
         $this->assertEmptyIndexQueue();
diff --git a/Tests/Integration/IntegrationTestBase.php b/Tests/Integration/IntegrationTestBase.php
@@ -176,7 +176,10 @@ protected function waitToBeVisibleInSolr(string $coreName = 'core_en'): array|fa
     protected function validateTestCoreName(string $coreName): void
     {
         if (!in_array($coreName, $this->testSolrCores, true)) {
-            throw new InvalidArgumentException('No valid test core passed');
+            throw new InvalidArgumentException(
+                'No valid test core passed',
+                1104133825,
+            );
         }
     }
 
diff --git a/Tests/Unit/Domain/Index/IndexServiceTest.php b/Tests/Unit/Domain/Index/IndexServiceTest.php
@@ -119,7 +119,10 @@ public function testServerHostIsRestoredInCaseOfAnException(): void
             ->onlyMethods(['index'])
             ->getMock();
         $indexerMock->expects(self::exactly(2))->method('index')->willReturnCallback(function () {
-            throw new Exception('unknown error occurred');
+            throw new Exception(
+                'unknown error occurred',
+                8102831540,
+            );
         });
         $indexService->expects(self::exactly(2))->method('getIndexerByItem')->willReturn($indexerMock);
 
diff --git a/Tests/Unit/Domain/Search/ResultSet/Facets/RequirementsServiceTest.php b/Tests/Unit/Domain/Search/ResultSet/Facets/RequirementsServiceTest.php
@@ -215,7 +215,7 @@ public function getAllRequirementsMetIsReturnsFalseIfRequiredFacetValueIsNotSele
     public function exceptionIsThrownForRequirementWithNotExistingFacet(): void
     {
         $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('Requirement for unexisting facet configured');
+        $this->expectExceptionMessage('Requirement for non-existing facet configured');
         $resultSet = new SearchResultSet();
 
         $categoryConfig = [
diff --git a/Tests/Unit/Domain/Search/Uri/SearchUriBuilderTest.php b/Tests/Unit/Domain/Search/Uri/SearchUriBuilderTest.php
@@ -513,7 +513,10 @@ public function uriErrorsResultInNonMappedProcessing(): void
         $this->extBaseUriBuilderMock->expects(self::exactly(2))->method('build')
             ->willReturnCallback(function () use ($linkBuilderResult, &$buildCounter) {
                 if (++$buildCounter === 1) {
-                    throw new InvalidParameterException('First call fails, should reprocess with regular arguments');
+                    throw new InvalidParameterException(
+                        'First call fails, should reprocess with regular arguments',
+                        5962606500,
+                    );
                 }
                 return $linkBuilderResult;
             });

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,10 @@ public function __construct(`
`42`	`42`	`public function setOperator(string $operator): void`
`43`	`43`	`{`
`44`	`44`	`if (!in_array($operator, [self::OPERATOR_AND, self::OPERATOR_OR])) {`
`45`		`- throw new InvalidArgumentException('Invalid operator');`
	`45`	`+ throw new InvalidArgumentException(`
	`46`	`+ 'Invalid operator',`
	`47`	`+ 8402616466,`
	`48`	`+ );`
`46`	`49`	`}`
`47`	`50`
`48`	`51`	`$this->operator = $operator;`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,10 @@ public function getParser(): FacetParserInterface`
`33`	`33`	`{`
`34`	`34`	`$parser = GeneralUtility::makeInstance($this->getParserClassName());`
`35`	`35`	`if (!$parser instanceof FacetParserInterface) {`
`36`		`- throw new InvalidFacetPackageException('Invalid parser for package ' . __CLASS__);`
	`36`	`+ throw new InvalidFacetPackageException(`
	`37`	`+ 'Invalid parser for package ' . __CLASS__,`
	`38`	`+ 8634008284,`
	`39`	`+ );`
`37`	`40`	`}`
`38`	`41`
`39`	`42`	`return $parser;`
`@@ -51,7 +54,10 @@ public function getUrlDecoder(): FacetUrlDecoderInterface`
`51`	`54`	`{`
`52`	`55`	`$urlDecoder = GeneralUtility::makeInstance($this->getUrlDecoderClassName());`
`53`	`56`	`if (!$urlDecoder instanceof FacetUrlDecoderInterface) {`
`54`		`- throw new InvalidUrlDecoderException('Invalid url-decoder for package ' . __CLASS__);`
	`57`	`+ throw new InvalidUrlDecoderException(`
	`58`	`+ 'Invalid url-decoder for package ' . __CLASS__,`
	`59`	`+ 9144462614,`
	`60`	`+ );`
`55`	`61`	`}`
`56`	`62`
`57`	`63`	`return $urlDecoder;`
`@@ -69,7 +75,10 @@ public function getQueryBuilder(): FacetQueryBuilderInterface`
`69`	`75`	`{`
`70`	`76`	`$facetQueryBuilder = GeneralUtility::makeInstance($this->getQueryBuilderClassName());`
`71`	`77`	`if (!$facetQueryBuilder instanceof FacetQueryBuilderInterface) {`
`72`		`- throw new InvalidQueryBuilderException('Invalid query-builder for package ' . __CLASS__);`
	`78`	`+ throw new InvalidQueryBuilderException(`
	`79`	`+ 'Invalid query-builder for package ' . __CLASS__,`
	`80`	`+ 5405805432,`
	`81`	`+ );`
`73`	`82`	`}`
`74`	`83`
`75`	`84`	`return $facetQueryBuilder;`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,10 @@ public function getPackage(string $type): AbstractFacetPackage`
`86`	`86`	`{`
`87`	`87`	`$instance = $this->getInstance($type);`
`88`	`88`	`if (!$instance instanceof AbstractFacetPackage) {`
`89`		`- throw new InvalidFacetPackageException('Invalid class registered for ' . htmlspecialchars($type));`
	`89`	`+ throw new InvalidFacetPackageException(`
	`90`	`+ 'Invalid class registered for ' . htmlspecialchars($type),`
	`91`	`+ 2019898766,`
	`92`	`+ );`
`90`	`93`	`}`
`91`	`94`	`return $instance;`
`92`	`95`	`}`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,10 @@ protected function getSelectedItemValues(AbstractFacet $facet, string $facetName`
`81`	`81`	`{`
`82`	`82`	`$facetToCheckRequirements = $facet->getResultSet()->getFacets()->getByName($facetNameToCheckRequirementsOn)->getByPosition(0);`
`83`	`83`	`if (!$facetToCheckRequirements instanceof AbstractFacet) {`
`84`		`- throw new InvalidArgumentException('Requirement for unexisting facet configured');`
	`84`	`+ throw new InvalidArgumentException(`
	`85`	`+ 'Requirement for non-existing facet configured',`
	`86`	`+ 4953268822,`
	`87`	`+ );`
`85`	`88`	`}`
`86`	`89`
`87`	`90`	`if (!$facetToCheckRequirements->getIsUsed()) {`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,10 @@ private function parseSpellCheckingResponseIntoObjects(SearchResultSet $resultSe`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`if ($misspelledTerm === '') {`
`138`		`- throw new UnexpectedValueException('No misspelled term before suggestion');`
	`138`	`+ throw new UnexpectedValueException(`
	`139`	`+ 'No misspelled term before suggestion',`
	`140`	`+ 4271427727,`
	`141`	`+ );`
`139`	`142`	`}`
`140`	`143`
`141`	`144`	`if (!is_object($suggestionData) && !is_array($suggestionData->suggestion)) {`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,10 @@ public function buildFromTypeAndUid(string $type, int $uid, array $itemRecord, S`
`57`	`57`	`protected function getSystemHash(): string`
`58`	`58`	`{`
`59`	`59`	`if (!isset($GLOBALS['TYPO3_CONF_VARS']['SYS']['sitename'])) {`
`60`		`- throw new InvalidArgumentException('No sitename set in TYPO3_CONF_VARS\|SYS\|sitename');`
	`60`	`+ throw new InvalidArgumentException(`
	`61`	`+ 'No sitename set in TYPO3_CONF_VARS\|SYS\|sitename',`
	`62`	`+ 8666989008,`
	`63`	`+ );`
`61`	`64`	`}`
`62`	`65`
`63`	`66`	`$siteName = $GLOBALS['TYPO3_CONF_VARS']['SYS']['sitename'];`