Add Tag Merging #322
Merged
Add Tag Merging #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Enhancement
26 tasks
CyanVoxel
added
the
Priority: Medium
|
Thank you for your work on this! I apologize for not getting around to this sooner. The tag merging logic seems to be sound, but there's a few UI improvements I'd like to add myself in addition to the issue you mentioned about the tag search modal not updating. Rather than work off your PR, I'll be pulling this as-is into a feature branch before touching up the UI and eventually merging into the v9.4 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to merge tags in the tags context menu (should this be in the manage tags modal only?). Merge tag adds the source tag name and aliases to the target tag, appends all subtags to the target tag, reassigns all entries to the target tag, and removes the source tag.
Let me know if I'm missing anything in the merge process. Also, when the modal closes the ui state doesn't immediately show the merge. Any ways to make it more reactive?
Closes #12