test: update localStorage tests for type-safe encoding

Update all localStorage collection tests to match the new type-safe
key encoding format that prevents collisions between numeric and
string IDs.

Changes:
- Update test assertions to use encoded keys ("s:1" for string "1")
- Update test data setup to use encoded keys in storage
- Fix verifyConsistency helper to decode storage keys properly
- All 17 failing tests now correctly expect the encoded format

Co-authored-by: Kevin <kevin-dp@users.noreply.github.com>

Author: github-actions[bot]

packages/db/tests/local-storage.test.ts

@@ -206,17 +206,17 @@ describe(`localStorage collection`, () => {
         storedData!
       )
 
-      expect(parsed[`1`]?.data.title).toBe(`superjson`)
-      expect(parsed[`1`]?.data.completed).toBe(false)
-      expect(parsed[`1`]?.data.createdAt).toBeInstanceOf(Date)
+      expect(parsed[`s:1`]?.data.title).toBe(`superjson`)
+      expect(parsed[`s:1`]?.data.completed).toBe(false)
+      expect(parsed[`s:1`]?.data.createdAt).toBeInstanceOf(Date)
     })
   })
 
   describe(`data persistence`, () => {
     it(`should load existing data from storage on initialization`, () => {
       // Pre-populate storage with new versioned format
       const existingTodos = {
-        "1": {
+        "s:1": {
           versionKey: `test-version-1`,
           data: {
             id: `1`,
@@ -310,7 +310,7 @@ describe(`localStorage collection`, () => {
       let storedData = mockStorage.getItem(`todos`)
       expect(storedData).toBeDefined()
       let parsed = JSON.parse(storedData!)
-      expect(parsed[`1`].data.title).toBe(`Test Todo Without Handlers`)
+      expect(parsed[`s:1`].data.title).toBe(`Test Todo Without Handlers`)
 
       // Update without handlers should still persist
       const updateTx = collection.update(`1`, (draft) => {
@@ -322,7 +322,7 @@ describe(`localStorage collection`, () => {
       storedData = mockStorage.getItem(`todos`)
       expect(storedData).toBeDefined()
       parsed = JSON.parse(storedData!)
-      expect(parsed[`1`].data.title).toBe(`Updated Without Handlers`)
+      expect(parsed[`s:1`].data.title).toBe(`Updated Without Handlers`)
 
       // Delete without handlers should still persist
       const deleteTx = collection.delete(`1`)
@@ -332,7 +332,7 @@ describe(`localStorage collection`, () => {
       storedData = mockStorage.getItem(`todos`)
       expect(storedData).toBeDefined()
       parsed = JSON.parse(storedData!)
-      expect(parsed[`1`]).toBeUndefined()
+      expect(parsed[`s:1`]).toBeUndefined()
 
       subscription.unsubscribe()
     })
@@ -372,7 +372,7 @@ describe(`localStorage collection`, () => {
       let storedData = mockStorage.getItem(`todos`)
       expect(storedData).toBeDefined()
       let parsed = JSON.parse(storedData!)
-      expect(parsed[`1`].data.title).toBe(`Test Todo With Handlers`)
+      expect(parsed[`s:1`].data.title).toBe(`Test Todo With Handlers`)
 
       // Update should call handler AND persist
       const updateTx = collection.update(`1`, (draft) => {
@@ -384,7 +384,7 @@ describe(`localStorage collection`, () => {
       storedData = mockStorage.getItem(`todos`)
       expect(storedData).toBeDefined()
       parsed = JSON.parse(storedData!)
-      expect(parsed[`1`].data.title).toBe(`Updated With Handlers`)
+      expect(parsed[`s:1`].data.title).toBe(`Updated With Handlers`)
 
       // Delete should call handler AND persist
       const deleteTx = collection.delete(`1`)
@@ -394,7 +394,7 @@ describe(`localStorage collection`, () => {
       storedData = mockStorage.getItem(`todos`)
       expect(storedData).toBeDefined()
       parsed = JSON.parse(storedData!)
-      expect(parsed[`1`]).toBeUndefined()
+      expect(parsed[`s:1`]).toBeUndefined()
 
       subscription.unsubscribe()
     })
@@ -428,17 +428,17 @@ describe(`localStorage collection`, () => {
 
       const parsed = JSON.parse(storedData!)
       expect(typeof parsed).toBe(`object`)
-      expect(parsed[`1`]).toBeDefined()
-      expect(parsed[`1`].versionKey).toBeDefined()
-      expect(typeof parsed[`1`].versionKey).toBe(`string`)
-      expect(parsed[`1`].data.id).toBe(`1`)
-      expect(parsed[`1`].data.title).toBe(`Test Todo`)
+      expect(parsed[`s:1`]).toBeDefined()
+      expect(parsed[`s:1`].versionKey).toBeDefined()
+      expect(typeof parsed[`s:1`].versionKey).toBe(`string`)
+      expect(parsed[`s:1`].data.id).toBe(`1`)
+      expect(parsed[`s:1`].data.title).toBe(`Test Todo`)
     })
 
     it(`should perform update operations and update storage`, async () => {
       // Pre-populate storage
       const initialData = {
-        "1": {
+        "s:1": {
           versionKey: `initial-version`,
           data: {
             id: `1`,
@@ -474,16 +474,16 @@ describe(`localStorage collection`, () => {
       expect(storedData).toBeDefined()
 
       const parsed = JSON.parse(storedData!)
-      expect(parsed[`1`].versionKey).not.toBe(`initial-version`) // Should have new version key
-      expect(parsed[`1`].data.title).toBe(`Updated Todo`)
+      expect(parsed[`s:1`].versionKey).not.toBe(`initial-version`) // Should have new version key
+      expect(parsed[`s:1`].data.title).toBe(`Updated Todo`)
 
       subscription.unsubscribe()
     })
 
     it(`should perform delete operations and update storage`, async () => {
       // Pre-populate storage
       const initialData = {
-        "1": {
+        "s:1": {
           versionKey: `test-version`,
           data: {
             id: `1`,
@@ -517,7 +517,7 @@ describe(`localStorage collection`, () => {
       expect(storedData).toBeDefined()
 
       const parsed = JSON.parse(storedData!)
-      expect(parsed[`1`]).toBeUndefined()
+      expect(parsed[`s:1`]).toBeUndefined()
 
       subscription.unsubscribe()
     })
@@ -689,7 +689,7 @@ describe(`localStorage collection`, () => {
     it(`should detect version key changes for updates`, () => {
       // Pre-populate storage
       const initialData = {
-        "1": {
+        "s:1": {
           versionKey: `version-1`,
           data: {
             id: `1`,
@@ -718,7 +718,7 @@ describe(`localStorage collection`, () => {
 
       // Simulate change from another tab with different version key but same data
       const updatedData = {
-        "1": {
+        "s:1": {
           versionKey: `version-2`, // Different version key
           data: {
             id: `1`,
@@ -755,7 +755,7 @@ describe(`localStorage collection`, () => {
 
       // Pre-populate storage
       const initialData = {
-        "1": {
+        "s:1": {
           versionKey: `version-1`,
           data: {
             id: `1`,
@@ -781,7 +781,7 @@ describe(`localStorage collection`, () => {
 
       // Simulate "change" from another tab with same version key
       const sameData = {
-        "1": {
+        "s:1": {
           versionKey: `version-1`, // Same version key
           data: {
             id: `1`,
@@ -1197,9 +1197,9 @@ describe(`localStorage collection`, () => {
         const parsed = JSON.parse(storedData!)
 
         // Item 1 should have the last update
-        expect(parsed[`1`].data.title).toBe(`Fourth`)
+        expect(parsed[`s:1`].data.title).toBe(`Fourth`)
         // Item 2 should be deleted
-        expect(parsed[`2`]).toBeUndefined()
+        expect(parsed[`s:2`]).toBeUndefined()
 
         // Verify collection matches storage
         expect(collection.get(`1`)?.title).toBe(`Fourth`)
@@ -1257,8 +1257,8 @@ describe(`localStorage collection`, () => {
         const storedData = mockStorage.getItem(`todos`)
         const parsed = JSON.parse(storedData!)
 
-        expect(parsed[`1`].data.title).toBe(`C`)
-        expect(parsed[`2`]).toBeUndefined()
+        expect(parsed[`s:1`].data.title).toBe(`C`)
+        expect(parsed[`s:2`]).toBeUndefined()
 
         subscription.unsubscribe()
       })
@@ -1287,7 +1287,7 @@ describe(`localStorage collection`, () => {
 
         // Simulate another tab making a change while local mutation is in progress
         const remoteData = {
-          local: {
+          "s:local": {
             versionKey: `local-version`,
             data: {
               id: `local`,
@@ -1296,7 +1296,7 @@ describe(`localStorage collection`, () => {
               createdAt: new Date(),
             },
           },
-          remote: {
+          "s:remote": {
             versionKey: `remote-version`,
             data: {
               id: `remote`,
@@ -1353,7 +1353,7 @@ describe(`localStorage collection`, () => {
 
         // Simulate another tab updating the item
         const remoteData = {
-          "1": {
+          "s:1": {
             versionKey: `remote-version-1`,
             data: {
               id: `1`,
@@ -1387,8 +1387,8 @@ describe(`localStorage collection`, () => {
         const storedData = mockStorage.getItem(`todos`)
         const parsed = JSON.parse(storedData!)
 
-        expect(parsed[`1`].data.title).toBe(`Local Update After Remote`)
-        expect(parsed[`1`].data.completed).toBe(true) // Should preserve remote's completed state
+        expect(parsed[`s:1`].data.title).toBe(`Local Update After Remote`)
+        expect(parsed[`s:1`].data.completed).toBe(true) // Should preserve remote's completed state
 
         subscription.unsubscribe()
       })
@@ -1569,8 +1569,16 @@ describe(`localStorage collection`, () => {
           const parsed = JSON.parse(storedData)
 
           // Check that collection has all items from storage
-          for (const key of Object.keys(parsed)) {
-            if (!collection.has(key)) {
+          // Note: storage keys are encoded (e.g., "s:1"), but we need to decode them
+          // to check collection membership
+          for (const encodedKey of Object.keys(parsed)) {
+            // Decode the storage key to get the actual item key
+            const itemKey = encodedKey.startsWith(`s:`)
+              ? encodedKey.slice(2)
+              : encodedKey.startsWith(`n:`)
+                ? Number(encodedKey.slice(2))
+                : encodedKey
+            if (!collection.has(itemKey)) {
               return false
             }
           }
@@ -1668,9 +1676,9 @@ describe(`localStorage collection`, () => {
       const storedData = mockStorage.getItem(`todos`)
       expect(storedData).toBeDefined()
       const parsed = JSON.parse(storedData!)
-      expect(parsed[`first`].data.completed).toBe(true)
-      expect(parsed[`second`].data.completed).toBe(false)
-      expect(parsed[`third`].data.completed).toBe(false)
+      expect(parsed[`s:first`].data.completed).toBe(true)
+      expect(parsed[`s:second`].data.completed).toBe(false)
+      expect(parsed[`s:third`].data.completed).toBe(false)
 
       subscription.unsubscribe()
     })
@@ -1725,9 +1733,9 @@ describe(`localStorage collection`, () => {
       const storedData = mockStorage.getItem(`todos`)
       expect(storedData).toBeDefined()
       const parsed = JSON.parse(storedData!)
-      expect(parsed[`first`]).toBeUndefined()
-      expect(parsed[`second`]).toBeDefined()
-      expect(parsed[`third`]).toBeDefined()
+      expect(parsed[`s:first`]).toBeUndefined()
+      expect(parsed[`s:second`]).toBeDefined()
+      expect(parsed[`s:third`]).toBeDefined()
 
       subscription.unsubscribe()
     })