-
Notifications
You must be signed in to change notification settings - Fork 79
key all streams and remove keyBy #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e01f741 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aacb0da
to
fee9bbc
Compare
@tanstack/db-example-react-todo
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great refactor!
I think you need to update the PR body again?
This removes
keyBy
by ensuring all streams a keyed throughout a query, using a composite key for joins and keying on a composite of the groupBy values for when thats used.Joined keys are formed as
[${mainInputKey},${joinedInputKey}]
- so a key looks like:[123,234]
, or[123,[321,234]]
for multiple joins. This is implemented in the compiled pipeline by tanstack db query compiler.GroupBy uses a JSON front for the key with the key+values extracted for the groupBy - this is how the key works in the D2TS groupBy operator and is just exposed on the resulting pipeline.