Skip to content

Conversation

samwillis
Copy link
Collaborator

I tried to add a test to validate that a 409 didn't reach the onError handler, but it would require very complex mocking, and time is limited...

@samwillis samwillis requested a review from kevin-dp August 27, 2025 11:25
Copy link

changeset-bot bot commented Aug 27, 2025

🦋 Changeset detected

Latest commit: cb8ca29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tanstack/electric-db-collection Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Aug 27, 2025

More templates

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@460

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@460

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@460

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@460

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@460

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@460

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@460

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@460

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@460

commit: cb8ca29

Copy link
Contributor

Size Change: 0 B

Total Size: 64.4 kB

ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/change-events.js 1.13 kB
./packages/db/dist/esm/collection.js 10.6 kB
./packages/db/dist/esm/deferred.js 230 B
./packages/db/dist/esm/errors.js 3 kB
./packages/db/dist/esm/index.js 1.52 kB
./packages/db/dist/esm/indexes/auto-index.js 745 B
./packages/db/dist/esm/indexes/base-index.js 605 B
./packages/db/dist/esm/indexes/btree-index.js 1.74 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.25 kB
./packages/db/dist/esm/local-only.js 827 B
./packages/db/dist/esm/local-storage.js 2.03 kB
./packages/db/dist/esm/optimistic-action.js 294 B
./packages/db/dist/esm/proxy.js 4.19 kB
./packages/db/dist/esm/query/builder/functions.js 575 B
./packages/db/dist/esm/query/builder/index.js 3.79 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 890 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.48 kB
./packages/db/dist/esm/query/compiler/expressions.js 631 B
./packages/db/dist/esm/query/compiler/group-by.js 2.06 kB
./packages/db/dist/esm/query/compiler/index.js 2.15 kB
./packages/db/dist/esm/query/compiler/joins.js 2.36 kB
./packages/db/dist/esm/query/compiler/order-by.js 1.17 kB
./packages/db/dist/esm/query/compiler/select.js 655 B
./packages/db/dist/esm/query/ir.js 466 B
./packages/db/dist/esm/query/live-query-collection.js 333 B
./packages/db/dist/esm/query/live/collection-config-builder.js 2.51 kB
./packages/db/dist/esm/query/live/collection-subscriber.js 2.32 kB
./packages/db/dist/esm/query/optimizer.js 2.63 kB
./packages/db/dist/esm/SortedMap.js 1.24 kB
./packages/db/dist/esm/transactions.js 2.29 kB
./packages/db/dist/esm/utils.js 419 B
./packages/db/dist/esm/utils/btree.js 6.02 kB
./packages/db/dist/esm/utils/comparison.js 718 B
./packages/db/dist/esm/utils/index-optimization.js 1.62 kB

compressed-size-action::db-package-size

Copy link
Contributor

Size Change: 0 B

Total Size: 1.16 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 152 B
./packages/react-db/dist/esm/useLiveQuery.js 1.01 kB

compressed-size-action::react-db-package-size

Comment on lines +493 to +499
} else {
console.error(
`An error occurred while syncing collection: ${collection.id}, \n` +
`it has been marked as ready to avoid blocking apps waiting for '.preload()' to finish. \n` +
`You can provide an 'onError' handler on the shapeOptions to handle this error, and this message will not be logged.`,
errorParams
)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KyleAMathews I have added this logging here so that a user is alerted to the fact the collection has been marked ready on an error. You added the original code to do this and I wanted to check your thinking.

// Commit the truncate transaction immediately
commit()
transactionStarted = false
// Reset hasUpToDate so we continue accumulating changes until next up-to-date
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are no longer committing it here, when will it be committed and where?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the next up-to-date from electric, line 558 just below.

@samwillis samwillis merged commit 3905a9c into main Aug 27, 2025
6 checks passed
@samwillis samwillis deleted the samwillis/fix-electric-up-to-date branch August 27, 2025 14:49
@github-actions github-actions bot mentioned this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants