Fix optimized join missing results

[kevin-dp]

This PR fixes #494.

The problem was within the join optimization we were following the reference to the base collection but we were passing the active collection instead of the lazy collection. As a result, we were not finding the actual values in that collection because they are in the lazy collection.

[changeset-bot]

🦋 Changeset detected

Latest commit: f5bfa90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@tanstack/db	Patch
@tanstack/electric-db-collection	Patch
@tanstack/query-db-collection	Patch
@tanstack/react-db	Patch
@tanstack/solid-db	Patch
@tanstack/svelte-db	Patch
@tanstack/trailbase-db-collection	Patch
@tanstack/vue-db	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

More templates

• tanstack-start-db-projects-example
• @tanstack/db-example-react-todo
• @tanstack/db-example-solid-todo

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@501

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@501

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@501

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@501

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@501

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@501

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@501

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@501

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@501

commit: f5bfa90

[github-actions]

Size Change: -16 B (-0.02%)

Total Size: 65 kB

Filename	Size	Change
./packages/db/dist/esm/query/compiler/joins.js	2.35 kB	-16 B (-0.68%)

ℹ️ View Unchanged

Filename	Size
./packages/db/dist/esm/change-events.js	1.13 kB
./packages/db/dist/esm/collection.js	10.5 kB
./packages/db/dist/esm/deferred.js	230 B
./packages/db/dist/esm/errors.js	3.1 kB
./packages/db/dist/esm/index.js	1.52 kB
./packages/db/dist/esm/indexes/auto-index.js	745 B
./packages/db/dist/esm/indexes/base-index.js	605 B
./packages/db/dist/esm/indexes/btree-index.js	1.74 kB
./packages/db/dist/esm/indexes/lazy-index.js	1.25 kB
./packages/db/dist/esm/local-only.js	827 B
./packages/db/dist/esm/local-storage.js	2.03 kB
./packages/db/dist/esm/optimistic-action.js	294 B
./packages/db/dist/esm/proxy.js	3.87 kB
./packages/db/dist/esm/query/builder/functions.js	575 B
./packages/db/dist/esm/query/builder/index.js	3.83 kB
./packages/db/dist/esm/query/builder/ref-proxy.js	890 B
./packages/db/dist/esm/query/compiler/evaluators.js	1.48 kB
./packages/db/dist/esm/query/compiler/expressions.js	631 B
./packages/db/dist/esm/query/compiler/group-by.js	2.09 kB
./packages/db/dist/esm/query/compiler/index.js	2.16 kB
./packages/db/dist/esm/query/compiler/order-by.js	1.23 kB
./packages/db/dist/esm/query/compiler/select.js	655 B
./packages/db/dist/esm/query/ir.js	466 B
./packages/db/dist/esm/query/live-query-collection.js	333 B
./packages/db/dist/esm/query/live/collection-config-builder.js	2.58 kB
./packages/db/dist/esm/query/live/collection-subscriber.js	2.4 kB
./packages/db/dist/esm/query/optimizer.js	2.63 kB
./packages/db/dist/esm/SortedMap.js	1.24 kB
./packages/db/dist/esm/transactions.js	2.29 kB
./packages/db/dist/esm/utils.js	943 B
./packages/db/dist/esm/utils/btree.js	6.02 kB
./packages/db/dist/esm/utils/comparison.js	718 B
./packages/db/dist/esm/utils/index-optimization.js	1.62 kB

_{compressed-size-action::db-package-size}

[github-actions]

Size Change: 0 B

Total Size: 1.18 kB

ℹ️ View Unchanged

Filename	Size
./packages/react-db/dist/esm/index.js	152 B
./packages/react-db/dist/esm/useLiveQuery.js	1.02 kB

_{compressed-size-action::react-db-package-size}