Skip to content

Conversation

kevin-dp
Copy link
Contributor

@kevin-dp kevin-dp commented Oct 2, 2025

#623 fixes a bug with the indexes. As a result, we create separate indexes for ASC and DESC queries. This is suboptimal. This PR introduces a ReverseIndex such that if an index exist but it is in the wrong direction we reverse it. As a result, there's only one underlying index.

Copy link

changeset-bot bot commented Oct 2, 2025

🦋 Changeset detected

Latest commit: 5ddd939

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@tanstack/db Patch
@tanstack/angular-db Patch
@tanstack/electric-db-collection Patch
@tanstack/query-db-collection Patch
@tanstack/react-db Patch
@tanstack/rxdb-db-collection Patch
@tanstack/solid-db Patch
@tanstack/svelte-db Patch
@tanstack/trailbase-db-collection Patch
@tanstack/vue-db Patch
todos Patch
@tanstack/db-example-react-todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 2, 2025

More templates

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@627

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@627

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@627

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@627

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@627

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@627

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@627

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@627

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@627

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@627

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@627

commit: 5ddd939

Copy link
Contributor

github-actions bot commented Oct 2, 2025

Size Change: +848 B (+1.14%)

Total Size: 75.4 kB

Filename Size Change
./packages/db/dist/esm/collection/changes.js 1.01 kB -3 B (-0.3%)
./packages/db/dist/esm/collection/state.js 3.81 kB -4 B (-0.1%)
./packages/db/dist/esm/collection/sync.js 1.32 kB -99 B (-6.98%)
./packages/db/dist/esm/indexes/base-index.js 835 B +162 B (+24.07%) 🚨
./packages/db/dist/esm/indexes/btree-index.js 2.02 kB +171 B (+9.23%) 🔍
./packages/db/dist/esm/utils/index-optimization.js 1.73 kB +44 B (+2.61%)
./packages/db/dist/esm/indexes/reverse-index.js 577 B +577 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/collection/change-events.js 958 B
./packages/db/dist/esm/collection/events.js 683 B
./packages/db/dist/esm/collection/index.js 3.18 kB
./packages/db/dist/esm/collection/indexes.js 1.16 kB
./packages/db/dist/esm/collection/lifecycle.js 1.8 kB
./packages/db/dist/esm/collection/mutations.js 2.59 kB
./packages/db/dist/esm/collection/subscription.js 1.69 kB
./packages/db/dist/esm/deferred.js 230 B
./packages/db/dist/esm/errors.js 3.1 kB
./packages/db/dist/esm/index.js 1.56 kB
./packages/db/dist/esm/indexes/auto-index.js 806 B
./packages/db/dist/esm/indexes/lazy-index.js 1.25 kB
./packages/db/dist/esm/local-only.js 827 B
./packages/db/dist/esm/local-storage.js 2.02 kB
./packages/db/dist/esm/optimistic-action.js 294 B
./packages/db/dist/esm/proxy.js 3.87 kB
./packages/db/dist/esm/query/builder/functions.js 615 B
./packages/db/dist/esm/query/builder/index.js 3.93 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 938 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.56 kB
./packages/db/dist/esm/query/compiler/expressions.js 631 B
./packages/db/dist/esm/query/compiler/group-by.js 2.11 kB
./packages/db/dist/esm/query/compiler/index.js 2.04 kB
./packages/db/dist/esm/query/compiler/joins.js 2.54 kB
./packages/db/dist/esm/query/compiler/order-by.js 1.24 kB
./packages/db/dist/esm/query/compiler/select.js 1.28 kB
./packages/db/dist/esm/query/ir.js 785 B
./packages/db/dist/esm/query/live-query-collection.js 340 B
./packages/db/dist/esm/query/live/collection-config-builder.js 2.68 kB
./packages/db/dist/esm/query/live/collection-subscriber.js 1.91 kB
./packages/db/dist/esm/query/optimizer.js 3.1 kB
./packages/db/dist/esm/SortedMap.js 1.24 kB
./packages/db/dist/esm/transactions.js 3.03 kB
./packages/db/dist/esm/utils.js 1.01 kB
./packages/db/dist/esm/utils/browser-polyfills.js 365 B
./packages/db/dist/esm/utils/btree.js 6.02 kB
./packages/db/dist/esm/utils/comparison.js 754 B

compressed-size-action::db-package-size

Copy link
Contributor

github-actions bot commented Oct 2, 2025

Size Change: 0 B

Total Size: 1.44 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 152 B
./packages/react-db/dist/esm/useLiveQuery.js 1.29 kB

compressed-size-action::react-db-package-size

Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from index-asc-desc-bug to main October 3, 2025 16:13
@samwillis samwillis force-pushed the kevin/reverse-index branch from ed29a4d to 5ddd939 Compare October 3, 2025 16:15
@samwillis samwillis merged commit 5f43d5f into main Oct 3, 2025
6 checks passed
@samwillis samwillis deleted the kevin/reverse-index branch October 3, 2025 16:19
@github-actions github-actions bot mentioned this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants