Skip to content

Conversation

KyleAMathews
Copy link
Collaborator

Summary

  • build on fix concurrent mutation bug #629 by also letting optimistic recomputes fire while sync commits are still running, so long-lived offline transactions remain responsive
  • keep the batching tear-down and duplicate-insert tolerance from fix concurrent mutation bug #629 in the core collection bridge
  • add focused regression tests for concurrent inserts, queued optimistic updates, and the offline live-query path

Testing

  • pnpm vitest run packages/db/tests

Copy link

changeset-bot bot commented Oct 2, 2025

🦋 Changeset detected

Latest commit: 9dd34e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@tanstack/db Patch
@tanstack/angular-db Patch
@tanstack/electric-db-collection Patch
@tanstack/query-db-collection Patch
@tanstack/react-db Patch
@tanstack/rxdb-db-collection Patch
@tanstack/solid-db Patch
@tanstack/svelte-db Patch
@tanstack/trailbase-db-collection Patch
@tanstack/vue-db Patch
todos Patch
@tanstack/db-example-react-todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 2, 2025

More templates

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@631

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@631

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@631

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@631

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@631

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@631

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@631

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@631

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@631

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@631

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@631

commit: 9dd34e4

Copy link
Contributor

github-actions bot commented Oct 2, 2025

Size Change: +106 B (+0.14%)

Total Size: 74.2 kB

Filename Size Change
./packages/db/dist/esm/collection/changes.js 1.01 kB +3 B (+0.3%)
./packages/db/dist/esm/collection/state.js 3.82 kB +4 B (+0.1%)
./packages/db/dist/esm/collection/sync.js 1.42 kB +99 B (+7.5%) 🔍
ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/collection/change-events.js 958 B
./packages/db/dist/esm/collection/events.js 683 B
./packages/db/dist/esm/collection/index.js 3.14 kB
./packages/db/dist/esm/collection/indexes.js 1.16 kB
./packages/db/dist/esm/collection/lifecycle.js 1.8 kB
./packages/db/dist/esm/collection/mutations.js 2.59 kB
./packages/db/dist/esm/collection/subscription.js 1.69 kB
./packages/db/dist/esm/deferred.js 230 B
./packages/db/dist/esm/errors.js 3.1 kB
./packages/db/dist/esm/index.js 1.56 kB
./packages/db/dist/esm/indexes/auto-index.js 745 B
./packages/db/dist/esm/indexes/base-index.js 605 B
./packages/db/dist/esm/indexes/btree-index.js 1.82 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.25 kB
./packages/db/dist/esm/local-only.js 827 B
./packages/db/dist/esm/local-storage.js 2.02 kB
./packages/db/dist/esm/optimistic-action.js 294 B
./packages/db/dist/esm/proxy.js 3.87 kB
./packages/db/dist/esm/query/builder/functions.js 615 B
./packages/db/dist/esm/query/builder/index.js 3.93 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 938 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.56 kB
./packages/db/dist/esm/query/compiler/expressions.js 631 B
./packages/db/dist/esm/query/compiler/group-by.js 2.11 kB
./packages/db/dist/esm/query/compiler/index.js 2.04 kB
./packages/db/dist/esm/query/compiler/joins.js 2.54 kB
./packages/db/dist/esm/query/compiler/order-by.js 1.23 kB
./packages/db/dist/esm/query/compiler/select.js 1.28 kB
./packages/db/dist/esm/query/ir.js 785 B
./packages/db/dist/esm/query/live-query-collection.js 340 B
./packages/db/dist/esm/query/live/collection-config-builder.js 2.68 kB
./packages/db/dist/esm/query/live/collection-subscriber.js 1.91 kB
./packages/db/dist/esm/query/optimizer.js 3.1 kB
./packages/db/dist/esm/SortedMap.js 1.24 kB
./packages/db/dist/esm/transactions.js 3.03 kB
./packages/db/dist/esm/utils.js 943 B
./packages/db/dist/esm/utils/browser-polyfills.js 365 B
./packages/db/dist/esm/utils/btree.js 6.02 kB
./packages/db/dist/esm/utils/comparison.js 754 B
./packages/db/dist/esm/utils/index-optimization.js 1.62 kB

compressed-size-action::db-package-size

Copy link
Contributor

github-actions bot commented Oct 2, 2025

Size Change: 0 B

Total Size: 1.44 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 152 B
./packages/react-db/dist/esm/useLiveQuery.js 1.29 kB

compressed-size-action::react-db-package-size

Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this out ahead of a larger refactor. It solves the current bugs at the cost of introducing a little more complexity and special casing, but we can hopefully pull that all out in a planed refactor: #634

@samwillis samwillis merged commit 56b870b into main Oct 3, 2025
6 checks passed
@samwillis samwillis deleted the fix-live-query-optimistic branch October 3, 2025 16:15
@github-actions github-actions bot mentioned this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants