fix: use location.origin; remove localhost hardcoding #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace localhost/token URL in open-in-editor
|
removed unused variable making build test fail |
More templates
@tanstack/devtools
@tanstack/devtools-ui
@tanstack/devtools-vite
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/react-devtools
@tanstack/solid-devtools
commit: |
|
@akdlsz21 thanks for this! |
No problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using tanstack devtools on my local machine. During my project, some of my logic depended on hostname, so I usually develop using custom domains.
The tools started to break and I investigated and noticed that localhost was hardcoded.
DevTools hardcoded {scheme}://localhost:{port} for open-in-editor and related links, which broke in my setup where I routinely develop on custom domains/non-loopback hosts (and also impacts IPv6).
This PR replaces the hardcoded origin with location.origin so links respect the actual scheme/host/port in use; it fixed the failures I observed while keeping localhost behavior intact.
If this direction makes sense, I’m happy to add tests to prevent regressions.