Skip to content

fix: use location.origin; remove localhost hardcoding #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2025
+3 −14
Merged

fix: use location.origin; remove localhost hardcoding #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cabf398
use location.origin; make console links origin-aware
akdlsz21 Sep 13, 2025
cc5bcac
remove unused host variable and configResolved
akdlsz21 Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions packages/devtools-vite/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ export const defineDevtoolsConfig = (config: TanStackDevtoolsViteConfig) =>

export const devtools = (args?: TanStackDevtoolsViteConfig): Array<Plugin> => {
let port = 5173
let host = 'http'
const enhancedLogsConfig = args?.enhancedLogs ?? { enabled: true }
const injectSourceConfig = args?.injectSource ?? { enabled: true }
const bus = new ServerEventBus(args?.eventBusConfig)
Expand All @@ -71,9 +70,6 @@ export const devtools = (args?: TanStackDevtoolsViteConfig): Array<Plugin> => {
{
enforce: 'pre',
name: '@tanstack/devtools:custom-server',
configResolved(config) {
host = config.server.https?.cert ? 'https' : 'http'
},
apply(config) {
// Custom server is only needed in development for piping events to the client
return config.mode === 'development'
Expand Down Expand Up @@ -119,15 +115,6 @@ export const devtools = (args?: TanStackDevtoolsViteConfig): Array<Plugin> => {
}),
)
},
transform(code) {
if (code.includes('__TSD_PORT__')) {
code = code.replace('__TSD_PORT__', String(port))
}
if (code.includes('__TSD_HOST__')) {
code = code.replace('__TSD_HOST__', host)
}
return code
},
},
{
name: '@tanstack/devtools:better-console-logs',
Expand Down
4 changes: 3 additions & 1 deletion packages/devtools/src/devtools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,9 @@ export default function DevTools() {
e.preventDefault()
e.stopPropagation()
fetch(
`__TSD_HOST__://localhost:__TSD_PORT__/__tsd/open-source?source=${encodeURIComponent(dataSource)}`,
`${location.origin}/__tsd/open-source?source=${encodeURIComponent(
dataSource,
)}`,
).catch(() => {})
}
}
Expand Down
Loading