-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
chore(deps): update all non-major dependencies #9731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
WalkthroughBatched minor and patch dependency and devDependency version bumps across many example, integration, package, and root Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
Command | Status | Duration | Result |
---|---|---|---|
nx affected --targets=test:sherif,test:knip,tes... |
❌ Failed | 4m 4s | View ↗ |
nx run-many --target=build --exclude=examples/*... |
✅ Succeeded | 1m 20s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-10-09 23:05:26
UTC
Sizes for commit 2e9ad58:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (76)
examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(2 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-core/package.json
packages/react-query/package.json
packages/query-persist-client-core/package.json
packages/query-broadcast-client-experimental/package.json
packages/query-sync-storage-persister/package.json
packages/query-async-storage-persister/package.json
packages/svelte-query-devtools/package.json
integrations/solid-vite/package.json
packages/solid-query-persist-client/package.json
packages/svelte-query-persist-client/package.json
packages/react-query-next-experimental/package.json
packages/solid-query-devtools/package.json
packages/react-query-persist-client/package.json
packages/react-query-devtools/package.json
packages/svelte-query/package.json
integrations/react-vite/package.json
integrations/react-next-15/package.json
packages/angular-query-experimental/package.json
packages/angular-query-persist-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (17)
packages/solid-query-devtools/package.json (1)
68-72
: Solid devtool deps align with latest patches.The patched versions of
solid-js
,vite-plugin-solid
, andnpm-run-all2
stay within existing peer ranges and match the rest of the Solid workspace upgrades. Looks good.packages/query-devtools/package.json (1)
67-81
: Solid devtools stack remains coherent.The Solid-related tooling and styling packages now target the same 1.9.9/0.3.x patch line as the other packages in this PR, so the matrix stays consistent. No blockers spotted.
integrations/angular-cli-20/package.json (1)
11-26
: Angular example tracks 20.3.x baseline cleanly.The dependency set (framework, CLI/build, zone.js) now lines up with Angular 20.3.x, matching the other Angular examples. Nothing further needed.
package.json (1)
8-81
: Root tooling refresh looks safe.The pnpm bump plus lint/test/tooling updates remain within compatible ranges used across the repo. No regressions anticipated.
packages/query-broadcast-client-experimental/package.json (1)
62-68
: Broadcast client deps updated without surprises.
broadcast-channel
7.1.0 and the associated React tooling bumps are patch-level and align with the rest of the workspace.packages/angular-query-experimental/package.json (1)
92-103
: Angular devDeps synchronized with 20.3.x.Bringing the package’s dev tooling up to the 20.3.x line keeps it consistent with the integration and example apps. Everything remains within the existing peer requirements.
examples/react/eslint-legacy/package.json (1)
23-23
: React example tooling in sync.The plugin bump mirrors the other React examples, keeping the toolchain consistent. All good.
examples/react/playground/package.json (1)
17-17
: Playground matches the updated React toolchain.
@vitejs/plugin-react
is now aligned with the rest of the React examples. Looks solid.examples/react/shadow-dom/package.json (1)
19-19
: Upgrade aligns with current Vite tooling.Bumping
@vitejs/plugin-react
to^4.7.0
keeps this example in sync with the rest of the React demos and matches the Vite 6.3.x toolchain already declared. Looks good.examples/react/suspense/package.json (1)
19-19
: Consistent plugin bump.Updating
@vitejs/plugin-react
here to^4.7.0
stays aligned with the tooling stack used across the React examples, so this looks good.examples/react/simple/package.json (1)
17-17
: LGTM for the plugin update.The move to
@vitejs/plugin-react@^4.7.0
keeps this example consistent with the rest of the React suite and the current Vite major.examples/vue/basic/package.json (1)
16-16
: Vue plugin bump looks good.
@vitejs/plugin-vue
→^5.2.4
keeps this example aligned with the newer Vite 6.3.x stack; no concerns.examples/vue/simple/package.json (1)
16-16
: Consistent Vue tooling upgrade.Updating
@vitejs/plugin-vue
to^5.2.4
keeps this sample aligned with the other Vue examples and current Vite.examples/react/default-query-function/package.json (1)
17-17
: React plugin update verified.The
@vitejs/plugin-react
upgrade to^4.7.0
matches the rest of the project’s tooling updates—looks good here.examples/react/devtools-panel/package.json (1)
17-17
: Tooling bump confirmed.Moving
@vitejs/plugin-react
to^4.7.0
aligns this package with the updated toolchain across the React examples.examples/react/basic-graphql-request/package.json (2)
13-14
: GraphQL stack bump LGTM.
graphql@^16.11.0
andgraphql-request@^7.2.0
remain within the 16.x/7.x lines, so no breaking API changes are expected. Combined with the Vite React plugin bump, this keeps the example current.
19-19
: React plugin upgrade approved.The
@vitejs/plugin-react
update to^4.7.0
matches the rest of the repo’s tooling—looks good.
"expo": "^52.0.47", | ||
"expo-constants": "^17.1.7", | ||
"expo-status-bar": "^2.2.3", | ||
"react": "^19.0.0", | ||
"react-native": "^0.76.3", | ||
"react-native-gesture-handler": "^2.20.2", | ||
"react-native-paper": "^5.12.5", | ||
"react-native-reanimated": "^3.16.2", | ||
"react-native-safe-area-context": "^4.12.0", | ||
"react-native-screens": "^4.1.0", | ||
"react-native-web": "^0.19.13" | ||
"react-native": "^0.81.4", | ||
"react-native-gesture-handler": "^2.28.0", | ||
"react-native-paper": "^5.14.5", | ||
"react-native-reanimated": "^3.19.1", | ||
"react-native-safe-area-context": "^4.14.1", | ||
"react-native-screens": "^4.16.0", | ||
"react-native-web": "^0.21.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expo SDK 52 is tied to React Native 0.76.x—revert the 0.81.x bump.
Expo SDK 52 still ships with React Native 0.76.x. Setting "react-native": "^0.81.4"
(and matching ecosystem packages) will desynchronize the managed workflow and cause native builds to fail because Expo cannot provide the 0.81 toolchain. Please keep react-native
(and the dependent react-native-*
packages) on the Expo-supported 0.76.x line.
- "react-native": "^0.81.4",
- "react-native-gesture-handler": "^2.28.0",
- "react-native-paper": "^5.14.5",
- "react-native-reanimated": "^3.19.1",
- "react-native-safe-area-context": "^4.14.1",
- "react-native-screens": "^4.16.0",
- "react-native-web": "^0.21.1"
+ "react-native": "0.76.3",
+ "react-native-gesture-handler": "^2.16.2",
+ "react-native-paper": "^5.12.5",
+ "react-native-reanimated": "^3.10.1",
+ "react-native-safe-area-context": "^4.9.0",
+ "react-native-screens": "^3.31.1",
+ "react-native-web": "^0.19.12"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"expo": "^52.0.47", | |
"expo-constants": "^17.1.7", | |
"expo-status-bar": "^2.2.3", | |
"react": "^19.0.0", | |
"react-native": "^0.76.3", | |
"react-native-gesture-handler": "^2.20.2", | |
"react-native-paper": "^5.12.5", | |
"react-native-reanimated": "^3.16.2", | |
"react-native-safe-area-context": "^4.12.0", | |
"react-native-screens": "^4.1.0", | |
"react-native-web": "^0.19.13" | |
"react-native": "^0.81.4", | |
"react-native-gesture-handler": "^2.28.0", | |
"react-native-paper": "^5.14.5", | |
"react-native-reanimated": "^3.19.1", | |
"react-native-safe-area-context": "^4.14.1", | |
"react-native-screens": "^4.16.0", | |
"react-native-web": "^0.21.1" | |
"expo": "^52.0.47", | |
"expo-constants": "^17.1.7", | |
"expo-status-bar": "^2.2.3", | |
"react": "^19.0.0", | |
"react-native": "0.76.3", | |
"react-native-gesture-handler": "^2.16.2", | |
"react-native-paper": "^5.12.5", | |
"react-native-reanimated": "^3.10.1", | |
"react-native-safe-area-context": "^4.9.0", | |
"react-native-screens": "^3.31.1", | |
"react-native-web": "^0.19.12" |
🤖 Prompt for AI Agents
In examples/react/react-native/package.json around lines 19 to 29, the project
upgrades react-native (and related react-native-* packages) to a 0.81.x
ecosystem that is incompatible with Expo SDK 52; revert react-native to the
Expo-supported 0.76.x version and align the react-native-* package versions to
the matching releases for SDK 52 (restore versions known to ship with Expo SDK
52), update react (if needed) to the compatible version, then run package
install and validate with expo doctor / Expo build to ensure the managed
workflow is synchronized.
2c5f855
to
c1de76b
Compare
ff89619
to
d8a8586
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
examples/react/react-native/package.json (1)
19-29
: Expo SDK 52 is tied to React Native 0.76.x—0.81.x will break managed builds.Expo 52’s runtime ships with the React Native 0.76 toolchain. Jumping the example to
react-native
^0.81.4 (and the matchingreact-native-*
packages) desynchronizes the managed workflow—expo prebuild
/builds will fail because Expo cannot vend the 0.81 native binaries yet. Please keep the React Native stack on the Expo-supported 0.76 line until the SDK advances.- "expo": "^52.0.47", + "expo": "^52.0.47", - "react-native": "^0.81.4", - "react-native-gesture-handler": "^2.28.0", - "react-native-paper": "^5.14.5", - "react-native-reanimated": "^3.19.2", - "react-native-safe-area-context": "^4.14.1", - "react-native-screens": "^4.16.0", - "react-native-web": "^0.21.1" + "react-native": "0.76.3", + "react-native-gesture-handler": "^2.16.2", + "react-native-paper": "^5.12.5", + "react-native-reanimated": "^3.10.1", + "react-native-safe-area-context": "^4.9.0", + "react-native-screens": "^3.31.1", + "react-native-web": "^0.19.12"Also ensure any other Expo-managed packages stay aligned with the SDK’s pinned versions.
🧹 Nitpick comments (1)
examples/angular/optimistic-updates/package.json (1)
20-20
: Align version ranges for consistencyConsider using tilde ranges for patch updates (as in other Angular examples): zone.js "~0.15.1" and typescript "~5.8.3".
Also applies to: 26-26
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (76)
examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(2 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- examples/vue/basic/package.json
🚧 Files skipped from review as they are similar to previous changes (51)
- examples/solid/default-query-function/package.json
- packages/query-async-storage-persister/package.json
- packages/react-query-next-experimental/package.json
- examples/react/offline/package.json
- examples/angular/devtools-panel/package.json
- examples/vue/dependent-queries/package.json
- examples/svelte/simple/package.json
- examples/svelte/basic/package.json
- packages/solid-query-persist-client/package.json
- examples/vue/persister/package.json
- packages/react-query-devtools/package.json
- integrations/react-vite/package.json
- examples/angular/auto-refetching/package.json
- examples/react/simple/package.json
- examples/svelte/playground/package.json
- packages/query-core/package.json
- packages/svelte-query/package.json
- examples/svelte/auto-refetching/package.json
- examples/react/rick-morty/package.json
- examples/solid/basic-graphql-request/package.json
- packages/query-persist-client-core/package.json
- examples/solid/basic/package.json
- examples/angular/basic-persister/package.json
- examples/react/chat/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/router/package.json
- examples/angular/pagination/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/react/eslint-legacy/package.json
- examples/react/basic/package.json
- examples/react/default-query-function/package.json
- examples/solid/simple/package.json
- examples/solid/solid-start-streaming/package.json
- packages/eslint-plugin-query/package.json
- packages/vue-query/package.json
- examples/angular/rxjs/package.json
- packages/solid-query/package.json
- examples/react/react-router/package.json
- examples/vue/simple/package.json
- integrations/react-next-15/package.json
- examples/solid/astro/package.json
- examples/react/shadow-dom/package.json
- packages/react-query/package.json
- integrations/svelte-vite/package.json
- examples/svelte/optimistic-updates/package.json
- packages/svelte-query-devtools/package.json
- integrations/solid-vite/package.json
- examples/svelte/star-wars/package.json
- examples/react/suspense/package.json
- examples/react/star-wars/package.json
- packages/svelte-query-persist-client/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/angular-query-experimental/package.json
packages/react-query-persist-client/package.json
packages/solid-query-devtools/package.json
packages/query-broadcast-client-experimental/package.json
packages/angular-query-persist-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (6)
packages/angular-query-experimental/package.json (1)
92-104
: LGTM; workspace linkage and dev tooling updates look correctDev deps align with Angular 20; workspace dep on query-core is correctly declared.
packages/query-devtools/package.json (1)
67-81
: LGTM; Solid + tooling bumps are consistentMinor/patch upgrades; no API surface changes here.
package.json (1)
8-8
: Tooling upgrades and overrides look coherentVite 6 + Vitest 3 are aligned; TS matrix deps match package test scripts. Overrides centralize workspace resolution. Ship it.
Please run the full CI suite (nx affected) after merge to catch any latent peer-dep warnings introduced by the upgrades.
Also applies to: 43-82, 83-110
packages/query-test-utils/package.json (1)
38-38
: LGTM; routine bumpNo impact beyond scripts.
packages/solid-query-devtools/package.json (1)
68-72
: LGTM; versions align with peer rangesBumps are within supported peer ranges.
packages/query-broadcast-client-experimental/package.json (1)
61-68
: Confirm broadcast-channel SSR compatibility; no version mismatches
- @vitejs/plugin-react ^4.7.0 consistently pairs with Vite ^6.3.6 across all packages.
- broadcast-channel ^7.1.0 is scoped to this package; run SSR/tests to ensure ESM support.
"@angular/common": "^20.3.3", | ||
"@angular/compiler": "^20.3.3", | ||
"@angular/core": "^20.3.3", | ||
"@angular/forms": "^20.3.3", | ||
"@angular/platform-browser": "^20.3.3", | ||
"@angular/router": "^20.3.3", | ||
"@tanstack/angular-query-experimental": "^5.90.2", | ||
"rxjs": "~7.8.2", | ||
"tslib": "^2.8.1", | ||
"zone.js": "~0.15.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Angular 20 + TS/zone/rxjs compatibility check
Looks good. Please verify Angular 20.3.x supports Typescript 5.8 and zone.js 0.15.x to avoid peer warning noise.
Also applies to: 23-25
🌐 Web query:
Which TypeScript versions are officially supported by Angular 20.3.x, and what is the required zone.js version?
💡 Result:
- Supported TypeScript versions for Angular 20.3.x: ^20.19.0, ^22.12.0, ^24.0.0. [1]
- Required zone.js version: >=5.9.0 <6.0.0. [1]
Sources: Angular Version Compatibility table. [1]
Bump TypeScript and zone.js to Angular 20.3.x supported ranges
- In integrations/angular-cli-20/package.json (lines 11–20), update
"typescript"
to one of the supported versions (e.g.^22.12.0
or^24.0.0
). - Update
"zone.js"
to a version>=5.9.0 <6.0.0
to satisfy Angular 20.3.x peer requirements.
🤖 Prompt for AI Agents
In integrations/angular-cli-20/package.json around lines 11–20, update the
TypeScript and zone.js dependency entries to versions supported by Angular
20.3.x: add or replace the "typescript" entry with a supported range such as
"^22.12.0" or "^24.0.0", and update the "zone.js" entry to a version satisfying
>=5.9.0 <6.0.0 (e.g., "^5.9.0"); save the file and run npm/yarn install to
regenerate the lockfile.
8825f1a
to
f511a10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (1)
package.json (1)
43-82
: Add Node engines to root package.json
Vite 6 and ESLint 9 require Node 18+. Prevent unsupported installs by declaring engines in the root manifest:"type": "module", + "engines": { + "node": ">=18.18.0" + },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (76)
examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(2 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- examples/solid/basic-graphql-request/package.json
- integrations/vue-vite/package.json
- packages/query-sync-storage-persister/package.json
🚧 Files skipped from review as they are similar to previous changes (55)
- integrations/svelte-vite/package.json
- examples/vue/persister/package.json
- examples/react/devtools-panel/package.json
- packages/react-query-next-experimental/package.json
- examples/react/default-query-function/package.json
- examples/svelte/playground/package.json
- examples/svelte/simple/package.json
- examples/react/react-native/package.json
- examples/svelte/star-wars/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/eslint-plugin-query/package.json
- examples/solid/astro/package.json
- examples/angular/simple/package.json
- examples/vue/basic/package.json
- examples/angular/query-options-from-a-service/package.json
- integrations/solid-vite/package.json
- examples/solid/default-query-function/package.json
- examples/svelte/basic/package.json
- packages/query-persist-client-core/package.json
- examples/vue/simple/package.json
- examples/react/playground/package.json
- packages/angular-query-experimental/package.json
- packages/react-query-persist-client/package.json
- examples/angular/devtools-panel/package.json
- packages/query-core/package.json
- packages/svelte-query-persist-client/package.json
- packages/svelte-query/package.json
- packages/svelte-query-devtools/package.json
- examples/react/react-router/package.json
- packages/solid-query-persist-client/package.json
- examples/angular/basic-persister/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- integrations/angular-cli-20/package.json
- examples/svelte/auto-refetching/package.json
- packages/vue-query/package.json
- examples/react/chat/package.json
- examples/react/star-wars/package.json
- packages/react-query/package.json
- examples/react/rick-morty/package.json
- packages/solid-query-devtools/package.json
- examples/angular/rxjs/package.json
- examples/solid/basic/package.json
- examples/react/eslint-legacy/package.json
- packages/solid-query/package.json
- integrations/react-webpack-4/package.json
- examples/solid/solid-start-streaming/package.json
- examples/svelte/optimistic-updates/package.json
- examples/svelte/ssr/package.json
- examples/angular/basic/package.json
- integrations/react-vite/package.json
- examples/angular/optimistic-updates/package.json
- integrations/react-webpack-5/package.json
- examples/vue/nuxt3/package.json
- packages/query-devtools/package.json
- examples/react/basic/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-async-storage-persister/package.json
packages/query-broadcast-client-experimental/package.json
packages/react-query-devtools/package.json
packages/angular-query-persist-client/package.json
integrations/react-next-15/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (17)
packages/query-test-utils/package.json (1)
37-39
: npm-run-all2 patch bump is safe.examples/react/shadow-dom/package.json (1)
18-22
: Looks consistent with React 19 setup.examples/react/suspense/package.json (1)
18-22
: All @vitejs/plugin-react versions updated to ^4.7.0 across the repo.examples/react/simple/package.json (1)
16-20
: Confirmed consistent plugin version across React examples
All examples underexamples/react
use@vitejs/plugin-react
^4.7.0
; no changes needed.examples/vue/dependent-queries/package.json (1)
14-18
: Vue plugin bump is consistent across all Vue examples.integrations/react-next-15/package.json (1)
8-16
: Ensure SSR bundling of Temporal polyfill in server components
Imports of@js-temporal/polyfill
found inmake-query-client.ts
andapp/page.tsx
(server components). Verify Next 15 bundles the polyfill correctly and doesn’t inflate your server bundle. If this should be client-only, move the import into a client module or add"use client"
.examples/react/algolia/package.json (1)
18-22
: Align React type packages with React 19.Update devDependencies in examples/react/algolia/package.json:
- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.1", + "@types/react-dom": "^19.0.2",Also verify that @algolia/client-search@5.40.0 introduces no Node/ESM breaking changes for Vite 6.
examples/solid/simple/package.json (1)
11-20
: Solid deps and plugin compatibility verified
vite-plugin-solid@2.11.9
peerDependencies includevite:^6.0.0
.packages/query-async-storage-persister/package.json (1)
67-67
: LGTM: dev tooling bump onlynpm-run-all2 ^5.0.2 looks good. Workspace deps on query-core and persist-client-core are present as required.
Based on learnings
packages/react-query-devtools/package.json (1)
86-86
: LGTM: dev/test/tooling upgrades
- @testing-library/react ^16.3.0, @vitejs/plugin-react ^4.7.0, npm-run-all2 ^5.0.2: reasonable and aligned with repo-wide bumps.
- Peer deps remain React ^18 || ^19; @types/react ^19.0.1 matches.
Also applies to: 88-89
examples/react/offline/package.json (1)
16-16
: MSW, Hot Toast & Vite plugin: manual validation required
- Confirm MSW’s workerDirectory config in your Vite setup and that the dev worker is generated/served.
- Sanity-check react-hot-toast UI flows in the offline demo.
- Verify @vitejs/plugin-react ^4.7.0 runs smoothly with Vite ^6.3.6 (no build/runtime errors).
examples/react/basic-graphql-request/package.json (1)
13-14
: Compatibility check: graphql-request and Vite React plugin
- Confirm graphql ^16.11.0 with graphql-request ^7.2.0 installs without peer warnings and that GraphQL queries compile.
- @vitejs/plugin-react@4.7.0 peer-deps include
"vite": "^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0"
, so Vite ^6.3.6 is supported.packages/angular-query-persist-client/package.json (1)
60-65
: Angular devDeps upgrade approved: TS compatibility confirmed Root typescript@5.8.3 satisfies Angular 20.3.3’s peerDependency (>=5.8 <6.0).packages/query-broadcast-client-experimental/package.json (2)
61-63
: Check CJS compatibility for broadcast-channel 7.1If broadcast-channel is ESM-only, ensure the legacy CJS entry doesn’t require it unbundled. Either bundle it for CJS via tsup or load via dynamic import to avoid require() failures. Please verify.
Would you like a tsup config snippet to force bundling for CJS only?
65-67
: DevDeps alignment looks good; verify test env@vitejs/plugin-react ^4.7 pairs with Vite 6 and @testing-library/react ^16 fits React 19. Looks consistent. Please confirm local tests still pass across Node versions you support.
package.json (2)
83-110
: Overrides block LGTM; enforces workspace resolutionGood use of pnpm overrides to pin all TanStack packages to workspace:* ensuring local linking and consistency. This aligns with the need for workspace:* on intra‑repo deps.
Based on learnings
8-8
: Align CI/tooling with pnpm@10.18.1
Ensure CI installs or pins pnpm 10.18.1 (e.g. viacorepack prepare pnpm@10.18.1 --activate
or by usingactions/setup-node
withcache: pnpm
) to match yourpackageManager
setting and avoid lockfile/install mismatches.
"@angular/common": "^20.3.3", | ||
"@angular/compiler": "^20.3.3", | ||
"@angular/core": "^20.3.3", | ||
"@angular/platform-browser": "^20.3.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Validate Angular–TypeScript compatibility
Same as other Angular examples: Angular 20.3.x with TS 5.8.3 may be out of the supported range. Please confirm CLI/build 20.3.5 accepts TS 5.8.3.
Also applies to: 19-19, 22-24
🌐 Web query:
For Angular 20.3.x, what is the allowed TypeScript version range per @angular/cli 20.3.5 peerDependencies?
💡 Result:
Allowed TypeScript range: >=5.9.0 <6.0.0. [1]
Sources:
[1] Angular version compatibility (shows TypeScript range for v20.2.x / 20.3.x).
Bump TypeScript in examples/angular/auto-refetching/package.json to >=5.9.0. @angular/cli 20.3.x requires TypeScript >=5.9.0 <6.0.0.
🤖 Prompt for AI Agents
In examples/angular/auto-refetching/package.json around lines 12 to 15, the
project must require TypeScript >=5.9.0 to satisfy @angular/cli 20.3.x; update
package.json to add or bump the TypeScript entry (typically under
devDependencies) to a range that satisfies Angular such as "^5.9.0" (which
enforces >=5.9.0 and <6.0.0), then run npm/yarn install to update lockfile.
"@angular/common": "^20.3.3", | ||
"@angular/compiler": "^20.3.3", | ||
"@angular/core": "^20.3.3", | ||
"@angular/platform-browser": "^20.3.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Angular 20.3.x may constrain TypeScript versions
Angular CLI/build often enforces a specific TS range. You have Angular 20.3.x + zone.js 0.15.1, but TypeScript is pinned to 5.8.3. Please verify this combo is supported by @angular/cli/build 20.3.5.
Also applies to: 19-19, 22-24
🏁 Script executed:
#!/bin/bash
# Review all Angular example TypeScript pins to spot mismatches.
fd -t f package.json examples/angular | while read -r f; do
ts=$(jq -r '.devDependencies.typescript // empty' "$f")
if [ -n "$ts" ]; then echo "$f => typescript@$ts"; fi
done
Length of output: 710
🌐 Web query:
Which TypeScript versions are supported by Angular 20.3.x (CLI/build 20.3.5)?
💡 Result:
Angular 20.3.x supports TypeScript >=5.9.0 and <6.0.0 (i.e. the TypeScript 5.9.x range). [1][2]
Sources:
- Angular version compatibility table. [1]
- angular/cli release notes: "TypeScript versions older than 5.9 are no longer supported." [2]
Bump TypeScript to ≥5.9 <6.0 in Angular 20.3.x examples
Angular 20.3.x requires TS >= 5.9.0 < 6.0.0 but all examples pin 5.8.3—update devDependencies.typescript in examples/angular/*/package.json
.
🤖 Prompt for AI Agents
In examples/angular/pagination/package.json around lines 12 to 15, the Angular
20.3.x example requires TypeScript >=5.9.0 <6.0.0 but the package.json pins TS
to 5.8.3; update devDependencies.typescript to a compatible range (for example
"typescript": ">=5.9.0 <6.0.0" or "^5.9.0") so it satisfies Angular's
requirement, then run the package manager (npm/yarn/pnpm) to update lockfiles
and verify the project builds.
examples/angular/router/package.json
Outdated
"@angular/common": "^20.3.3", | ||
"@angular/compiler": "^20.3.3", | ||
"@angular/core": "^20.3.3", | ||
"@angular/platform-browser": "^20.3.3", | ||
"@angular/router": "^20.3.3", | ||
"@tanstack/angular-query-experimental": "^5.90.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Check Angular 20.3.x with TS 5.8.3
Router example also pins TS 5.8.3. Please confirm Angular CLI/build 20.3.5 supports this TS version to avoid install/build errors.
Also applies to: 20-20, 23-25
🌐 Web query:
Does @angular/cli 20.3.5 support TypeScript 5.8.x, and what is the exact peer range?
💡 Result:
Short answer: No — @angular/cli 20.3.x requires TypeScript >=5.9.0 and <6.0.0, so 5.8.x is outside the peer range. [1]
Source: Angular version compatibility table. [1]
Upgrade TypeScript to ≥5.9.0: @angular/cli 20.3.x requires TS ≥5.9.0 <6.0.0; the current pin of 5.8.3 in examples/angular/router/package.json (lines 12–17) is unsupported and will cause install/build errors.
🤖 Prompt for AI Agents
In examples/angular/router/package.json around lines 12 to 17, the project is
pinned to TypeScript 5.8.3 which is incompatible with @angular/cli 20.3.x;
update the TypeScript devDependency to a version >=5.9.0 and <6.0.0 (for example
"^5.9.0"), then run npm/yarn install to update lockfile, verify tsconfig.json
and any strict/compat flags still work with TS 5.9, and re-run the build/tests
to ensure no regressions.
13e7fff
to
e84b68b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
♻️ Duplicate comments (3)
examples/angular/pagination/package.json (1)
12-25
: Update TypeScript to meet Angular 20.3.x requirements.Angular 20.3.x toolchain drops support for TypeScript 5.8.x; builds fail unless TS is upgraded to ≥5.9.0 and <6.0.0. Please bump the
typescript
devDependency accordingly (e.g."typescript": "^5.9.0"
), then refresh the lockfile."devDependencies": { "@angular/build": "^20.3.5", "@angular/cli": "^20.3.5", "@angular/compiler-cli": "^20.3.3", - "typescript": "5.8.3" + "typescript": "^5.9.0" }examples/angular/auto-refetching/package.json (1)
22-26
: Upgrade TypeScript for Angular 20.3.x compatibility
@angular/cli
20.3.5 declares a peer range of TypeScript >=5.9.0 <6.0.0, so the current pin at 5.8.3 will fail installs/builds. Please bump TypeScript accordingly (e.g.^5.9.0
) and regenerate the lockfile.Apply this diff:
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/router/package.json (1)
22-26
: Raise TypeScript version for Angular 20.3.x@angular/cli 20.3.5 requires TypeScript >=5.9.0 and <6.0.0. The 5.8.3 pin violates this peer constraint. Please upgrade (e.g.
^5.9.0
) and refresh the lockfile.- "typescript": "5.8.3" + "typescript": "^5.9.0"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (76)
examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(2 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/query-test-utils/package.json
🚧 Files skipped from review as they are similar to previous changes (50)
- examples/angular/infinite-query-with-max-pages/package.json
- packages/query-core/package.json
- integrations/angular-cli-20/package.json
- packages/eslint-plugin-query/package.json
- examples/vue/persister/package.json
- examples/react/simple/package.json
- integrations/react-webpack-4/package.json
- integrations/react-vite/package.json
- examples/svelte/basic/package.json
- examples/react/chat/package.json
- examples/solid/simple/package.json
- integrations/react-next-15/package.json
- examples/angular/rxjs/package.json
- examples/solid/default-query-function/package.json
- examples/solid/solid-start-streaming/package.json
- examples/vue/basic/package.json
- packages/react-query-next-experimental/package.json
- packages/svelte-query-persist-client/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/basic-persister/package.json
- examples/vue/dependent-queries/package.json
- packages/query-persist-client-core/package.json
- packages/react-query-persist-client/package.json
- examples/react/default-query-function/package.json
- examples/svelte/simple/package.json
- integrations/svelte-vite/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/react-query/package.json
- examples/react/rick-morty/package.json
- examples/react/devtools-panel/package.json
- packages/vue-query/package.json
- examples/vue/nuxt3/package.json
- examples/angular/simple/package.json
- examples/solid/basic-graphql-request/package.json
- examples/react/react-router/package.json
- packages/angular-query-persist-client/package.json
- packages/svelte-query-devtools/package.json
- examples/react/react-native/package.json
- examples/svelte/auto-refetching/package.json
- packages/query-devtools/package.json
- packages/react-query-devtools/package.json
- examples/svelte/ssr/package.json
- examples/react/playground/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/playground/package.json
- examples/svelte/optimistic-updates/package.json
- examples/react/eslint-legacy/package.json
- examples/react/star-wars/package.json
- examples/react/offline/package.json
- examples/react/basic/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
integrations/solid-vite/package.json
packages/query-broadcast-client-experimental/package.json
packages/svelte-query/package.json
packages/solid-query-devtools/package.json
packages/query-async-storage-persister/package.json
packages/angular-query-experimental/package.json
packages/solid-query-persist-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
"@angular/build": "^20.3.5", | ||
"@angular/cli": "^20.3.5", | ||
"@angular/compiler-cli": "^20.3.3", | ||
"typescript": "5.8.3" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align TypeScript with Angular CLI peer requirements
Angular 20.3.5 tooling requires TypeScript >=5.9.0 <6.0.0. Keeping 5.8.3 breaks peer resolution and build. Please bump to a supported range like ^5.9.0
and refresh the lockfile.
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.3", | |
"typescript": "5.8.3" | |
} | |
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.3", | |
"typescript": "^5.9.0" | |
} |
🤖 Prompt for AI Agents
In examples/angular/basic/package.json around lines 22 to 26, the TypeScript
version is pinned to 5.8.3 which conflicts with Angular CLI 20.3.5 peer
requirements; update the "typescript" entry to a supported range such as
"^5.9.0" (or ">=5.9.0 <6.0.0") and then regenerate the lockfile by running the
package manager install (e.g., npm install or pnpm install) to update
package-lock.json / pnpm-lock.yaml accordingly.
"devDependencies": { | ||
"@angular/build": "^20.0.0", | ||
"@angular/cli": "^20.0.0", | ||
"@angular/compiler-cli": "^20.0.0", | ||
"@angular/build": "^20.3.5", | ||
"@angular/cli": "^20.3.5", | ||
"@angular/compiler-cli": "^20.3.3", | ||
"typescript": "5.8.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update TypeScript to satisfy Angular 20.3.x
With @angular/cli/build 20.3.5, TypeScript 5.8.3 is outside the supported peer range (>=5.9.0 <6.0.0). Please bump to a compatible version—^5.9.0
is sufficient—and update the lockfile.
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"devDependencies": { | |
"@angular/build": "^20.0.0", | |
"@angular/cli": "^20.0.0", | |
"@angular/compiler-cli": "^20.0.0", | |
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.3", | |
"typescript": "5.8.3" | |
"devDependencies": { | |
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.3", | |
"typescript": "^5.9.0" |
🤖 Prompt for AI Agents
In examples/angular/devtools-panel/package.json around lines 22 to 26, the
devDependency for TypeScript is pinned to "5.8.3" which is incompatible with
Angular 20.3.x; change the TypeScript entry to a compatible range (for example
"^5.9.0"), then run your package manager to update the lockfile (npm install or
yarn install) so the lockfile reflects the new version; commit both the
package.json and the updated lockfile.
"devDependencies": { | ||
"@angular/build": "^20.0.0", | ||
"@angular/cli": "^20.0.0", | ||
"@angular/compiler-cli": "^20.0.0", | ||
"@angular/build": "^20.3.5", | ||
"@angular/cli": "^20.3.5", | ||
"@angular/compiler-cli": "^20.3.3", | ||
"typescript": "5.8.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump TypeScript to the Angular 20.3.x supported range
Angular CLI/build 20.3.5 peers against TypeScript >=5.9.0 <6.0.0. The existing 5.8.3 pin will trigger peer install errors. Please raise it (e.g. ^5.9.0
) and re-lock dependencies.
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"devDependencies": { | |
"@angular/build": "^20.0.0", | |
"@angular/cli": "^20.0.0", | |
"@angular/compiler-cli": "^20.0.0", | |
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.3", | |
"typescript": "5.8.3" | |
"devDependencies": { | |
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.3", | |
"typescript": "^5.9.0" |
🤖 Prompt for AI Agents
In examples/angular/optimistic-updates/package.json around lines 22 to 26, the
devDependency pin for TypeScript is 5.8.3 which is incompatible with Angular
20.3.x; update the TypeScript entry to a range that satisfies Angular's peer
requirement (e.g. "^5.9.0") and then regenerate the lockfile (run npm install or
yarn install) so the lockfile reflects the new version.
e84b68b
to
2e2243e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
♻️ Duplicate comments (5)
examples/react/react-native/package.json (1)
19-29
: Expo SDK 52 is not compatible with React Native 0.82.x—align RN to Expo’s supported version.Expo SDK 52 ships on the RN 0.76.x line. Using
"react-native": "^0.82.0"
(and matching ecosystem libs) will desync the managed workflow and break builds. Align all RN-related deps to Expo 52’s supported set (useexpo install
to auto-resolve).Suggested direction:
- Revert react-native to 0.76.x and align gesture-handler, reanimated, screens, safe-area, web, etc., to Expo 52-compatible versions.
- Run
npx expo install
andnpx expo-doctor
to confirm sync.Please confirm the mapping via docs:
Which React Native version is used by Expo SDK 52, and what are the compatible versions of react-native-reanimated, react-native-gesture-handler, react-native-screens, and react-native-safe-area-context for SDK 52?
integrations/angular-cli-20/package.json (1)
23-27
: Verify TypeScript/zone.js/rxjs peer compatibility with Angular 20.3.x.Typescript is set to ~5.8.2. Please confirm it satisfies @angular/compiler-cli@20.3.4’s TS peer range, and that zone.js/rxjs satisfy @angular/core@20.3.4 peers, to avoid install-time peer warnings.
Run this script from repo root; it fetches peer ranges from npm registry and checks against this package.json:
#!/bin/bash set -euo pipefail PKG="integrations/angular-cli-20/package.json" # Local declared versions (strip leading ^/~ for concrete check) TS_VER=$(jq -r '.devDependencies.typescript // empty' "$PKG" | sed 's/^[~^]//') ZONE_VER=$(jq -r '.dependencies["zone.js"] // empty' "$PKG" | sed 's/^[~^]//') RXJS_VER=$(jq -r '.dependencies.rxjs // empty' "$PKG" | sed 's/^[~^]//') # Angular versions used here NG_CORE_VER=$(jq -r '.dependencies["@angular/core"]' "$PKG" | sed 's/^[~^]//') NG_COMPILER_CLI_VER=$(jq -r '.devDependencies["@angular/compiler-cli"]' "$PKG" | sed 's/^[~^]//') echo "Checking against:" echo " @angular/core@$NG_CORE_VER (zone.js, rxjs peers)" echo " @angular/compiler-cli@$NG_COMPILER_CLI_VER (typescript peer)" echo "Local:" echo " typescript $TS_VER | zone.js $ZONE_VER | rxjs $RXJS_VER" echo # Fetch peer ranges from npm registry CORE_JSON=$(curl -sSfL "https://registry.npmjs.org/@angular/core/$NG_CORE_VER") CLI_JSON=$(curl -sSfL "https://registry.npmjs.org/@angular/compiler-cli/$NG_COMPILER_CLI_VER") TS_PEER=$(jq -r '.peerDependencies.typescript // empty' <<<"$CLI_JSON") ZONE_PEER=$(jq -r '.peerDependencies["zone.js"] // empty' <<<"$CORE_JSON") RXJS_PEER=$(jq -r '.peerDependencies.rxjs // empty' <<<"$CORE_JSON") echo "Peer ranges:" echo " typescript: $TS_PEER" echo " zone.js: $ZONE_PEER" echo " rxjs: $RXJS_PEER" echo python - <<'PY' import os, sys, json from pathlib import Path def getenv(k): v=os.environ.get(k); if not v: print(f"Missing env {k}", file=sys.stderr); sys.exit(1) return v # Read env via heredoc printed above? We'll pass via temp file? Simpler: read from prior echo? Not available. # Instead, read again in Python from env vars by re-parsing shell outputs isn't trivial. # We'll pass values via environment. PYRe-run with environment passing for Python compatibility checks:
#!/bin/bash set -euo pipefail export TS_VER=$(jq -r '.devDependencies.typescript // empty' integrations/angular-cli-20/package.json | sed 's/^[~^]//') export ZONE_VER=$(jq -r '.dependencies["zone.js"] // empty' integrations/angular-cli-20/package.json | sed 's/^[~^]//') export RXJS_VER=$(jq -r '.dependencies.rxjs // empty' integrations/angular-cli-20/package.json | sed 's/^[~^]//') export TS_PEER=$(curl -sSfL "https://registry.npmjs.org/@angular/compiler-cli/$(jq -r '.devDependencies["@angular/compiler-cli"]' integrations/angular-cli-20/package.json | sed 's/^[~^]//')" | jq -r '.peerDependencies.typescript // empty') export ZONE_PEER=$(curl -sSfL "https://registry.npmjs.org/@angular/core/$(jq -r '.dependencies["@angular/core"]' integrations/angular-cli-20/package.json | sed 's/^[~^]//')" | jq -r '.peerDependencies["zone.js"] // empty') export RXJS_PEER=$(curl -sSfL "https://registry.npmjs.org/@angular/core/$(jq -r '.dependencies["@angular/core"]' integrations/angular-cli-20/package.json | sed 's/^[~^]//')" | jq -r '.peerDependencies.rxjs // empty') python - <<'PY' import os, sys try: import semver except ImportError: # install node-style semver import subprocess, sys as _sys subprocess.check_call([_sys.executable, "-m", "pip", "install", "semver>=3.0.2"], stdout=subprocess.DEVNULL) import semver def check(name, version, range_): if not version or not range_: print(f"[WARN] {name}: missing version or peer range (version={version!r}, peer={range_!r})") return True ok = semver.VersionInfo.isvalid(version) and semver.match(version, range_) status = "OK " if ok else "FAIL" print(f"[{status}] {name}: {version} satisfies '{range_}'") return ok ok = True ok &= check("TypeScript", os.environ.get("TS_VER",""), os.environ.get("TS_PEER","")) ok &= check("zone.js", os.environ.get("ZONE_VER",""), os.environ.get("ZONE_PEER","")) ok &= check("rxjs", os.environ.get("RXJS_VER",""), os.environ.get("RXJS_PEER","")) sys.exit(0 if ok else 1) PYIf any check fails, consider bumping TypeScript or adjusting zone.js/rxjs to satisfy Angular 20.3.x peer requirements.
</blockquote></details> <details> <summary>examples/angular/devtools-panel/package.json (1)</summary><blockquote> `22-26`: **TypeScript version incompatible with Angular 20.3.x toolchain (duplicate)** This was already raised: bump TS to satisfy @angular/cli/build 20.3.5 peers and update the lockfile. Suggested change: ```diff - "typescript": "5.8.3" + "typescript": "^5.9.0"
Optional: verify the exact TS peer range:
What TypeScript versions are supported by Angular CLI/build 20.3.x?
examples/angular/optimistic-updates/package.json (1)
22-26
: TypeScript pin incompatible with Angular 20.3.x (duplicate)Previously noted: upgrade TS to satisfy @angular/cli/build 20.3.5 peers; refresh lockfile.
- "typescript": "5.8.3" + "typescript": "^5.9.0"Optional verification:
What TypeScript versions are supported by Angular CLI/build 20.3.x?
examples/angular/basic/package.json (1)
22-26
: Upgrade TypeScript to match Angular 20.3.5 peers (duplicate)This was already reported: TS 5.8.3 is incompatible with the updated Angular tooling. Bump and re-lock.
- "typescript": "5.8.3" + "typescript": "^5.9.0"Optional verification:
What TypeScript versions are supported by Angular CLI/build 20.3.x?
🧹 Nitpick comments (1)
integrations/react-webpack-5/package.json (1)
14-16
: Declare Node engine compatibility
integrations/react-webpack-5/package.json lacks anengines.node
field. Babel 7.28 requires Node ≥14; add"engines": { "node": ">=14" }
(or a stricter minimum) or confirm your CI uses a matching Node version.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (76)
examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(2 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (45)
- examples/solid/basic-graphql-request/package.json
- examples/vue/simple/package.json
- examples/angular/auto-refetching/package.json
- examples/svelte/ssr/package.json
- integrations/svelte-vite/package.json
- packages/solid-query-devtools/package.json
- examples/react/basic-graphql-request/package.json
- examples/solid/astro/package.json
- examples/react/devtools-panel/package.json
- examples/svelte/auto-refetching/package.json
- packages/solid-query/package.json
- examples/svelte/simple/package.json
- examples/react/default-query-function/package.json
- packages/query-test-utils/package.json
- examples/react/rick-morty/package.json
- packages/query-devtools/package.json
- examples/react/react-router/package.json
- examples/angular/simple/package.json
- examples/react/playground/package.json
- examples/react/offline/package.json
- examples/react/chat/package.json
- packages/react-query-persist-client/package.json
- examples/react/algolia/package.json
- examples/angular/pagination/package.json
- examples/vue/persister/package.json
- packages/eslint-plugin-query/package.json
- packages/query-async-storage-persister/package.json
- examples/solid/simple/package.json
- packages/react-query-next-experimental/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/svelte-query-persist-client/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/basic/package.json
- examples/react/star-wars/package.json
- packages/svelte-query-devtools/package.json
- packages/query-persist-client-core/package.json
- packages/angular-query-experimental/package.json
- examples/react/suspense/package.json
- packages/angular-query-persist-client/package.json
- integrations/solid-vite/package.json
- examples/react/eslint-legacy/package.json
- package.json
- examples/angular/router/package.json
- examples/svelte/basic/package.json
- packages/react-query-devtools/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-core/package.json
integrations/react-vite/package.json
packages/react-query/package.json
packages/svelte-query/package.json
packages/query-sync-storage-persister/package.json
packages/solid-query-persist-client/package.json
integrations/react-next-15/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (23)
integrations/react-webpack-4/package.json (1)
14-17
: Babel/loader bumps look compatible with webpack 4; proceed.babel-loader 8.4.1 still supports webpack 4, and the Babel preset bumps are safe. Build should remain stable.
One ask: your script uses --openssl-legacy-provider (a webpack 4 workaround) which may fail on Node 22+. Ensure CI runs Node 18/20 or gate the flag.
packages/query-core/package.json (1)
63-63
: Dev-only bump looks good.npm-run-all2 ^5.0.2 aligns with scripts using npm-run-all. No runtime/API impact.
packages/query-sync-storage-persister/package.json (1)
67-67
: LGTM: tooling bump only.npm-run-all2 -> ^5.0.2; package already declares "@tanstack/query-core": "workspace:*" as required.
Based on learnings
packages/svelte-query/package.json (1)
55-63
: Svelte tooling updates approved.Dev-only version bumps; peer range remains compatible. No API changes.
packages/solid-query-persist-client/package.json (1)
73-77
: Solid ecosystem devDeps bumped; looks good.Matches peer compatibility; no runtime/export changes.
packages/react-query/package.json (1)
73-79
: React package dev/test tooling bumps approved.Non-runtime changes; React peer range remains ^18 || ^19.
integrations/react-vite/package.json (1)
11-11
: LGTM: Plugin bump matches React 19 / Vite 6 usage.@vitejs/plugin-react ^4.7.0 is appropriate here.
examples/vue/basic/package.json (1)
16-16
: LGTM: @vitejs/plugin-vue minor bump.No behavior impact for the example; safe update.
integrations/vue-vite/package.json (1)
13-13
: LGTM: @vitejs/plugin-vue -> ^5.2.4.Consistent with other Vue examples/integrations.
examples/vue/dependent-queries/package.json (1)
15-15
: LGTM: Aligns plugin-vue version with the repo.No runtime changes implied.
examples/vue/nuxt3/package.json (1)
13-13
: LGTM: Nuxt ^3.19.3.Looks fine for the example. Ensure Node version satisfies Nuxt engines.
examples/react/simple/package.json (1)
17-17
: LGTM: @vitejs/plugin-react -> ^4.7.0.Matches other React examples and Vite 6.
examples/react/shadow-dom/package.json (1)
19-19
: LGTM: @vitejs/plugin-react bump.Consistent across React examples.
integrations/react-webpack-5/package.json (1)
18-18
: html-webpack-plugin patch bump is compatible with webpack 5.No action needed.
integrations/angular-cli-20/package.json (1)
11-20
: Angular deps bump looks consistent (LGTM).All Angular packages are aligned on 20.3.x; rxjs ~7.8.2, tslib ^2.8.1, and zone.js ~0.15.1 look appropriate for Angular 20.
integrations/react-next-15/package.json (1)
9-9
: LGTM; no@js-temporal/polyfill
imports orTemporal.now
usages detected—bump is safe. Please confirm example integrations import the polyfill correctly.examples/svelte/star-wars/package.json (1)
15-21
: No legacy Tailwind v3 config artifacts found; Svelte + Tailwind v4 setup is clean.examples/svelte/optimistic-updates/package.json (1)
15-19
: Approve Svelte devDependencies consistency
Versions for @sveltejs/adapter-auto, @sveltejs/kit, @sveltejs/vite-plugin-svelte, svelte, and svelte-check are uniform across all examples.examples/angular/query-options-from-a-service/package.json (1)
23-26
: Align TypeScript with Angular CLI 20.3.x peer requirements
Updatetypescript
in devDependencies from5.8.3
to a version supported by Angular 20.3.x (e.g.^5.9.0
) and re-lock. Confirm the exact TypeScript range in the official Angular 20.3.x documentation before merging.examples/solid/default-query-function/package.json (1)
13-13
: Peer dependencies are compatiblevite-plugin-solid@2.11.9 accepts vite ^6.0.0 and solid-js ^1.7.2, covering our vite 6.3.6 and solid-js 1.9.9.
examples/solid/basic/package.json (1)
13-13
: Peer dependencies align: solid-js@^1.9.9 and vite@^6.3.6 satisfy vite-plugin-solid@2.11.9 requirements.examples/solid/solid-start-streaming/package.json (1)
14-18
: Peer/engine compatibility verified. @solidjs/start@1.2.0 requires vinxi ^0.5.7 (satisfied by 0.5.8); vinxi has no engine constraints, so Node >=18 is fine.packages/vue-query/package.json (1)
66-66
: Safe patch bump; manual verification required.
Patch update is non-breaking. Please confirm there are no direct imports of @vue/devtools-api in source files and that all package.json entries in the monorepo use the same version.
"@angular/build": "^20.3.5", | ||
"@angular/cli": "^20.3.5", | ||
"@angular/compiler-cli": "^20.3.4", | ||
"typescript": "5.8.3" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Raise TypeScript to a version supported by Angular 20.3.x
After bumping @angular/* and @angular/cli/build, TS 5.8.3 likely falls outside peer bounds. Update and re-lock to avoid install/build errors.
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"
Confirm the exact peer range:
🌐 Web query:
What TypeScript versions are supported by Angular CLI/build 20.3.x?
💡 Result:
Angular 20.3.x supports TypeScript >= 5.9.0 and < 6.0.0. [1][2]
Sources:
[1] angular.dev — Version compatibility table for v20. (TypeScript: >=5.9.0 <6.0.0).
[2] angular/angular-cli release notes — @angular/build: "TypeScript versions older than 5.9 are no longer supported."
Update TypeScript to match Angular 20.3.x peer range
Angular 20.3.x requires TypeScript >=5.9.0 <6.0.0. Bump in package.json:
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.4", | |
"typescript": "5.8.3" | |
} | |
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.4", | |
"typescript": "^5.9.0" | |
} |
🤖 Prompt for AI Agents
In examples/angular/basic-persister/package.json around lines 24 to 28, the
TypeScript version is pinned to 5.8.3 which is incompatible with Angular 20.3.x
peer requirements (>=5.9.0 <6.0.0); update the typescript entry to a compatible
range such as "typescript": "^5.9.0" (or any 5.9.x exact version) in
package.json, then run the package manager install to update lockfiles and
verify the project builds.
"@angular/build": "^20.3.5", | ||
"@angular/cli": "^20.3.5", | ||
"@angular/compiler-cli": "^20.3.4", | ||
"typescript": "5.8.3" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Bump TypeScript to meet Angular 20.3.5 peers
TypeScript 5.8.3 is below the supported range for @angular/cli/build 20.3.5. Update and re-lock dependencies.
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"
Verify the precise TS peer window:
🌐 Web query:
What TypeScript versions are supported by Angular CLI/build 20.3.x?
💡 Result:
Angular 20.3.x supports TypeScript >= 5.9.0 and < 6.0.0 (i.e., TypeScript 5.9.x). [1]
Sources
[1] Angular — Version compatibility (TypeScript requirements for v20.2.x / v20.3.x).
Update TypeScript to ^5.9.0 in package.json
Angular 20.3.x requires TypeScript ≥5.9.0 <6.0.0.
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.4", | |
"typescript": "5.8.3" | |
} | |
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.4", | |
"typescript": "^5.9.0" | |
} |
🤖 Prompt for AI Agents
In examples/angular/infinite-query-with-max-pages/package.json around lines 22
to 26, the project pins TypeScript to 5.8.3 which is incompatible with Angular
20.3.x; update the TypeScript dependency to a version satisfying >=5.9.0 <6.0.0
(e.g. change "typescript": "5.8.3" to "typescript": "^5.9.0"), then run npm
install and verify the project builds/tests successfully.
"devDependencies": { | ||
"@angular/build": "^20.0.0", | ||
"@angular/cli": "^20.0.0", | ||
"@angular/compiler-cli": "^20.0.0", | ||
"@angular/build": "^20.3.5", | ||
"@angular/cli": "^20.3.5", | ||
"@angular/compiler-cli": "^20.3.4", | ||
"typescript": "5.8.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Update TypeScript to satisfy Angular 20.3.x peers
With @angular/cli/build 20.3.5, TypeScript 5.8.3 is outside the supported peer range. Bump TS and refresh the lockfile to avoid peer install/build failures.
Apply:
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"
Verify the exact supported TS range for Angular 20.3.x:
🌐 Web query:
What TypeScript versions are supported by Angular CLI/build 20.3.x?
💡 Result:
Angular 20.3.x requires TypeScript >=5.9.0 and <6.0.0 (i.e. TypeScript 5.9.x). [1][2]
Sources:
[1] Angular version compatibility table — angular.dev.
[2] angular/angular-cli release notes (20.3.0) — GitHub.
Bump TypeScript to v5.9.x
Angular 20.3.x requires TypeScript ≥5.9.0 <6.0.0. Update in examples/angular/rxjs/package.json:
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"
Run your package manager to regenerate the lockfile.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"devDependencies": { | |
"@angular/build": "^20.0.0", | |
"@angular/cli": "^20.0.0", | |
"@angular/compiler-cli": "^20.0.0", | |
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.4", | |
"typescript": "5.8.3" | |
"devDependencies": { | |
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.4", | |
"typescript": "^5.9.0" |
🤖 Prompt for AI Agents
In examples/angular/rxjs/package.json around lines 22 to 26 the TypeScript
devDependency is pinned to 5.8.3 which is incompatible with Angular 20.3.x;
update the "typescript" entry to a 5.9.x range that satisfies >=5.9.0 <6.0.0
(e.g. "^5.9.0") and then run your package manager (npm/yarn/pnpm) to install and
regenerate the lockfile.
"@sveltejs/adapter-auto": "^6.1.1", | ||
"@sveltejs/kit": "^2.46.4", | ||
"@sveltejs/vite-plugin-svelte": "^5.1.1", | ||
"svelte": "^5.39.3", | ||
"svelte-check": "^4.3.1", | ||
"svelte": "^5.39.11", | ||
"svelte-check": "^4.3.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
SvelteKit/Svelte patch bumps look good; please verify cross‑example consistency.
No API changes here. Suggest confirming all Svelte example packages align on these versions and Node engine constraints.
🏁 Script executed:
#!/bin/bash
# Verify Svelte-related versions across all examples (should match these bumps)
set -euo pipefail
echo "Packages to check: @sveltejs/adapter-auto, @sveltejs/kit, svelte, svelte-check"
fd -a package.json examples/svelte | while read -r f; do
echo "---- $f"
# Print versions if present; blank if missing
for pkg in '@sveltejs/adapter-auto' '@sveltejs/kit' 'svelte' 'svelte-check'; do
ver=$(jq -r --arg p "$pkg" '.devDependencies[$p] // .dependencies[$p] // empty' "$f" 2>/dev/null || true)
printf "%-24s %s\n" "$pkg" "${ver:-<absent>}"
done
done
echo "Check for engines.node fields (ensure Node satisfies SvelteKit requirements)"
rg -nP '"engines"\s*:\s*\{[^}]*"node"\s*:\s*"[^"]+"' -g 'examples/**/package.json' -C1 || true
Length of output: 1729
Align SvelteKit dependencies in simple
example & pin Node engine
- In
examples/svelte/simple/package.json
, add
"@sveltejs/kit": "^2.46.4"
and"@sveltejs/adapter-auto": "^6.1.1"
to match other examples. - Add an
"engines": { "node": ">=<minimum-required-by-SvelteKit>" }
field to each example’spackage.json
.
🤖 Prompt for AI Agents
examples/svelte/playground/package.json lines 15-19: Ensure SvelteKit deps are
consistent across examples by adding "@sveltejs/kit": "^2.46.4" and
"@sveltejs/adapter-auto": "^6.1.1" to examples/svelte/simple/package.json (use
the same versions as shown here), and add an "engines" field to every example
package.json with "node": ">=<minimum-required-by-SvelteKit>" (replace the
placeholder with the actual minimum Node version required by the SvelteKit
version you are using).
94d7c86
to
3872063
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (5)
examples/angular/auto-refetching/package.json (1)
12-26
: Align TypeScript with Angular 20.3 toolingThis app also runs Angular 20.3.x while pinning
typescript
to5.8.3
, which falls outside the CLI’s supported peer range (>=5.9.0 <6.0.0
). Please bumptypescript
to at least^5.9.0
so installs/builds remain supported."devDependencies": { "@angular/build": "^20.3.5", "@angular/cli": "^20.3.5", "@angular/compiler-cli": "^20.3.4", - "typescript": "5.8.3" + "typescript": "^5.9.0" }examples/angular/devtools-panel/package.json (1)
23-26
: Upgrade TypeScript to match Angular 20.3.x peer requirements.@angular/cli and @angular/build 20.3.5 require TypeScript >=5.9.0 <6.0.0. Leaving this pinned to 5.8.3 triggers peer-install failures and blocks builds. Please bump to a compatible range (e.g.
^5.9.0
) and refresh the lockfile.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/router/package.json (1)
23-26
: Align TypeScript with Angular 20.3.x peer range.@angular/cli 20.3.5 advertises a peer dependency on TypeScript >=5.9.0 <6.0.0. Keeping 5.8.3 will cause installation/build failures. Please bump to a compatible version and regenerate the lockfile.
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/basic-persister/package.json (1)
24-27
: Bump TypeScript to satisfy Angular 20.3.x.After upgrading @angular/* and @angular/cli to 20.3.x you must also move TypeScript to >=5.9.0 <6.0.0. Keeping 5.8.3 violates the CLI’s peer dependency and will stop installs/builds.
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/basic/package.json (1)
22-26
: Still misaligned TypeScript peer for Angular 20.3.xAngular 20.3.5 CLI/build require TypeScript >=5.9 <6.0, so keeping 5.8.3 will fail peer resolution and builds. Please bump TypeScript into the supported >=5.9 <6.0 range and refresh the lockfile.
#!/bin/bash # Inspect peer constraints published by Angular tooling npm view @angular/cli@20.3.5 peerDependencies npm view @angular/compiler-cli@20.3.4 peerDependencies
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (76)
examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(2 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- examples/vue/nuxt3/package.json
- examples/react/eslint-legacy/package.json
🚧 Files skipped from review as they are similar to previous changes (41)
- packages/react-query-next-experimental/package.json
- examples/react/offline/package.json
- examples/angular/rxjs/package.json
- examples/svelte/simple/package.json
- examples/svelte/ssr/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/devtools-panel/package.json
- integrations/react-webpack-4/package.json
- packages/query-devtools/package.json
- packages/solid-query/package.json
- examples/svelte/basic/package.json
- packages/svelte-query/package.json
- packages/react-query/package.json
- packages/eslint-plugin-query/package.json
- integrations/svelte-vite/package.json
- packages/vue-query/package.json
- examples/solid/basic/package.json
- examples/react/rick-morty/package.json
- examples/solid/basic-graphql-request/package.json
- examples/react/basic-graphql-request/package.json
- examples/angular/pagination/package.json
- integrations/react-vite/package.json
- examples/svelte/auto-refetching/package.json
- integrations/angular-cli-20/package.json
- packages/svelte-query-persist-client/package.json
- packages/query-persist-client-core/package.json
- packages/react-query-devtools/package.json
- integrations/solid-vite/package.json
- packages/react-query-persist-client/package.json
- examples/svelte/playground/package.json
- examples/react/react-native/package.json
- examples/react/star-wars/package.json
- examples/react/simple/package.json
- examples/react/shadow-dom/package.json
- integrations/react-next-15/package.json
- examples/solid/astro/package.json
- examples/angular/simple/package.json
- packages/query-test-utils/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/optimistic-updates/package.json
- examples/react/basic/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-core/package.json
packages/solid-query-devtools/package.json
packages/query-async-storage-persister/package.json
packages/svelte-query-devtools/package.json
packages/angular-query-experimental/package.json
packages/solid-query-persist-client/package.json
packages/query-broadcast-client-experimental/package.json
packages/angular-query-persist-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
"@angular/common": "^20.3.4", | ||
"@angular/compiler": "^20.3.4", | ||
"@angular/core": "^20.3.4", | ||
"@angular/platform-browser": "^20.3.4", | ||
"@angular/router": "^20.3.4", | ||
"@tanstack/angular-query-experimental": "^5.90.2", | ||
"rxjs": "^7.8.2", | ||
"tslib": "^2.8.1", | ||
"zone.js": "0.15.0" | ||
"zone.js": "0.15.1" | ||
}, | ||
"devDependencies": { | ||
"@angular/build": "^20.0.0", | ||
"@angular/cli": "^20.0.0", | ||
"@angular/compiler-cli": "^20.0.0", | ||
"@angular/build": "^20.3.5", | ||
"@angular/cli": "^20.3.5", | ||
"@angular/compiler-cli": "^20.3.4", | ||
"typescript": "5.8.3" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Bump TypeScript to match Angular 20.3 peer requirements
All Angular deps just moved to 20.3.x, but @angular/cli@20.3.5
and friends declare a peer range of >=5.9.0 <6.0.0
. Keeping typescript
at 5.8.3
violates that requirement and will cause peer‑dependency failures (pnpm) or unsupported builds. Please raise the version to something like ^5.9.0
(or newer within <6.0.0
) so this example stays installable.
"devDependencies": {
"@angular/build": "^20.3.5",
"@angular/cli": "^20.3.5",
"@angular/compiler-cli": "^20.3.4",
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"
}
🌐 Web query:
For @angular/cli 20.3.5, what TypeScript version range is required?
💡 Result:
@angular/cli 20.3.5 requires TypeScript >=5.9.0 and <6.0.0. [1]
Sources
[1] Angular — Version compatibility (TypeScript requirement for v20.2.x / v20.3.x).
Bump TypeScript to satisfy Angular 20.3 peer range
@angular/cli@20.3.5 requires TS >=5.9.0 <6.0.0; update examples/angular/query-options-from-a-service/package.json devDependencies.
"devDependencies": {
"@angular/build": "^20.3.5",
"@angular/cli": "^20.3.5",
"@angular/compiler-cli": "^20.3.4",
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"
}
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"@angular/common": "^20.3.4", | |
"@angular/compiler": "^20.3.4", | |
"@angular/core": "^20.3.4", | |
"@angular/platform-browser": "^20.3.4", | |
"@angular/router": "^20.3.4", | |
"@tanstack/angular-query-experimental": "^5.90.2", | |
"rxjs": "^7.8.2", | |
"tslib": "^2.8.1", | |
"zone.js": "0.15.0" | |
"zone.js": "0.15.1" | |
}, | |
"devDependencies": { | |
"@angular/build": "^20.0.0", | |
"@angular/cli": "^20.0.0", | |
"@angular/compiler-cli": "^20.0.0", | |
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.4", | |
"typescript": "5.8.3" | |
} | |
"@angular/common": "^20.3.4", | |
"@angular/compiler": "^20.3.4", | |
"@angular/core": "^20.3.4", | |
"@angular/platform-browser": "^20.3.4", | |
"@angular/router": "^20.3.4", | |
"@tanstack/angular-query-experimental": "^5.90.2", | |
"rxjs": "^7.8.2", | |
"tslib": "^2.8.1", | |
"zone.js": "0.15.1" | |
}, | |
"devDependencies": { | |
"@angular/build": "^20.3.5", | |
"@angular/cli": "^20.3.5", | |
"@angular/compiler-cli": "^20.3.4", | |
"typescript": "^5.9.0" | |
} |
🤖 Prompt for AI Agents
In examples/angular/query-options-from-a-service/package.json around lines 12 to
27, the devDependency for TypeScript is pinned to 5.8.3 which is incompatible
with @angular/cli@20.3.5; update the "typescript" entry in devDependencies to a
version satisfying Angular 20.3's peer range (>=5.9.0 <6.0.0), e.g. set
"typescript" to "^5.9.0" (or a specific 5.9.x patch) so the peer requirement is
met.
3872063
to
2e9ad58
Compare
This PR contains the following updates:
5.2.1
->5.40.0
^20.0.0
->^20.3.4
^20.0.0
->^20.3.5
^20.0.0
->^20.3.5
^20.0.0
->^20.3.4
^20.0.0
->^20.3.4
^20.0.0
->^20.3.4
^20.0.0
->^20.3.4
^20.0.0
->^20.3.4
^20.0.0
->^20.3.4
^20.0.0
->^20.3.4
^0.15.3
->^0.18.2
^5.0.7
->^5.1.1
^8.1.3
->^8.2.9
^7.26.0
->^7.28.4
^7.24.9
->^7.28.4
^7.26.0
->^7.28.3
^7.25.9
->^7.27.1
^2.29.5
->^2.29.7
^2.0.1
->^2.0.6
^10.0.5
->^10.0.11
^0.4.4
->^0.5.1
^0.13.4
->^0.13.11
^1.2.2
->^1.5.2
^2.0.26
->^2.1.3
^1.1.3
->^1.2.0
^6.1.0
->^6.1.1
^2.42.2
->^2.46.4
^2.4.0
->^2.5.4
^4.1.13
->^4.1.14
^4.0.14
->^4.1.14
^5.76.0
->^5.90.2
^0.20.2
->^0.20.3
^18.0.0
->^18.1.0
^10.4.0
->^10.4.1
^6.8.0
->^6.9.1
^16.1.0
->^16.3.0
^2.0.0
->^2.0.1
^5.0.4
->^5.0.5
^8.44.1
->^8.46.0
^8.44.1
->^8.46.0
^8.44.1
->^8.46.0
^4.3.4
->^4.7.0
^5.2.1
->^5.2.4
^1.1.36
->^1.3.16
^6.6.3
->^6.6.4
^8.3.0
->^8.4.1
^7.0.0
->^7.1.0
^9.36.0
->^9.37.0
^50.5.0
->^50.8.0
^3.11.0
->^3.12.4
^1.2.1
->^1.2.2
^52.0.11
->^52.0.47
^17.0.3
->^17.1.7
^2.0.0
->^2.2.3
^2.1.16
->^2.1.18
^16.9.0
->^16.11.0
^7.1.2
->^7.2.0
^5.6.3
->^5.6.4
^6.2.1
->^6.2.2
^5.63.1
->^5.64.2
^2.6.6
->^2.11.5
^5.0.0
->^5.0.2
^3.12.4
->^3.19.3
21.5.3
->21.6.4
10.17.0
->10.18.2
^0.3.13
->^0.3.14
^2.5.2
->^2.6.0
^0.76.3
->^0.82.0
^2.20.2
->^2.28.0
^5.12.5
->^5.14.5
^3.16.2
->^3.19.2
^4.12.0
->^4.14.1
^4.1.0
->^4.16.0
^0.19.13
->^0.21.1
^6.25.1
->^6.30.1
^6.25.1
->^6.30.1
^8.0.0
->^8.4.0
~7.8.0
->~7.8.2
^1.9.7
->^1.9.9
^0.2.3
->^0.3.0
^5.39.3
->^5.39.11
^4.3.1
->^4.3.3
^4.1.13
->^4.1.14
^3.4.7
->^3.4.18
^4.0.14
->^4.1.14
^2.3.0
->^2.8.1
^0.5.3
->^0.5.8
4.2.3
->4.5.4
^0.9.0
->^0.10.0
^2.11.6
->^2.11.9
~0.15.0
->~0.15.1
0.15.0
->0.15.1
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
algolia/algoliasearch-client-javascript (@algolia/client-search)
v5.40.0
Compare Source
v5.39.0
Compare Source
v5.38.0
Compare Source
composition
&composition-full
(#5333) by @ClaraMullerv5.37.0
Compare Source
v5.36.0
Compare Source
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.