Skip to content

Commit 4744f31

Browse files
authored
Merge pull request #80 from TaskarCenterAtUW/stage
Stage to Prod
2 parents 1a98c65 + 8598567 commit 4744f31

File tree

3 files changed

+21
-6
lines changed

3 files changed

+21
-6
lines changed

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ pydantic==1.10.16
33
html_testRunner==1.2.1
44
uvicorn==0.20.0
55
python-ms-core==0.0.23
6-
gtfs-canonical-validator==0.0.6
6+
gtfs-canonical-validator==0.0.8

src/gtfx_flex_validator.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from pathlib import Path
77
from .config import Settings
88
from python_ms_core import Core
9+
from gtfs_canonical_validator import CanonicalValidator
910
from .models.file_upload_msg import FileUploadMsg
1011
from .gtfs_flex_validation import GTFSFlexValidation
1112
from python_ms_core.core.queue.models.queue_message import QueueMessage
@@ -74,7 +75,11 @@ def send_status(self, valid: bool, upload_message: FileUploadMsg, validation_mes
7475
'user_id': upload_message.data.user_id,
7576
'tdei_project_group_id': upload_message.data.tdei_project_group_id,
7677
'success': valid,
77-
'message': validation_message
78+
'message': validation_message,
79+
'package': {
80+
'python-ms_core': Core.__version__,
81+
'gtfs-canonical-validator': CanonicalValidator.__version__
82+
}
7883
}
7984
logger.info(
8085
f' Publishing new message with ID: {upload_message.messageId} with status: {valid} and Message: {validation_message}')

tests/unit_tests/test_gtfx_flex_validator.py

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import unittest
22
from unittest.mock import MagicMock, patch, call
33
from src.gtfx_flex_validator import GTFSFlexValidator
4+
import python_ms_core
5+
from gtfs_canonical_validator import CanonicalValidator
46

57

68
class TestGTFSFlexValidator(unittest.TestCase):
@@ -49,7 +51,6 @@ def test_subscribe_with_valid_message(self, mock_request_message, mock_queue_mes
4951
# Assert
5052
self.validator.process_message.assert_called_once_with(mock_request_message)
5153

52-
5354
@patch('src.gtfx_flex_validator.GTFSFlexValidation')
5455
def test_process_message_with_valid_file_path(self, mock_gtfs_flex_validation):
5556
# Arrange
@@ -68,7 +69,7 @@ def test_process_message_with_valid_file_path(self, mock_gtfs_flex_validation):
6869
# Assert
6970

7071
self.validator.send_status.assert_called_once_with(valid=True, upload_message=mock_request_message,
71-
validation_message='Validation successful')
72+
validation_message='Validation successful')
7273

7374
@patch('src.gtfx_flex_validator.GTFSFlexValidation')
7475
def test_process_message_when_file_path_is_none_and_valid_is_false(self, mock_gtfs_flex_validation):
@@ -89,7 +90,6 @@ def test_process_message_when_file_path_is_none_and_valid_is_false(self, mock_gt
8990
validation_message='Validation error'
9091
)
9192

92-
9393
@patch('src.gtfx_flex_validator.GTFSFlexValidation')
9494
def test_process_message_when_exception_is_raised(self, mock_gtfs_flex_validation):
9595
# Arrange
@@ -117,7 +117,17 @@ def test_send_status_success(self, mock_queue_message):
117117
# Arrange
118118
mock_request_message = MagicMock()
119119
mock_response_topic = self.validator.core.get_topic.return_value
120-
mock_data = {'messageId': '1234', 'messageType': 'test', 'data': {'success': True}}
120+
mock_data = {
121+
'messageId': '1234',
122+
'messageType': 'test',
123+
'data': {
124+
'success': True,
125+
'package': {
126+
'python-ms_core': python_ms_core.__version__,
127+
'gtfs-canonical-validator': CanonicalValidator.__version__
128+
}
129+
}
130+
}
121131
mock_queue_message.data_from.return_value = mock_data
122132

123133
# Act

0 commit comments

Comments
 (0)