Skip to content

Fixed random kick draw for MULLERMANDEL prescription #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Fixed random kick draw for MULLERMANDEL prescription #1411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BaseStar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3837,7 +3837,7 @@ double BaseStar::DrawRemnantKickMullerMandel(const double p_COCoreMass,
sigmaKick = OPTIONS->MullerMandelSigmaKickBH();
}

double quantile0 = gsl_cdf_gaussian_P(0.0, sigmaKick); //quantile of 0 in the Gaussian CDF; the goal is to draw from the cut-off Gaussian since the kick must exceed 0
double quantile0 = gsl_cdf_gaussian_P(-1.0, sigmaKick); //quantile of -1 in the Gaussian CDF; the goal is to draw from the cut-off Gaussian since the kick must exceed 0
double rand = quantile0 + p_Rand * (1.0 - quantile0);
remnantKick = muKick * (1.0 + gsl_cdf_gaussian_Pinv(rand, sigmaKick));

Expand Down
6 changes: 4 additions & 2 deletions src/changelog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1610,7 +1610,9 @@
// - Added missing virtual declaration to ShouldEnvelopeBeExpelledByPulsations
// - Now calculate mass accretion rate for nuclear timescale mass transfer on the fly to match with donor mass loss rate set by donor mass loss (required to fit into Roche lobe) divided by time step
// - Fixed random draws of SN kicks to avoid artificial pile-up at boundaries of distribution
// - Split --muller-mandel-sigma-kick into --muller-mandel-sigma-kick-NS and --muller-mandel-sigma-kick-BH
// - Split --muller-mandel-sigma-kick into --muller-mandel-sigma-kick-NS and --muller-mandel-sigma-kick-BH
// 03.22.01 IM - July 20, 2025 - Defect repair
// - Fixed random kick draw for MULLERMANDEL prescription

// Version string format is MM.mm.rr, where
//
Expand All @@ -1621,7 +1623,7 @@
// if MM is incremented, set mm and rr to 00, even if defect repairs and minor enhancements were also made
// if mm is incremented, set rr to 00, even if defect repairs were also made

const std::string VERSION_STRING = "03.22.00";
const std::string VERSION_STRING = "03.22.01";


# endif // __changelog_h__