Skip to content

First implementation of HAMSTARS mass transfer efficiency #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 10, 2025
Merged

First implementation of HAMSTARS mass transfer efficiency #1433

merged 3 commits into from
Sep 10, 2025

Conversation

ilyamandel
Copy link
Collaborator

No description provided.

@ilyamandel ilyamandel marked this pull request as draft September 2, 2025 12:44
Ilya Mandel added 2 commits September 9, 2025 21:22
Corrected errors in combining OB and WR winds in CH::CalculateMassLos…
d3790b5 
…sRateBelczynski2010() and CH::CalculateMassLossRateFractionOB() [previously CalculateMassLossRateWeightOB()]
Typo fixes
326930c
@themikelau themikelau marked this pull request as ready for review September 9, 2025 12:36
themikelau
themikelau approved these changes Sep 9, 2025
View reviewed changes
Copy link
Collaborator

@themikelau themikelau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Hamstars stuff looks good to me. I understand this is a simplified implementation. Do we want to call this a different name in anticipation for a future, full implementation?

@ilyamandel
Copy link
Collaborator Author

Thanks, @themikelau !
I suggest keeping the simple name for now and adjust later if/when we implement something else?
BTW, @SimonStevenson , @jmerritt1 -- note this now also contains a fix to OB/WR mass loss for stars which combine the two with weights (credit to @jeffriley for spotting this issue)

@ilyamandel ilyamandel merged commit 0192277 into dev Sep 10, 2025
3 checks passed
@ilyamandel ilyamandel deleted the Hamstars branch September 10, 2025 09:36
@ilyamandel ilyamandel mentioned this pull request Sep 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@themikelau themikelau themikelau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ilyamandel @themikelau