-
Notifications
You must be signed in to change notification settings - Fork 2k
OfficeFloor implementation of Framework Benchmark Performance Tests. #1760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OfficeFloor implementation of Framework Benchmark Performance Tests. #1760
Conversation
Passed local test.
|
OfficeFloor implementation of Framework Benchmark Performance Tests.
@sagenschneider I had to revert your pull request as it did not conform to our standards. I will leave comments on the files needing changes here, but you will have to open a new pull request to get OfficeFloor added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete everything about this and replace with:
fw_depends java mvn
We are presently in the midst of opening a pull request to fix up the various java version problems (likely, the culprit behind why you did your dependencies this way), so once we get that in (hopefully, today or tomorrow) you can open your new pull request.
No worries. Please excuse this if it has caused too many problems. I'm happy to make the change once the issues are resolved. Please either update this PR once done, or email me at daniel@officefloor.net and I'll resubmit with changes. Also, can I confirm that the fix will have:
Note: the above is fixes if that helps. |
Really, the only problem was the manual installation of java and maven; we provide Additionally, the java8-vs-java7 issues should be resolved by a pull request soon, and I will ping you here when you can rebase and open another pull request. |
Would you accept a pull request change to toolset/setup/linux/systools/maven.sh setup that is following? (this will load latest maven) #!/bin/bash RETCODE=$(fw_exists ${IROOT}/maven.installed) sudo add-apt-repository "deb http://ppa.launchpad.net/natecarlson/maven3/ubuntu precise main" mvn -version touch $IROOT/maven.installed source $IROOT/maven.installed |
Why? Does OfficeFloor require a particular version or maven? |
I am running OfficeFloor through the OfficeFloor maven plugins. The OfficeFloor plugins load all necessary dependencies, however due to a bug in 3.0.5 the maven dependency loading fails on the source directory when pulling in (as assumes everything to be jars). This has been resolved in later maven version. Note: maven 3.0.5 is nearly 3 years old. |
No description provided.