Skip to content

Conversation

sagenschneider
Copy link
Contributor

Requires the:

  • java 8 fix
  • PR to use latest maven version

@sagenschneider
Copy link
Contributor Author

Dependent on PR #1912

@msmith-techempower
Copy link
Member

.travis.yml needs to be updated to include testing of officefloor

@sagenschneider
Copy link
Contributor Author

Ok, will update .travis.yml. Do you wish for the PR to be squashed to one commit?

@msmith-techempower
Copy link
Member

I don't really have a preference; do whatever you're comfortable with.

@sagenschneider
Copy link
Contributor Author

Ok, .travis.yml updated

@sagenschneider
Copy link
Contributor Author

Please review and merge.

I am aware of the ";charset=UTF-8" not being necessary but this will require a release of OfficeFloor to fix (likely not done in time for March, as in middle of making changes for cloud functionality). I'll look to have this optimisation available for a later benchmark test.

@msmith-techempower
Copy link
Member

This actually does not appear to be dependent on #1912

All tests pass; LGTM!

@msmith-techempower msmith-techempower merged commit e1f1efc into TechEmpower:master Feb 11, 2016
@sagenschneider sagenschneider deleted the officefloor_techempire branch August 17, 2018 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants