Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add excludeMembers (blacklist) support to all groups #5838

Merged
merged 4 commits into from
Sep 23, 2021
Merged

Add excludeMembers (blacklist) support to all groups #5838

merged 4 commits into from
Sep 23, 2021

Conversation

nf-s
Copy link
Contributor

@nf-s nf-s commented Sep 21, 2021

Add excludeMembers (blacklist) support to all groups

Fixes #5153

Added excludeMembers property to GroupTraits. It is an array of strings of excluded group and item names. A group or item name that appears in this list will not be shown to the user. This is case-insensitive and will also apply to all child/nested groups

Accompanying catalog-converter PR - TerriaJS/catalog-converter#52

Example

{
  "catalog": [
    {
      "type": "sdmx-group",
      "name": "Pacific Data Hub .Stat",
      "url": "https://stats-nsi-stable.pacificdata.org/rest",
      "excludeMembers": [
        "population",
        "Balance of payments"
      ]
    }
  ]
}

image

Before

http://ci.terria.io/main/#clean&https://gist.githubusercontent.com/nf-s/71cb8315cd5695d1698fc7465e919def/raw/45a6c17b5c61ba0ba745bde7aae046990a70799a/excludeMembers.json

After

http://ci.terria.io/blacklist/#clean&https://gist.githubusercontent.com/nf-s/71cb8315cd5695d1698fc7465e919def/raw/45a6c17b5c61ba0ba745bde7aae046990a70799a/excludeMembers.json

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.

Copy link
Collaborator

@na9da na9da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @nfs!

I know it was already in v8 but if it is not too difficult now then maybe we should replace blacklist with excludeList?

@nf-s
Copy link
Contributor Author

nf-s commented Sep 23, 2021

Thanks @na9da - yep I'll rename it to something like excludeMembers

@nf-s nf-s merged commit b43a4fc into main Sep 23, 2021
@nf-s nf-s deleted the blacklist branch September 23, 2021 05:35
@nf-s nf-s changed the title Add blacklist support to all groups Add excludeMembers (blacklist) support to all groups Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port "blacklist" for ArcGis(Feature | Map)ServerCatalogGroup to v8
2 participants