Can not compile from source on clean VS2013 machine

[ewilde]

The source code has a dependency on ASP.NET MVC 4.0.0.0. Which seems to only be distributed by the 'Microsoft Web Platform Installer'.

If you install ASP.NET 4 from the 'Microsoft Web Platform Installer' today it installs ASP.NET MVC 4.0.0.1 requiring references in csproj to be changed to:

   <Reference Include="System.Web.Mvc, Version=4.0.0.1, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL" />

If have a commit I can push with these changes. Perhaps taking a dependency on MVC4 nuget package or upgrading the whole solution to .net4.5 or greater and taking the latest MVC 5 nuget package would be easier for people pulling down sources in the future?

[JakeGinnivan]

We should update to take a dependency on MVC4 nuget definitely. We really shouldn't be relying on people having MVC in their GAC

[JakeGinnivan]

Id prefer not to upgrade to 4.5 at the moment

[ewilde]

Ok great, probably easier if I add it to the current pull request #59

[JakeGinnivan]

sure, It would be great if we could also fix the line ending issues. Not sure why we are having them though =/ No worries if we can't

[ewilde]

Sure can try, can you point out where an instance of the line ending issue occurs?

[JakeGinnivan]

Notice how the entire file has changed: https://github.com/TestStack/ConventionTests/pull/59/files#diff-d03de6c9d2832724a19d5921b8198e6eL1

I think I need to learn how git handles line endings properly, this causes me so much pain :(

[JakeGinnivan]

Don't stress about it though, github support ?w=1 to let you view the diff ignoring whitespace, so i can still progress

[ewilde]

Yes i saw that very annoying. I noticed in the .gitattributes for this repo that
*.csproj -text=auto merge=union

When I create a new repo using GitHub for windows I get:

# Auto detect text files and perform LF normalization
* text=auto

# Custom for Visual Studio
*.cs     diff=csharp
*.sln    merge=union
*.csproj merge=union
*.vbproj merge=union
*.fsproj merge=union
*.dbproj merge=union

Which doesn't have the -text=auto on stackoverflow (http://stackoverflow.com/questions/12929625/why-does-git-does-not-merge-some-changes) the accepted answer for a similar problem is

*.csproj text=auto merge=union which is missing the hyphen in front of text, not sure if that was the issue don't know :(

[JakeGinnivan]

oh interesting.. maybe we are removing that flag. if so. Yay..

[ewilde]

This is closed now that 58f829e is pulled in. Thanks