Skip to content

Conversation

kkozmic
Copy link
Contributor

@kkozmic kkozmic commented Aug 10, 2013

No description provided.

moving common logic into a separate method
using Environment.NewLine to make Mono crowd happy
Advantage of this approach is, it doesn't change any existing abstraction and doesn't add complexity to the user.
@kkozmic kkozmic mentioned this pull request Aug 10, 2013
@JakeGinnivan
Copy link
Member

There is actually a lot of stuff my PR is taking care of, I have updated it to remove a few of the additional interfaces and bring things back a little bit. But here is a list of things it does

  • Reports on passed conventions. The grammar was wrong for passing in the initial PR
  • Reports on what the data IS. For example nHibernate entities, or the project name. The test title is now:
    Passed: 'Project must not reference dlls from bin or obj directories' for 'TestStack.ConventionTests.Tests'
    Passed: '.sql Files must be embedded resources' for 'TestStack.ConventionTests.Tests'
    Failed: 'Types must have a default constructor' for 'nHibernate Entitites'
  • Introduced a new interface for Symmetric conventions. I can pull this into it's own PR if you would like, but I think this is essential
  • Made approved exceptions report on the individual failures, not the entire test output. This means it is more targeted, and much nicer
  • A summary report is generated, this contains the results of ALL convention tests
  • Filtering is moved into the Convention itself. It makes more sense to me to apply 'FilesMustBeEmbeddedResource' with a parameter of .sql to tell it what extension this convention is running for, then pass it the project as the data.
    • This allows me to have new FilesMustBeEmbeddedResource(".sql") and new FilesMustBeEmbeddedResource(".png") and use the same data source
  • Conventions and ConventionData have no knowledge of formatting/reporting

@kkozmic kkozmic closed this Aug 10, 2013
@kkozmic kkozmic deleted the reporting-take2 branch August 10, 2013 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants