-
Notifications
You must be signed in to change notification settings - Fork 19
Reporting2 #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporting2 #24
Conversation
Not terribly convinced yet I prefer this approach, but it's an experiment. This allows us to remove static factory method call and we can, if needed, treat this object as a context object if needed. Also changed the Execute method on the convention to be void... it technically makes things simpler, although on the other hand, doesn't in any way indicate you're supposed to call result.Something and that you're supposed to do it only once... We'll just need to play with it and see where it takes us
I quite liked the simplicity of @JakeGinnivan's solution that just returned IEnumerable<object> This allows us to do that as an option, but also to fallback to using IConventionResult explicitly when we need more control
introduced IConventionContext (to be used internally). Still a lot of cleaning up left to do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recon get rid of this, I would prefer that we just use result.Is for all conventions and not try to put this in for compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough
It's a bit hard to see all the changes, but have noticed a few things with the formatting. You always have
Also, long lambdas are like:
I think we should agree on this as it will stop unnecessary changes in the PR's. I am happy to always expand the getters and not line it up on a single line.
Is my preferred wrapping as the first line is still short enough, but it doesn't have that staircase appearance. Thoughts? (let me know any other styles which you would like to agree on) |
The context approach is interesting. I think it needs to be it's own PR with no other things mixed in Let me know if #25 is what you were trying to do, because it certainly seemed to make things cleaner |
about formatting, I'm letting Resharper handle that. Let me know if it gives you different results. In particular, it breaks the line at 120 chars (the default) but's nice when viewing the source on github since it shows just over 120 chars per line. I'm open to discussing changes in the style but perhaps it'd be better to open a separate issue for that. |
I was planning to clean up/rebuild the reporting pipeline but I'll do that in a separate PR. I won't have time to do this today