Reporting and formatting #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some refactoring to make the code a bit more readable
step one - removing static dependency
So we're shifting the balance a bit here. ConventionResult is really becoming a conventionContext which will act as a context object gluing together all various pieces of the pipeline, isolating all the statics etc. Kind of like HttpContext or OperationContext in WCF we're changing the interface to IConventionResultContext. While it's not the best name it's the best I could come up with, without calling it factory (which it's not, since it doesn't return anything) or calling it provider which is just wrong
All it took was two refactorings: - move method to another type - make method non-static that's it - no extra manual work, it even folded the ConventionContext parameter and replaced it with 'this' where required. Respect
so we keep them separate and don't pollute the Intellisense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.