More reporting changes #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kkozmic over to you :) |
|
About to push some more changes. Had a think about reporting. Now have this: It reports the data which fails, but doesn't care if this is approved or not, it simply reports it. This also shows off how we can have richer reporting for different markup types |
added 9 commits
September 1, 2013 11:14
…rstandable and introduced markdown reporter
…e and it simplifies a few things
…ing failing data, it can be conforming data too
…ibute in the assembly info.
|
Have also introduced the attribute, see https://github.com/JakeGinnivan/ConventionTests/commit/b782207280430a15492ab11e0f2aac97745329ef#L0R39 |
|
Overall there's a bunch of things that I like here, and some stuff that I think needs some more thinking. |
|
poke @kkozmic |
|
I'm merging this, feel free to counter PR with more changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards simplifying reporting. It introduces a new interface
ITestResultProcessorwhich defaults to theConventionReportTextRendererbut can be overridden when calling Convention.Is.There can only be a single
ITestResultProcessorper test, and this result processor is used by theIResultsProcessorto format the result of the test, for example when I tell Convention Tests to use the CsvReporter, then the Approval processor will be approving the output from the csv reporter.This also introduces a markdown reporter (which is not wired in anywhere yet, but was thinking about supporting
[assembly: ConventionReporter(typeof(MarkdownReporter))]sort of syntax which would allow users to easily configure additional reporters. Then the html reporter would not be hard coded, it could simply be used if the user wants it to be.Finally, this improves the html reporter. I started going down the road of reporting the types which conformed to the convention, but then am unsure because this could be going back to the pass/fail support in reporters. I just stopped but left the changes I had made in here to get feedback.
I am pretty happy with these changes, except the last one, I think they are good if we changed reporters to also report failures (like bddfy). Anyways, happy to hear your thoughts. It does show off more complex formatting of data which is nice, but not really sure of the use case for doing this now =\