Visual #653

artur-shaik · 2015-05-05T04:28:34Z

Added option to webview for selection enabled caret mode.
In status bar checking value of this option to identificate about it.

Added bindings: for toggle selection mode, <Ctrl+Space> drop
selection and keep selection mode enabled.

In webview added javascript snippet to position caret at top of the
viewport after caret enabling. This code mostly was taken from cVim sources. (Maybe should be moved to somewhere better place?)

This change is

Allow using '0' for move caret to beginnig of the line.

Added option to webview for selection enabled caret mode. In status bar checking value of this option to identificate about it. Added bindings: <Space> for toggle selection mode, <Ctrl+Space> drop selection and keep selection mode enabled. In webview added javascript snippet to position caret at top of the viewport after caret enabling. This code mostly was taken from cVim sources.

The-Compiler · 2015-05-05T06:19:40Z

qutebrowser/keyinput/basekeyparser.py

That should probably be removed now, or replaced by a debug log command 😉

Added option to webview for selection enabled caret mode. In status bar checking value of this option to identificate about it. Added bindings: <Space> for toggle selection mode, <Ctrl+Space> drop selection and keep selection mode enabled. In webview added javascript snippet to position caret at top of the viewport after caret enabling. This code mostly was taken from cVim sources.

The-Compiler · 2015-05-05T06:22:00Z

qutebrowser/mainwindow/statusbar/bar.py

Minor nitpick: That should be self.caret_selection_active in the comment.

The-Compiler · 2015-05-05T06:27:15Z

The javascript snippet is a good workaround! 😄

I suggest moving it to its own file (e.g. at qutebrowser/javascript/visual_position_caret.js or so), and then you can do evaluateJavaScript(utils.read_file('javascript/visual_position_caret.js')). Please also add a license header (from cVim I guess) to avoid issues when packaging (e.g. the debian packaging guidelines want a license header in every file).

artur-shaik · 2015-05-05T06:30:15Z

Oops... I was a bit rushed.

About counts I think yes, it can be usefull, but have you any ideas how to use '0' for jumping to start of line?

The-Compiler · 2015-05-05T06:37:47Z

I just looked at the cVim sources, and I think there's enough changed so we don't have to explicitely put their (MIT) license in. I suggest adding a comment with the usual GPL header (like in the other files), and then a comment mentioning some code was taken from https://github.com/1995eaton/chromium-vim/blob/master/content_scripts/visual.js which also makes it easier to find in the future.

Regarding binding of 0, that's currently not possible as it's handled as count, but I think it shouldn't be too hard to edit some stuff in qutebrowser/keyinput to allow it to be bound - the first place you'd have to look at is probably qutebrowser/keyinput/basekeyparser.py:_split_count() - maybe checking if count is 0, and if so, adding it to cmd_input instead of count will already be enough.

artur-shaik · 2015-05-05T06:53:04Z

Ok. Thanks for info, everything noticed, will look at it... 😄

artur-shaik · 2015-05-07T06:47:11Z

Ok, made some changes. I hope nothing was forgotten. 😄

The-Compiler · 2015-05-11T18:18:55Z

Thanks and sorry for the delay! Merging this into the visual branch now, then I'll do a final code review and test and merge that to master.

One small change: I'll change statusbar.bg.caret_selection to statusbar.bg.caret-selection as qutebrowser uses - instead of _ in all other settings too.

Visual

artur-shaik · 2015-05-12T04:08:45Z

Very nice. Thank you.

The-Compiler · 2015-05-12T18:48:55Z

I noticed in d594798 you removed the v keybinding - was this intentional?

As people in the IRC channel seemed to like it, I think v should be readded for toggle-selection. What do you think?

I also did various cleanups to the sources, added eslint as a linter and wrote some tests (#668).

artur-shaik · 2015-05-13T04:26:24Z

v key was deleted because of your suggestion. And you know, I found that I always try to enable selection mode with v key. So, may be people are right, it better to make v key for toggle-selection.

The-Compiler · 2015-05-13T04:58:30Z

v key was deleted because of your suggestion. And you know, I found that I always try to enable selection mode with v key. So, may be people are right, it better to make v key for toggle-selection.

Okay, I'll re-add it then. Sorry for the confusion!

What about handling enter similiar to what tmux does? I'd like this workflow:

Press v to go to caret mode.
Press Space to start a selection.
Select stuff.
Press Enter to go to back to normal mode and yank the selected text.

I can add that if you agree.

Also, thanks for your patience! As you can see, I'm a perfectionist, so I'm sorry this takes some time until it's merged. After those changes, I have one or two places in the code I want to take a closer look at, and after that's done I'll finally merge. 😄

See #653.

artur-shaik · 2015-05-13T05:34:51Z

He he, this is nice to be perfectionist. And don't worry about that, I'm fine with it.

For me better workflow is:

Press c to go to caret;
Press v to start selection (As I said, I always instinctively try to toggle selection with v);
Select stuff;
Press y (Enter for me too far away 😄 , and not common) to yank and go to normal mode (Now it keeps selection after yank, but I found that I don't need to keep selection in most time, so it better to go to normal, and drop selection).

When trying to add a new binding with multiple values, the bindings were added immediately and the next _is_new() check returned False because the command was already bound. With this change, the new bindings first get added to a temporary dict so _is_new() returns the correct result. See #653.

See #653.

The-Compiler · 2015-05-13T06:00:21Z

Okay! I changed :yank-selected to leave the mode by default, unless --stay is given, so now y/Y and Enter leave the mode.

I also fixed a bug which caused <Space> not to be bound correctly (only v) and cherry-picked it to the visual branch.

Can you please delete the [caret] section from your keys.conf, restart and confirm the workflow feels right to you? 😄

artur-shaik · 2015-05-13T06:07:32Z

Yeah, everything is nice as I want it. 😄

The-Compiler · 2015-05-18T20:48:49Z

It's now all merged, thank you again! 👍

artur-shaik · 2015-05-19T02:34:33Z

Nice, thank you too! 😄

The-Compiler · 2015-05-19T05:03:47Z

Have you seen #675? I wonder if that happened for you during testing as well...

And if you feel like and have some time, I'd still be glad about a spatial navigation mode 😄

artur-shaik · 2015-05-19T05:23:59Z

Yeah, I saw that. Will try to reproduce it little bit later. About spatial, of cause I'll be glad to implement. But I need to understand exactly, what do we want from that.

demure · 2017-02-12T16:55:50Z

So, I recently found this mode, but find it a very un-vim like. To select text in Caret Selection Mode, I must hold down shift. Might we consider adding the three vim visual block modes? These could 'lock' you into selecting without holding shift, and line/block modes are nice.

I also notice I can't use "/", "f", "F", "t", "T", or other vim fast navigation tricks in this mode. I think adding such bindings would make our caret mode quiet epic.

The-Compiler · 2017-02-12T17:02:23Z

@demure Is this on QtWebEngine, where caret mode isn't implemented at all yet? 😉

demure · 2017-02-12T17:06:46Z

Ah, sorry. When I saw that #626 linked here, I assumed this was the current ticket to comment on.

artur-shaik added 2 commits May 4, 2015 18:00

Disable support count for CaretKeyParser

aeaa20c

Allow using '0' for move caret to beginnig of the line.

The-Compiler mentioned this pull request May 5, 2015

Basic caret and visual modes implementation #626

Closed

The-Compiler reviewed May 5, 2015
View reviewed changes

qutebrowser/keyinput/basekeyparser.py Outdated

Copy link

Member

The-Compiler May 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should probably be removed now, or replaced by a debug log command 😉

The-Compiler reviewed May 5, 2015
View reviewed changes

qutebrowser/mainwindow/statusbar/bar.py Outdated

Copy link

Member

The-Compiler May 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick: That should be self.caret_selection_active in the comment.

Merge branch 'visual' of github.com:artur-shaik/qutebrowser into visual

15c8a93

artur-shaik added 4 commits May 7, 2015 11:51

Add count for actions. Zero key treat as command.

178d0df

Add jumps through text blocks in caret mode.

d936be4

Comment clean.

778ad5d

Move JS snippet in external js file.

57cad14

The-Compiler added a commit that referenced this pull request May 11, 2015

Merge pull request #653 from artur-shaik/visual

012e124

Visual

The-Compiler merged commit 012e124 into qutebrowser:visual May 11, 2015

The-Compiler added a commit that referenced this pull request May 13, 2015

Re-add v keybinding for toggle-selection.

dd0e230

See #653.

The-Compiler added a commit that referenced this pull request May 13, 2015

Add tmux-like Enter binding.

88fc186

See #653.

The-Compiler added a commit that referenced this pull request May 13, 2015

Leave mode when yanking by default.

f59a147

See #653.

qutebrowser-bot added the status: stale label Dec 20, 2017

Uh oh!

Visual #653

Visual #653

Uh oh!

Conversation

artur-shaik commented May 5, 2015 • edited by The-Compiler Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

The-Compiler May 5, 2015

Choose a reason for hiding this comment

Uh oh!

The-Compiler May 5, 2015

Choose a reason for hiding this comment

Uh oh!

The-Compiler commented May 5, 2015

Uh oh!

artur-shaik commented May 5, 2015

Uh oh!

The-Compiler commented May 5, 2015

Uh oh!

artur-shaik commented May 5, 2015

Uh oh!

artur-shaik commented May 7, 2015

Uh oh!

The-Compiler commented May 11, 2015

Uh oh!

artur-shaik commented May 12, 2015 via email

Uh oh!

The-Compiler commented May 12, 2015

Uh oh!

artur-shaik commented May 13, 2015

Uh oh!

The-Compiler commented May 13, 2015

Uh oh!

artur-shaik commented May 13, 2015

Uh oh!

The-Compiler commented May 13, 2015

Uh oh!

artur-shaik commented May 13, 2015 via email

Uh oh!

The-Compiler commented May 18, 2015

Uh oh!

artur-shaik commented May 19, 2015 via email

Uh oh!

The-Compiler commented May 19, 2015

Uh oh!

artur-shaik commented May 19, 2015 via email

Uh oh!

demure commented Feb 12, 2017

Uh oh!

The-Compiler commented Feb 12, 2017

Uh oh!

demure commented Feb 12, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

artur-shaik commented May 5, 2015 •

edited by The-Compiler

Loading