Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the multi power domain generation, custom IO placement, and diode insertion strategy 4 #609

Merged
merged 9 commits into from
Sep 17, 2021

Conversation

Manarabdelaty
Copy link
Collaborator

  • Drawing multiple power domains wasn't working properly because write_powered_def.py assumed that the default vdd and gnd nets always exist at index 0. This isn't always the case because the nets are ordered differently in the def file. This PR fixes the issue by enforcing the index of the default power and ground net (the default power domain is assumed to be the first net specified by ::env(VDD_NETS) and ::env(GND_NETS)).
  • Added two new variables to give more control on the macros connection to the top level power grid. FP_PDN_ENABLE_MACROS_GRID will either enable or disable connecting internal macros to power.
    FP_PDN_MACRO_HOOKS gives the ability to specify explicit power connections for internal macros. It is useful when the design has multiple power domains. For example,
    set ::env(FP_PDN_MACRO_HOOKS) "
    mprj vccd1 vssd1"
    will connect macro with instance name mprj to the power domain of vccd1 and vssd1. This depends on Update common_pdn.tcl RTimothyEdwards/open_pdks#161
  • Added @20Mhz fix for the custom IO placement
  • Updated the place_diodes.py to remove the dependency on the new_int API which is no longer available in openroad.

Manarabdelaty and others added 7 commits September 16, 2021 16:00
- Added a new variable called FP_PDN_MACRO_HOOKS to specify the power domain for each internal macro instance
- fix DIODE_INSERTION_STRATEGY 4
magic -> 0bb6ac1fa98b5371c73156b6e876925397fb7cbc
@donn donn self-requested a review September 17, 2021 08:50
@Manarabdelaty Manarabdelaty marked this pull request as ready for review September 17, 2021 10:52
Copy link
Collaborator

@donn donn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks okay, will merge if/when CI clears

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants