Skip to content

Single number i #11153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Single number i #11153

wants to merge 24 commits into from

Conversation

eukub
Copy link

@eukub eukub commented Nov 11, 2023 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Nov 14, 2023
@eukub
Copy link
Author

eukub commented Nov 14, 2023

added doctests

@eukub
Copy link
Author

eukub commented Nov 14, 2023

added doctests run

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Nov 16, 2023
JeelGajera
JeelGajera approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@JeelGajera JeelGajera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase you branch with master would solve the build fail

eukub and others added 18 commits December 2, 2023 13:12
@eukub
Algorithm solving problem "136. Single Number" from Leetcode (https:/…
2fec97b 
…/leetcode.com/problems/single-number/)
@eukub
Algorithm solving problem "136. Single Number" from Leetcode (https:/…
09a990b 
…/leetcode.com/problems/single-number/)
@eukub
Algorithm solving problem "136. Single Number" from Leetcode (https:/…
66af9cb 
…/leetcode.com/problems/single-number/)
@eukub
Algorithm solving problem "136. Single Number" from Leetcode (https:/…
56017b7 
…/leetcode.com/problems/single-number/)
@FishyGitHubUser @eukub
Fix ignore venv in build_directory_md.py (TheAlgorithms#11156)
b91dbfc 
Co-authored-by: MICHAEL CASTLE <CASTLM@tdm.local>
@meg-1 @cclauss
@pre-commit-ci @eukub
adding a geometry module (TheAlgorithms#11138)
f693cd9 
* adding a geometry module

* fixing errors and adding type hints

* Create code_review_feedback.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* implementing suggestions

* fixing ruff errors

* Update geometry/code_review_feedback.py

* Update geometry/code_review_feedback.py

* Update geometry/geometry.py

* Apply suggestions from code review

* Delete geometry/code_review_feedback.py

* Update geometry/geometry.py

* Update geometry/geometry.py

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@FishyGitHubUser @eukub
Fix typo in knight_tour.py (TheAlgorithms#11173)
9a3ddf1
@rahidzeynal @eukub
Typo deicmal -> decimal (TheAlgorithms#11169)
826f64d
@Clarkzzzzz @cclauss
@pre-commit-ci @eukub
add graphs/ant_colony_optimization_algorithms.py (TheAlgorithms#11163)
8ecbc70 
* add ant_colonyant_colony_optimization_algorithms.py

* Modify details

* Modify type annotation

* Add tests for KeyError, IndexError, StopIteration, etc.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@moaldeen @cclauss @eukub
Bug fix combinations (TheAlgorithms#11158)
3c2925d 
* Update all_combinations.py

The original implementation had limitations in handling edge cases and certain input parameters, leading to potential RecursionError.

* Update all_combinations.py

Added checks to handle cases where n or k are negative or where k is greater than n. In such scenarios, the function now returns an empty list, avoiding invalid recursive calls.

* Update error handling

Added checks to handle cases where `n` or `k` are negative or where `k` is greater than `n`. In such scenarios, the function now returns an empty list, avoiding invalid recursive calls.

* Update backtracking/all_combinations.py

* Update all_combinations.py

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
@pre-commit-ci @cclauss @eukub
[pre-commit.ci] pre-commit autoupdate (TheAlgorithms#11154)
f474f45 
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.1.4 → v0.1.6](astral-sh/ruff-pre-commit@v0.1.4...v0.1.6)
- [github.com/psf/black: 23.10.1 → 23.11.0](psf/black@23.10.1...23.11.0)
- [github.com/tox-dev/pyproject-fmt: 1.4.1 → 1.5.1](tox-dev/pyproject-fmt@1.4.1...1.5.1)
- [github.com/pre-commit/mirrors-mypy: v1.6.1 → v1.7.0](pre-commit/mirrors-mypy@v1.6.1...v1.7.0)

* updating DIRECTORY.md

* Update spiral_print.py

* Update matrix/spiral_print.py

* Update matrix/spiral_print.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@cyrixninja @pre-commit-ci
@cclauss @eukub
Create Spearman's rank correlation coefficient (TheAlgorithms#11155)
7922760 
* Create spearman_rank_correlation_coefficient.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixed Issues

* Added More Description

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixed Issues

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Tried Fixing Issues

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Tried Fixing Issues

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixed Issues

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixed Issues

* Apply suggestions from code review

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update maths/spearman_rank_correlation_coefficient.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@Suyashd999 @cclauss @eukub
Added doctest to binary_search_tree.py (TheAlgorithms#11145)
414f854 
* Added doctest to binary_search_tree.py

* Apply suggestions from code review

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
@pedram-mohajer @pre-commit-ci
@cclauss @eukub
Update levenshtein_distance.py (TheAlgorithms#11171)
c36b5a7 
* Update levenshtein_distance.py

* Update levenshtein_distance.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update levenshtein_distance.py

* Update levenshtein_distance.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update levenshtein_distance.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update levenshtein_distance.py

* Update levenshtein_distance.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@pedram-mohajer @eukub
Add doctest to is_safe function (TheAlgorithms#11183)
9b8e185
@pre-commit-ci @eukub
[pre-commit.ci] pre-commit autoupdate (TheAlgorithms#11184)
262c01f 
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/pre-commit/mirrors-mypy: v1.7.0 → v1.7.1](pre-commit/mirrors-mypy@v1.7.0...v1.7.1)

* updating DIRECTORY.md

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@pedram-mohajer @pre-commit-ci
@cclauss @eukub
Create smallestRange.py (TheAlgorithms#11179)
0a89331 
* Create smallestRange.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update smallestRange.py

* Update smallestRange.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update smallestRange.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update and rename smallestRange.py to smallestrange.py

* Update smallestrange.py

* Update smallestrange.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update smallestrange.py

* Rename smallestrange.py to smallest_range.py

* Update smallest_range.py

* Update smallest_range.py

* Update smallest_range.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@eukub
Merge branch 'Single-number-I' of github.com:eukub/Python into Single…
daa4b92 
…-number-I
@eukub eukub requested a review from cclauss as a code owner December 2, 2023 10:19
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss Awaiting requested review from cclauss cclauss is a code owner

1 more reviewer

@JeelGajera JeelGajera JeelGajera approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@eukub @JeelGajera @FishyGitHubUser @meg-1 @rahidzeynal @Clarkzzzzz @moaldeen @cyrixninja @Suyashd999 @pedram-mohajer